From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Konstantin Ananyev <konstantin.ananyev@huawei.com>
Subject: [PATCH v6 10/15] ring: add allocation function attributes
Date: Sat, 25 Jan 2025 10:36:44 -0800 [thread overview]
Message-ID: <20250125184010.782330-11-stephen@networkplumber.org> (raw)
In-Reply-To: <20250125184010.782330-1-stephen@networkplumber.org>
Use function attributes to catch cases where ring is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
---
lib/ring/rte_ring.h | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/lib/ring/rte_ring.h b/lib/ring/rte_ring.h
index 63a71d5871..28bfbde1f1 100644
--- a/lib/ring/rte_ring.h
+++ b/lib/ring/rte_ring.h
@@ -34,6 +34,7 @@
* for more information.
*/
+#include <rte_common.h>
#include <rte_ring_core.h>
#include <rte_ring_elem.h>
@@ -119,6 +120,16 @@ ssize_t rte_ring_get_memsize(unsigned int count);
int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count,
unsigned int flags);
+
+/**
+ * De-allocate all memory used by the ring.
+ *
+ * @param r
+ * Ring to free.
+ * If NULL then, the function does nothing.
+ */
+void rte_ring_free(struct rte_ring *r);
+
/**
* Create a new ring named *name* in memory.
*
@@ -183,16 +194,8 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count,
* - ENOMEM - no appropriate memory area found in which to create memzone
*/
struct rte_ring *rte_ring_create(const char *name, unsigned int count,
- int socket_id, unsigned int flags);
-
-/**
- * De-allocate all memory used by the ring.
- *
- * @param r
- * Ring to free.
- * If NULL then, the function does nothing.
- */
-void rte_ring_free(struct rte_ring *r);
+ int socket_id, unsigned int flags)
+ __rte_malloc __rte_dealloc(rte_ring_free, 1);
/**
* Dump the status of the ring to a file.
--
2.45.2
next prev parent reply other threads:[~2025-01-25 18:41 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 18:03 [PATCH 00/15] Add attributes to allocation functions Stephen Hemminger
2025-01-20 18:03 ` [PATCH 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-20 18:03 ` [PATCH 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-20 18:03 ` [PATCH 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-20 18:03 ` [PATCH 04/15] lpm: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 05/15] pipeline: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 06/15] acl: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 07/15] bitratestats: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 08/15] member: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 09/15] mempool: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 10/15] eventdev: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 11/15] ring: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 12/15] reorder: " Stephen Hemminger
2025-01-21 12:22 ` [EXTERNAL] " Volodymyr Fialko
2025-01-20 18:03 ` [PATCH 13/15] compressdev: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 14/15] telemetry: " Stephen Hemminger
2025-01-20 18:43 ` Bruce Richardson
2025-01-20 18:03 ` [PATCH 15/15] sched: " Stephen Hemminger
2025-01-20 18:40 ` [PATCH 00/15] Add attributes to allocation functions Bruce Richardson
2025-01-20 18:42 ` Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 04/15] lpm: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 05/15] pipeline: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 06/15] acl: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 07/15] bitratestats: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 08/15] member: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 09/15] mempool: " Stephen Hemminger
2025-01-22 20:17 ` Morten Brørup
2025-01-22 17:32 ` [PATCH v2 10/15] eventdev: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 11/15] ring: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 12/15] reorder: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 13/15] compressdev: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 14/15] telemetry: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 15/15] sched: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 00/15] Add allocation annotation to more functions Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 04/15] lpm: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 05/15] acl: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 06/15] bitratestats: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 07/15] member: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 08/15] mempool: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 09/15] eventdev: " Stephen Hemminger
2025-01-25 18:36 ` Stephen Hemminger [this message]
2025-01-25 18:36 ` [PATCH v6 11/15] reorder: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 12/15] compressdev: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 13/15] telemetry: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 14/15] sched: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 15/15] doc: add release note about allocation attributes Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250125184010.782330-11-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).