From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3A5B45F6A; Tue, 28 Jan 2025 19:51:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5641340151; Tue, 28 Jan 2025 19:51:45 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 0541940144 for ; Tue, 28 Jan 2025 19:51:44 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-21680814d42so98741745ad.2 for ; Tue, 28 Jan 2025 10:51:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1738090303; x=1738695103; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OT9p+MawDgEb2vkLVjGnFdEXyDLjxRjyHsA8sOuvJ/o=; b=Y/91PQ7h6GiMfxTPy9laZ9u0SlDGRs64jaejlc78UCuedIaw+SkmpUDB3azw2rvLL6 ztHDscUY8t7LCLkKY+/A/TlgLusJ2QnuUCc+FuviO8g99Om1Jz9NGGzBHSbHOnWBieHr 7f4yoNw/WLbhrxZkdJ7GGkI4nx+bseEoUcfCaJiPYjj6PMu26pio6Z4nHjYP/07Ppobz satHo1O8K+Pn0astUVQKjQxnqXWOE1ABXLjtNUTxt7Lte+AWNGmbUKXlrFxPkiKmRnP8 v8Qf6Rw1LLwHZhRa+IpPkrwgNI7aF6E2udnKjLPP3GaWkIhkHJziyeagh2hP3dmxEek8 OaUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738090303; x=1738695103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OT9p+MawDgEb2vkLVjGnFdEXyDLjxRjyHsA8sOuvJ/o=; b=wRoQFVDLF/609l0TyoENAeVIJ9uWWOGEpIaTuQWslrt/5OvE1GdBohbLBzIYHRQBRo uaVBF+kqhxqNUubu6FcGh2UIvY9++cGdgtG8b205e+nEL4efPWXc3KIkUU9aZDfH8LeI Cf5GSM0fnmnwv3Auf/jGS0btSW1z72VJ6ki4e4NsyhTqsz8G4FxSOe7lSwmXJZV+ZOfP nymVL8i3wqFo6609foWdKSQO4R4ZpKMiZ3SWO+3fGNXFJ75d71yS/laYuJPPJg/jQA38 poU8n552wLVD45dH6N8PKo9KJMEfqdYskiwAisaIMnc4XfkS40zBg9ITZ3eM1hnaWavm Hvig== X-Gm-Message-State: AOJu0Yzw0svrtT8YaBFjXw32Fm4WUIaMAgiRNsXNIT/uY7dQZgvvh1Au YHhuKfTi5E8aJIx8UokvjeaiWLMWBAx5oFeWcjnaphcIwA2wwc83uMCmlZ/bBj9QDws0q4eX7tB D X-Gm-Gg: ASbGnctjn6SJHJ7g6uWN1dDPIRTovxQIovhdhRZGL9XnBdvDyHFL15djxucrBJqCEE2 zozQpz0BOWTS+w4DXJoXNvRo1ACLPzIb9o2vbOgpqEyiKScTB4m8z3CutFaSPfEoqj14AVSaau2 TO4v+08Zajvr0POKc2km0TO3TOl0/V5iYsRxftPA60RatiBBRj1Z3V0TfOYTI7S76rfhXCqs5cY Om7KV39DRUS376le8Yc36jj4/8+o6BZlRG2vGL1NeRs9heJbpFg72zHJuud97fSbBNfJ/LfcYU8 dtB2o226eaUQR8XB7ROe4HJNUxZyEqPBEGotq2ooBr35nSnB/HZG7bmAP5iun/iPmmU5 X-Google-Smtp-Source: AGHT+IH+/LLEZpiQ2lUtMk9C4Bvh43V9J5B7D4B43AuGs+idfr1Fx3g6ucu2xVbVVV725djAqed0MA== X-Received: by 2002:a05:6a21:150e:b0:1e0:c8c5:9b1c with SMTP id adf61e73a8af0-1ed7a5b66b8mr572206637.9.1738090303075; Tue, 28 Jan 2025 10:51:43 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72f8a76115bsm9797931b3a.108.2025.01.28.10.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 10:51:42 -0800 (PST) Date: Tue, 28 Jan 2025 10:51:41 -0800 From: Stephen Hemminger To: Serhii Iliushyk Cc: dev@dpdk.org, mko-plv@napatech.com, ckm@napatech.com Subject: Re: [PATCH v1 00/31] net/ntnic: bugfixes and refactoring Message-ID: <20250128105141.5a4f333c@hermes.local> In-Reply-To: <20250121170814.3252171-1-sil-plv@napatech.com> References: <20250121170814.3252171-1-sil-plv@napatech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 21 Jan 2025 18:07:38 +0100 Serhii Iliushyk wrote: > These patches include fixes for issues detected by the Coverity Scan tool and internal tests. > > Danylo Vodopianov (26): > net/ntnic: fix index verification > net/ntnic: add thread check return code > net/ntnic: add return code handling > net/ntnic: add array index verification > net/ntnic: fix realloc memory leak > net/ntnic: fix array index verification > net/ntnic: add var definition transparently > net/ntnic: add proper var freed > net/ntnic: remove deadcode > net/ntnic: fix potentially overflow > net/ntnic: add null checking > net/ntnic: fix overflow issue > net/ntnic: fix untrusted loop bound > net/ntnic: add null checking > net/ntnic: move null checking > net/ntnic: fix var size > net/ntnic: fix var overflow > net/ntnic: remove dead code > net/ntnic: remove convert error func > net/ntnic: fix array verification > net/ntnic: fix memory leak > net/ntnic: remove unused code > net/ntnic: refactor RSS implementation > net/ntnic: fix age timeout recalculation into fpga unit > net/ntnic: rework age event generation > net/ntnic: fix group print > > Oleksandr Kolomeiets (2): > net/ntnic: remove extra address-of operator > net/ntnic: remove extra check for null > > Serhii Iliushyk (3): > net/ntnic: extend module mapping > net/ntnic: refactoring of the FPGA initialization > net/ntnic: remove tag EXPERIMENTAL > > MAINTAINERS | 2 +- > .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 9 - > drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 10 +- > drivers/net/ntnic/include/create_elements.h | 1 - > drivers/net/ntnic/include/flow_api.h | 9 - > drivers/net/ntnic/include/flow_api_engine.h | 2 + > drivers/net/ntnic/include/hw_mod_backend.h | 16 +- > .../link_mgmt/link_100g/nt4ga_link_100g.c | 2 +- > drivers/net/ntnic/meson.build | 1 + > drivers/net/ntnic/nthw/core/nthw_fpga.c | 14 +- > drivers/net/ntnic/nthw/flow_api/flow_api.c | 67 +- > drivers/net/ntnic/nthw/flow_api/flow_group.c | 26 + > .../net/ntnic/nthw/flow_api/flow_hsh_cfg.c | 661 ++++++++++++++ > .../net/ntnic/nthw/flow_api/flow_hsh_cfg.h | 17 + > .../ntnic/nthw/flow_api/hw_mod/hw_mod_flm.c | 14 +- > .../ntnic/nthw/flow_api/hw_mod/hw_mod_hsh.c | 19 +- > .../ntnic/nthw/flow_api/hw_mod/hw_mod_pdb.c | 18 +- > .../profile_inline/flow_api_hw_db_inline.c | 29 +- > .../profile_inline/flow_api_profile_inline.c | 817 +----------------- > .../profile_inline/flow_api_profile_inline.h | 4 - > .../ntnic/nthw/flow_filter/flow_nthw_rpp_lr.c | 10 +- > .../nthw/supported/nthw_fpga_mod_str_map.c | 24 + > drivers/net/ntnic/ntnic_ethdev.c | 16 +- > drivers/net/ntnic/ntnic_filter/ntnic_filter.c | 155 ++-- > drivers/net/ntnic/ntnic_mod_reg.h | 6 - > drivers/net/ntnic/ntnic_xstats/ntnic_xstats.c | 10 +- > 26 files changed, 915 insertions(+), 1044 deletions(-) > create mode 100644 drivers/net/ntnic/nthw/flow_api/flow_hsh_cfg.c > create mode 100644 drivers/net/ntnic/nthw/flow_api/flow_hsh_cfg.h > I assume that since driver was experimental, there is no point in backporting any of this to stable.