From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4FC546080; Tue, 28 Jan 2025 21:12:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5934F40268; Tue, 28 Jan 2025 21:12:12 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 2CCBD40267 for <dev@dpdk.org>; Tue, 28 Jan 2025 21:12:10 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-21636268e43so133195125ad.2 for <dev@dpdk.org>; Tue, 28 Jan 2025 12:12:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1738095129; x=1738699929; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=wVvkKNvqOC3iy4t6FskbyRr7iFv8TzHzBzzrSIBh0SQ=; b=T22HJ6KNN/XzHhx/E2yLCa42Ccf/Mh9DDV6N0xn4Ujik9YhxqzBKEHZJbXOqsXZoNc RqJrUfwoBheCPLzDsCe2C3dxOV7nr4H7R/38C0bIkH/+I194JGS29W7DsE09FlcTOPyw x1TYE4eqSwTLaypf3+rL9AWXcW4D/La7RIyD2i/1qYQDY7LJxdGBskDghdD0csBcLsRd wbNrE34vc/SRfSUkLWShEGP+RAWA98fOpGc1SsFrCuYfw6eXj9obDVX34PBSVzoP8Yki pDf5enY5a5zNIcgQ8vDTB8hX96cv+JGub8n0KTDFkdBc1zmbYrzdPuGWiung/nv3TSuM qhig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738095129; x=1738699929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wVvkKNvqOC3iy4t6FskbyRr7iFv8TzHzBzzrSIBh0SQ=; b=rzyQvxEWBk5ll9SHVqNApbaY0donNZRiWoctxjVn8yyzJxLQQOiabPgS7IS5ZPBFFF BmxC9n06ucDaVqeknQ5w/xrm6jkCu0y1DiX5E4sCDf7XK/9E0+Nuz0q9JoHwdyX0c9eC lyj3e8RnFx8PK3NUnG/ajsmZ799KRw+uv7SDl12wMeYl0cUt66jDZ9HLUmJ2MFlo1Ewv H+LbcR9gmnJGbqw7L3K/VwJ1VTlvR9Zr9xqgTqpTue5H5+TVydmn76nLwCqdXvxFMZQb oDtxfABVyHl1JvgEkQ+g+tROcWUu95XgvWUF3DU9k1Kvl6lCGNvfYWn+sW8EwW+/xn0j PJiw== X-Gm-Message-State: AOJu0YyDxRPs6sK1xKcHjQr0D0EgvYoSE7lSy7tkxofkPje2ylgqhzS7 DJS2ufyeTCaIgpAGpvbkGMG4BB+eQyHd9CfN8ETYsM1mhVSjo19/GBPu8SA1p3g= X-Gm-Gg: ASbGncubbKfpEhB4+YjbCzUvfT1HqwOEiL0ehCv+xpNtIO/RJQ6Dh2Q/IKKMAtDGWeD RQd95CFk75uSQc6jHJxRZ57ePbn1B4yK+UwBGxCVudFBBL8uH+N08jYyVG6yUJwZSLFnxut2+Da 2IX6b9bdqQW6R5vc5CA12/VCnM0gwe0ZLYqBlqkRRDkEDowKVM1uWnr7cj9IYCNhOJT6DsaIFKM 54DRI7xNNtiOIVQ2yQkLMtwEli5YqzqQau2306dIxaATKS0qvGCDb5ZpjaWYhpOdhd0byfiSftI Ss2vqE4j3IBjf3MK6TtYs0Dv7e9Xuqd6hnC4u8k9nG0pxpQqvaaeNP+jDv8nDs2zhQLm X-Google-Smtp-Source: AGHT+IEdmsojXSWS3lQVFDv9/5Lcod06j6CpmFZSJ+MtAtIxtQdiAb48RfZBxIgqEeqkW3gqXnm9OQ== X-Received: by 2002:a17:903:11d0:b0:215:853d:38 with SMTP id d9443c01a7336-21dd7d742f1mr6589035ad.25.1738095129070; Tue, 28 Jan 2025 12:12:09 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da41415c7sm86088885ad.108.2025.01.28.12.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 12:12:08 -0800 (PST) Date: Tue, 28 Jan 2025 12:12:06 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Junlong Wang <wang.junlong1@zte.com.cn> Cc: dev@dpdk.org Subject: Re: [PATCH v9 00/15] net/zxdh: updated net zxdh driver Message-ID: <20250128121206.1c8ed9e3@hermes.local> In-Reply-To: <20250121034433.3033681-1-wang.junlong1@zte.com.cn> References: <20241210055333.782901-2-wang.junlong1@zte.com.cn> <20250121034433.3033681-1-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, 21 Jan 2025 11:44:18 +0800 Junlong Wang <wang.junlong1@zte.com.cn> wrote: > V9: > - Remove unnecessary __rte_packed* in stats structure. > > V8: > - using __rte_packed_begin/__rte_packed_end replace __rte_packed. > > V7: > - resolved warning '-Waddress-of-packed-member' > in function 'zxdh_dev_rss_reta_update'. > > V6: > - Remove unnecessary __rte_packed in the virtqueue structure and others. > - Remove Some blank before or after log message, > and remove some end with period in log message. > > V5: > - Simplify the notify_data part in the zxdh_notify_queue function. > - Replace rte_zmalloc with rte_calloc in the rss_reta_update function. > - Remove unnecessary check in mtu_set function. > > V4: > - resolved ci compile issues. > > V3: > - use rte_zmalloc and rte_calloc to avoid memset. > - remove unnecessary initialization, which first usage will set. > - adjust some function which is always return 0, changed to void > and skip the ASSERTION later. > - resolved some WARNING:MACRO_ARG_UNUSED issues. > - resolved some other issues. > > V2: > - resolve code style and github-robot build issue. > > V1: > - updated net zxdh driver > provided insert/delete/get table code funcs. > provided link/mac/vlan/promiscuous/rss/mtu ops. > > Junlong Wang (15): > net/zxdh: zxdh np init implementation > net/zxdh: zxdh np uninit implementation > net/zxdh: port tables init implementations > net/zxdh: port tables unint implementations > net/zxdh: rx/tx queue setup and intr enable > net/zxdh: dev start/stop ops implementations > net/zxdh: provided dev simple tx implementations > net/zxdh: provided dev simple rx implementations > net/zxdh: link info update, set link up/down > net/zxdh: mac set/add/remove ops implementations > net/zxdh: promisc/allmulti ops implementations > net/zxdh: vlan filter/ offload ops implementations > net/zxdh: rss hash config/update, reta update/get > net/zxdh: basic stats ops implementations > net/zxdh: mtu update ops implementations > > doc/guides/nics/features/zxdh.ini | 18 + > doc/guides/nics/zxdh.rst | 17 + > drivers/net/zxdh/meson.build | 4 + > drivers/net/zxdh/zxdh_common.c | 28 +- > drivers/net/zxdh/zxdh_common.h | 1 + > drivers/net/zxdh/zxdh_ethdev.c | 602 +++++++- > drivers/net/zxdh/zxdh_ethdev.h | 48 +- > drivers/net/zxdh/zxdh_ethdev_ops.c | 1573 +++++++++++++++++++++ > drivers/net/zxdh/zxdh_ethdev_ops.h | 80 ++ > drivers/net/zxdh/zxdh_msg.c | 205 ++- > drivers/net/zxdh/zxdh_msg.h | 232 ++++ > drivers/net/zxdh/zxdh_np.c | 2060 ++++++++++++++++++++++++++++ > drivers/net/zxdh/zxdh_np.h | 579 ++++++++ > drivers/net/zxdh/zxdh_pci.c | 27 +- > drivers/net/zxdh/zxdh_pci.h | 9 +- > drivers/net/zxdh/zxdh_queue.c | 242 +++- > drivers/net/zxdh/zxdh_queue.h | 189 ++- > drivers/net/zxdh/zxdh_rxtx.c | 804 +++++++++++ > drivers/net/zxdh/zxdh_rxtx.h | 23 +- > drivers/net/zxdh/zxdh_tables.c | 794 +++++++++++ > drivers/net/zxdh/zxdh_tables.h | 231 ++++ > 21 files changed, 7671 insertions(+), 95 deletions(-) > create mode 100644 drivers/net/zxdh/zxdh_ethdev_ops.c > create mode 100644 drivers/net/zxdh/zxdh_ethdev_ops.h > create mode 100644 drivers/net/zxdh/zxdh_np.c > create mode 100644 drivers/net/zxdh/zxdh_np.h > create mode 100644 drivers/net/zxdh/zxdh_rxtx.c > create mode 100644 drivers/net/zxdh/zxdh_tables.c > create mode 100644 drivers/net/zxdh/zxdh_tables.h > Did minor conflict resolution on release notes and applied to dpdk-next-net (for-main).