From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B10304611D;
	Wed, 29 Jan 2025 17:25:25 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3A6DC402AE;
	Wed, 29 Jan 2025 17:25:25 +0100 (CET)
Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com
 [209.85.214.170])
 by mails.dpdk.org (Postfix) with ESMTP id 62CDC40274
 for <dev@dpdk.org>; Wed, 29 Jan 2025 17:25:24 +0100 (CET)
Received: by mail-pl1-f170.google.com with SMTP id
 d9443c01a7336-2166360285dso121151505ad.1
 for <dev@dpdk.org>; Wed, 29 Jan 2025 08:25:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1738167923;
 x=1738772723; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=wEwnW4HVqJwNDz4ygj36/tafh2SOZ2kOk/3l21i17yc=;
 b=PKNcVvSPNbiizaO8rFnkD+SF7i49Ot4lHrGhezwJJtNgHG90MMPavflqCr10bGW8B5
 Ng4I5f/rIunKP/N3U3F/gJNb/61e8rjeogHLAGKawzEGpc6SKMUJY5tgBwmU2QNux8EB
 /NYRqNPY5iJnvKpSR2lSxRw5pjNiv6dJc4y75zciEXptknCavLFcUrokyk3UtUi/nhxW
 +xr9oc2qpdOVDpY3jXMKAL73vdUzxj8H5X8b5xlADcL3t3byQlVoJX57TFdKdxWlemby
 7Sbox+qQNARenTcneyvYO9cd2uff3CYHgRzUFh2Kro5/oxGg37crHL+/crBb/0IRh5Ku
 pBeg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1738167923; x=1738772723;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=wEwnW4HVqJwNDz4ygj36/tafh2SOZ2kOk/3l21i17yc=;
 b=R8Mt99kVaKaMB1v2Tiyh4HA/NUJiS9RqkvxEpc1S2b1fngve31km65O9mO8oayMrP1
 z2E1cwtdTB8mgIDCfbwnospg4OMWPH97+cxRATo5l8D5JcROcHSlmpj9OPxvHL8wDz6w
 hSSJxdhX58UV1JZBjLybmgxv/3wfLZwBwianfi4q0J6pWpb226UVRfosJWHwqKqLo4MI
 D6+HbINQtTVTQR4s7epw1a04TKwtG5Fx3AvXhegM0vmftSLB1y4HXn71iMspjTnWGtnq
 fCiOd3STpfdeOBUrYjzm6ss9IUp88C5kGW5teTsGOeTobF/MUJFX0tBMjLr5/kULuIxp
 sCTA==
X-Gm-Message-State: AOJu0Ywrb2zmWhiBTifrTUxY61JCT0Kl7aUMgh/N3+JwpAVdEEcP055r
 o3lgE4IIPOA77YqQJQ/ApcjTNOjvyXJYcqm+7iqcXU+yRobWoYquT+WHmb9mz9Q=
X-Gm-Gg: ASbGncvqOqHjDF7BoO4rHZsbxnBABwzb4KIrisr3S6b1eX9TLUny+yfj01RMY7osj0F
 4rGRzsRJTXa4LLvR2wKr6b5u1ADcbbglNyRCTm4ZHtMKXRbTWj9YoyoD1/3epul4kpx2GsVvrBs
 WUdJzf77e5I5xCaLnTanhb5ShmxHG1NWWMaFsZW4thJ9t2kaa73q9MiI0A3Ng+W9Cz7rTiJImhb
 zMmskGipJ9y5cn8ph+scZaPSFGbjvsMaqmB7MYwbvjGeEBvE6WoYT7hdBPgmt6ioahPDShh73fT
 qH9TjajQCkeeXduc4zMnJMW8IS8iqHHrClUg5DhQlygIrjq2CNsf3VWacoUcjYMwRjH7
X-Google-Smtp-Source: AGHT+IFXlgUTwVrnzLvDZmVkypbl9NAsB4X6iHsn87/TksUujOU1ZnQ9MpjR4EuLH1B9bdX+gS4s+g==
X-Received: by 2002:a17:902:db02:b0:20c:9821:6998 with SMTP id
 d9443c01a7336-21dd7c4636amr64212745ad.10.1738167923176; 
 Wed, 29 Jan 2025 08:25:23 -0800 (PST)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-21da424e827sm101109615ad.233.2025.01.29.08.25.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 29 Jan 2025 08:25:22 -0800 (PST)
Date: Wed, 29 Jan 2025 08:25:18 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Shani Peretz <shperetz@nvidia.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, Tyler Retzlaff
 <roretzla@linux.microsoft.com>, Parav Pandit <parav@nvidia.com>, Xueming Li
 <xuemingl@nvidia.com>, Nipun Gupta <nipun.gupta@amd.com>, Nikhil Agarwal
 <nikhil.agarwal@amd.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, "Sachin
 Saxena" <sachin.saxena@nxp.com>, Rosen Xu <rosen.xu@intel.com>, Chenbo Xia
 <chenbox@nvidia.com>, Tomasz Duszynski <tduszynski@marvell.com>, "Chengwen
 Feng" <fengchengwen@huawei.com>, Long Li <longli@microsoft.com>, Wei Hu
 <weh@microsoft.com>, Bruce Richardson <bruce.richardson@intel.com>, "Kevin
 Laatz" <kevin.laatz@intel.com>, Jan Blunck <jblunck@infradead.org>
Subject: Re: [PATCH v4] bus: fix inconsistent representation of PCI numbers
Message-ID: <20250129082518.47630942@hermes.local>
In-Reply-To: <20250129085416.226718-1-shperetz@nvidia.com>
References: <20240708165145.1405107-1-shperetz@nvidia.com>
 <20250129085416.226718-1-shperetz@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, 29 Jan 2025 10:54:16 +0200
Shani Peretz <shperetz@nvidia.com> wrote:

> +create_pci_dev(const char *name)
> +{
> +	int port_id;
> +	uint8_t slave_mac1[] = {0x00, 0xFF, 0x00, 0xFF, 0x00, 0x00 };
> +	struct rte_ether_addr *mac_addr = (struct rte_ether_addr *)slave_mac1;

Use different initializer and you can avoid the need for cast here.


>  
> +/**
> + * General device name comparison. Will compare by using the specific bus
> + * compare function or by comparing the names directly.
> + *
> + * @param dev
> + *   Device handle.
> + * @param name
> + *   Name to compare against.
> + * @return
> + *   0 if the device matches the name. Nonzero otherwise.
> + */
> +__rte_internal
> +int rte_cmp_dev_name(const struct rte_device *dev, const void *name);

It would make more sense to me if name was a character not void pointer.

The design might be clearer if bus address was more of an typedef with
a pointer and size together. Treat it more like an object.