From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFEA446128; Wed, 29 Jan 2025 18:48:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31CB840274; Wed, 29 Jan 2025 18:48:10 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id F09FD4026B for ; Wed, 29 Jan 2025 18:48:08 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 034EE2066C19; Wed, 29 Jan 2025 09:48:08 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 034EE2066C19 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1738172888; bh=H6heSsA0FOZrafUxH8Zg5QNPksHdzGZp4S9t/p06g58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gH/Xw7NLe0sy4bULR63x4m2DgVyhadX7Nj2Kkch82Qn8w7WImeN+HRlUvMzcq+0QU 5YCRxmn8Y7KjhGX65OlPEAdxJ7uIC6zBBo5sxUeHvWEIOzdrp6T3nfwhDoMcymMQ0Q ydIJ8r9yAEcXUr49HwSKUuMhAyI4eyRgqTESrQAM= Date: Wed, 29 Jan 2025 09:48:07 -0800 From: Andre Muezerie To: David Marchand Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, Morten =?iso-8859-1?Q?Br=F8rup?= , Thomas Monjalon , Raslan Darawsheh Subject: Re: [PATCH v16 0/3] add diagnostics macros to make code portable Message-ID: <20250129174807.GA31442@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> <1737498970-4631-1-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 29, 2025 at 03:16:51PM +0100, David Marchand wrote: > On Wed, Jan 29, 2025 at 2:26 PM David Marchand > wrote: > > > > On Tue, Jan 21, 2025 at 11:36 PM Andre Muezerie > > wrote: > > > > > > v16: > > > * Updated comment for RTE_CAST_PTR. > > > > > > v15: > > > * Fixed a comment in rte_common.h to make Doxygen happy. > > > * Fixed a typo (extra comma). > > > * Added missing RTE_PTR_UNQUAL needed for ARM64. > > > > > > v14: > > > * Renamed RTE_PTR_DROP_QUALIFIERS into RTE_PTR_UNQUAL to more resemble > > > C23 typeof_unqual. > > > * Added macro RTE_CAST_PTR to make the cast more readable when removing > > > a type qualifier from a pointer. > > > > > > v13: > > > * Renamed RTE_IGNORE_CAST_QUAL into RTE_PTR_DROP_QUALIFIERS. > > > * Added (void *) cast to RTE_PTR_DROP_QUALIFIERS to avoid the need > > > for casting the result in most places where the macro is used. > > > > > > v12: > > > * Added macro RTE_IGNORE_CAST_QUAL and used it as a more compact and > > > readable form to suppress warnings where a cast is used to remove > > > a type qualifier. > > > > > > v11: > > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > > it was needed. > > > > > > v10: > > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > > it was needed. > > > > > > v9: > > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > > it was needed. > > > > > > v8: > > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > > it was needed. > > > > > > v7: > > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > > it was needed. > > > > > > v6: > > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > > it was needed. > > > > > > v5: > > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > > it was needed. > > > > > > v4: > > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > > it was needed. > > > > > > v3: > > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > > it was needed. > > > > > > v2: > > > * Removed __rte_diagnostic_ignored_wstrict_aliasing (introduced > > > in v1). > > > * Removed the pragmas from many files where they were not needed. > > > * In the files where the pragmas were indeed needed, reduced the > > > scope during which they are active, reducing the chance that > > > unforeseen issues are hidden due to warning suppression. > > > > > > Andre Muezerie (3): > > > eal: add diagnostics macros to make code portable > > > drivers/common: add diagnostics macros to make code portable > > > drivers/net: add diagnostics macros to make code portable > > > > I moved a bit the casting macros in rte_common.h (and put them next to > > RTE_CAST_FIELD). > > Thanks for this work André, series applied. > > CI is not happy with those changes on ppc64le (this was caught by OBS > after pushing). > See, for example, > https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Fedora_Rawhide/ppc64le > > Please send a fix. > > > -- > David Marchand Thanks for letting me know David, and also for so quickly smoke-testing my new fix in a container. The fix can be found here: https://patches.dpdk.org/project/dpdk/list/?series=34479 Andre Muezerie