From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6196C46143; Thu, 30 Jan 2025 04:59:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3EEA40156; Thu, 30 Jan 2025 04:59:19 +0100 (CET) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id 2A8E8400D6 for ; Thu, 30 Jan 2025 04:59:19 +0100 (CET) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2ee8aa26415so533923a91.1 for ; Wed, 29 Jan 2025 19:59:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1738209558; x=1738814358; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=P0Igae8zggkh+xT1qi9KbfM5f1t6bmfUmNs3zVaSvRw=; b=NFbJbvXNkxoFPPODrCXVN13nWm0G3s7l7nRkRUeZt+WSxFlOuJm7wBYxHjX55QlKUH Me1GcoNDgYAqmCIa0WEuCVmlAUKLIw+aRAdH/hGAo65Q10TI/1It4mHr91O3K7TJBBQq /RdgWBqfAd0Xp6TuJ5BKQfel2AAks4ZsTj4v7zqsZwgKliHdGS0ArHVLoAGwfX+2NTL8 ZTbobJWgRk6amZh1VV8xm4G5PmNQPdGWtvvCbYtMusfzYsMAlv2Luwc4Zx8LN83UfyPe /onc+WKrOO4c6Mvzr2AcIzD3UkcbaTgLou88Y1nNRbDZ9AQXd2fLJ9UPTtrIY61TL1HJ nzSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738209558; x=1738814358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P0Igae8zggkh+xT1qi9KbfM5f1t6bmfUmNs3zVaSvRw=; b=nG0lByvV8d9HecYL3Ck5xLT0D518TRL9cyEiieG/ICSCMhemmrv6bgHAYvF7RfQ3f3 uuWioy2/i1A/c5CfsfKHwrSFNeqU74tAumcVHUkpYMbQXWTcNwUaTBuw8hwUvcmNAh7H relnC4m4nvy2VB4AFOjNBmK6A5dwywtBYouwNFmMQr3G3ywZwlZM/VHtN8yOPjpUVXrz gdJ/qSrT9DOMM6NGLH4Xq0JLIgBbrN3pG/JGqXeYOyRD6RMTnq6rKw1j9aHfhje0izRA B47opZTrSmlsHNCHeOgojwROCtlw1mM7ree9sJmSOBjpLRBOy2nvL4NetoajRzkLoPLN +rJQ== X-Forwarded-Encrypted: i=1; AJvYcCU4ywVvOO3Hc/JfuhI38ViECU11HlF6ZmmNEA738B0RVwOfo9a+GHy2ykaV+eGfLPIR4g4=@dpdk.org X-Gm-Message-State: AOJu0YxWmvrnqBcMx2NqDU+7APk3pzCQJmVHjJtF3CGGLiBCrmlYnYTx VC1vXirAoTvnKY5mkjLIsvLHHmRZlFEuad3UVeGoqzhdsBJ0BYgtb7TxqfgOir4= X-Gm-Gg: ASbGnctqM4cKd4mAWxaVd0WTccbEt7CfztkM7BMWF+Ud6pJnnJE25Xf5lUdJ6tx/jVO z88eBk1WGfIgknTg+hMXVvwg0XJ00WV/F42Tb+H2DXmo1n4Tulpn/Ef+RBKOj6Jd9iHJ7mKQkHK xhZQrHz5gdc4LpDPLsVWh89x2LzQwm2QQXczOxkpaiVP3tJmlMBVu4OF4mKGfC2PIV6tJo2Mopz zbDgyPqMdndDS8k3iaS6S4gVa3BX7w5/q9E3Y8hdURildms6o7SquxasjQAVIeAf/5vtPYcE6kk SDvKBqidV1EtfRXn1UCzFlXQTJYoM/XkQPbIRWjamPum3LuwQdHMMVV232eFTvs459LA X-Google-Smtp-Source: AGHT+IGzbXVTUvVc10ne6PGTcvNEGjTFp+eWdGuN3j1uVfO0VtWMjHQpejXFEz7vDIGEakTn1aSPSA== X-Received: by 2002:a05:6a00:2302:b0:72a:bc6a:3a85 with SMTP id d2e1a72fcca58-72fd0c72bbbmr8256656b3a.22.1738209557972; Wed, 29 Jan 2025 19:59:17 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72fe64275cfsm341018b3a.58.2025.01.29.19.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2025 19:59:17 -0800 (PST) Date: Wed, 29 Jan 2025 19:59:15 -0800 From: Stephen Hemminger To: Long Li Cc: "longli@linuxonhyperv.com" , Ferruh Yigit , Andrew Rybchenko , Wei Hu , "dev@dpdk.org" Subject: Re: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events Message-ID: <20250129195915.758792b4@hermes.local> In-Reply-To: References: <1738028106-25239-1-git-send-email-longli@linuxonhyperv.com> <1738028106-25239-4-git-send-email-longli@linuxonhyperv.com> <20250128130056.399a1dd5@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 29 Jan 2025 00:10:12 +0000 Long Li wrote: > Another approach is to modify EAL to never delete driver arguments when a device is removed. i.e., It doesn't call rte_devargs_remove() on device removal, instead keep those devargs for the lifetime of the process. Do you think this is a better approach? This will save work if other drivers want to cache devargs list for device hot plug events. Agree, that having devargs be smart enough to maintain the list for future hotplug is sensible. Do other drivers that support hotplug have the same issue, or does no one ever use devargs with things like failsafe.