From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FCDB46143; Thu, 30 Jan 2025 04:37:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C25B40156; Thu, 30 Jan 2025 04:37:34 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 34679400D6 for ; Thu, 30 Jan 2025 04:37:33 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 48472203F2A0; Wed, 29 Jan 2025 19:37:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 48472203F2A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1738208252; bh=0bo8RUihWN+Lf38St09Yrnxls0OBbM/wWuBxgnUT6/M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kBdIemsurhgTVgm6gpVanIOL3K8/8eOrrWix6mhfhiZsgxem2maUupo2xilHNsqcX 3LeuAWTlidQeTJCgq8I/hSzchmgg7nz1IGmjKC4p6UkbieJbx1ZJtVt2kdd3z+cOXS fCs/6YIIFN7fCbN3E+YT1bdpNNf9zAPXfPa+KcR0= Date: Wed, 29 Jan 2025 19:37:32 -0800 From: Andre Muezerie To: Ali Alnubani Cc: "dev@dpdk.org" , "stephen@networkplumber.org" , "bruce.richardson@intel.com" Subject: Re: [PATCH v16 3/3] drivers/net: add diagnostics macros to make code portable Message-ID: <20250130033732.GA15035@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> <1737498970-4631-1-git-send-email-andremue@linux.microsoft.com> <1737498970-4631-4-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 29, 2025 at 09:10:40PM +0000, Ali Alnubani wrote: > > -----Original Message----- > > From: Ali Alnubani > > Sent: Wednesday, January 29, 2025 11:08 PM > > To: Andre Muezerie > > Cc: dev@dpdk.org; stephen@networkplumber.org; bruce.richardson@intel.com > > Subject: RE: [PATCH v16 3/3] drivers/net: add diagnostics macros to make code > > portable > > > > > -----Original Message----- > > > From: Andre Muezerie > > > Sent: Wednesday, January 22, 2025 12:36 AM > > > To: andremue@linux.microsoft.com > > > Cc: dev@dpdk.org; stephen@networkplumber.org; bruce.richardson@intel.com > > > Subject: [PATCH v16 3/3] drivers/net: add diagnostics macros to make code > > > portable > > > > > > It was a common pattern to have "GCC diagnostic ignored" pragmas > > > sprinkled over the code and only activate these pragmas for certain > > > compilers (gcc and clang). Clang supports GCC's pragma for > > > compatibility with existing source code, so #pragma GCC diagnostic > > > and #pragma clang diagnostic are synonyms for Clang > > > (https://clang.llvm.org/docs/UsersManual.html). > > > > > > Now that effort is being made to make the code compatible with MSVC > > > these expressions would become more complex. It makes sense to hide > > > this complexity behind macros. This makes maintenance easier as these > > > macros are defined in a single place. As a plus the code becomes > > > more readable as well. > > > > > > Signed-off-by: Andre Muezerie > > > --- > > > > Hello, > > > > This patch is causing a build failure on PowerPC64, affecting both cross- > > compilation on x86_64 and native builds on PowerPC64 systems: > > > > drivers/net/mlx5/mlx5_rxtx_vec_altivec.h:77:3: error: cast discards 'volatile' > > qualifier from pointer target type [-Werror=cast-qual] > > Compiler: powerpc64le-linux-gnu-gcc 9.4.0 > > > > > Regards, > > Ali Hi Ali. Sorry for the trouble caused. Unfortunately the CI pipeline did not catch this. A patch fixing this issue was submitted earlier today: https://patches.dpdk.org/project/dpdk/patch/1738172139-31201-1-git-send-email-andremue@linux.microsoft.com/ Regards, Andre Muezerie