From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FFC945F6A; Thu, 30 Jan 2025 19:24:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D75640DD6; Thu, 30 Jan 2025 19:24:12 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id F1B5340275 for ; Thu, 30 Jan 2025 19:24:10 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-216634dd574so13904685ad.2 for ; Thu, 30 Jan 2025 10:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1738261450; x=1738866250; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zOUzXbKwNPK6y2Xou0klprJSCS0iuiSMY6NgxjL1Zis=; b=WqMzcqGycxEvaRORW1MaIxPga4SoHYxelnEKVQbsnSrLscE59hAvgKrGxvaT55ZmjN JAkiRJFKk9VCK9Ou0bvGD5gkFBQkHxQ3lPaFhz3xWMVXrA7YGRSUMExXBxQQA55N4mW8 EoMV3crkFt91TYn8bHNWsBoKcvZ4IDc6NfcIaXsV5M3NYEBJv+D2G+O95zgy2Cco++Tw eShnZd33nRprdkZmRzi9sVzy8nYURYSSuJo4Vc+5Tsj/jzhyqaN0mo6kpZcVeoHxnFJP 4NbH3CF6jasQa9ii1Ig1MXIn4yf9S/ZiQcMDgyLl/KWtCk9R+SHGhsoAnV2EogFvZhK6 eyPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738261450; x=1738866250; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zOUzXbKwNPK6y2Xou0klprJSCS0iuiSMY6NgxjL1Zis=; b=ky0XAcdW/+Ic4etqlzIWJMPZt/bn2khY5PCdz7GVGRLf++SXTP9iWiUVXdjG60QZca y4JmAbLMXbGJK4AP/XUpaC/UyA9wMTArFrlFHAqcs24iFRWYUx8rzXaDHNDd96Y2+HEp SRuiL5CafandAy+4yntMtBlZpvm20JVCPCJ2FQ/1ksOpORqYD08wlsVMkYQeuGclKvJy JQyKB9de5Dc+kNN8NJmGk760xt4u7sLZTBoCmT/J8T392BeLVwUlJjk/Z48aP+brb5rY PgFa/idmLa/UPrT/7XOvhznCppfS9eWNglJ/Gu4ZvNu18olzRqEDSbO42rVtqwGXdmyN 39Ng== X-Gm-Message-State: AOJu0YwqwkuXqkq9/MhKbFDBf5vjGZdoycq73iDSKHW7nb6cFQiUzJro q/rBml6yPpZssgx9i/RFTp/0eWznx62EiV69sZxBxoIfUNwCcPoacyXzsnav+JY= X-Gm-Gg: ASbGnct6aTbtmM0gh6cxNj8CxYsbKjNDNTG9pRcuoMsDAw1wfT3oNlrc2ZBTvwQKSEN p5TmECOAshG+mx9lzxDe1t9aDDPB/Y3jQ5zvx0toAHC0ylOnkex1/Fw3tiaEYKBKKp1jpeIEvQE tR76t6PREJRGsbFBRGOja1ponlli9/4/ZF8LAKuh2QkEjYB1ptwSeN/WtJ1W2uo/bR5S+Wyl240 YJ30xTDYyKsq8ZV9e6lQCuS4ZVpSprEaCnXlA6RCwPSafByHkwWTm/tc0PLieX97zyHzqMv+SEg alFo0G0zJqubxzP72qDtdLl2NcJfdvObcn2HgLF3JY2eSuz40jubY9W+ytwhTN2wYXox X-Google-Smtp-Source: AGHT+IEKsHBe3uE+bI7WG7X6ebfgahSzzC3lxM8RbZOA1FkFv93y8cLQR+uCUoZmqRio6TLeW7ed8g== X-Received: by 2002:a17:902:f691:b0:21d:dba1:dd5e with SMTP id d9443c01a7336-21ddba1e30dmr104003755ad.25.1738261449978; Thu, 30 Jan 2025 10:24:09 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de31ee380sm17119345ad.12.2025.01.30.10.24.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2025 10:24:09 -0800 (PST) Date: Thu, 30 Jan 2025 10:24:07 -0800 From: Stephen Hemminger To: Ariel Otilibili Cc: dev@dpdk.org, stable@dpdk.org, Thomas Monjalon , David Marchand , Ciara Loftus , Maryam Tahhan Subject: Re: [PATCH 1/2] net/af_xdp: fix use after free in af_xdp_tx_zc() Message-ID: <20250130102407.39578285@hermes.local> In-Reply-To: <20250116195640.68885-2-ariel.otilibili@6wind.com> References: <20250116195640.68885-1-ariel.otilibili@6wind.com> <20250116195640.68885-2-ariel.otilibili@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 16 Jan 2025 20:56:38 +0100 Ariel Otilibili wrote: > tx_bytes is computed after both branches are tested. This might > produce a use after memory free. > > The computation is now moved into both branches. > > Bugzilla ID: 1440 > Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") > Signed-off-by: Ariel Otilibili > --- Acked-by: Stephen Hemminger