[PATCH 0/1] net/{octeon_ep,enetfec}: remove unused value

[PATCH 0/1] net/{octeon_ep,enetfec}: remove unused value

[Ariel Otilibili]

Hello,

This patch clears out the Coverity issues 385414 & 374016.

Thank you,

Ariel Otilibili (1):
  net/{octeon_ep,enetfec}: remove unused value

 drivers/net/enetfec/enet_ethdev.c   | 1 -
 drivers/net/octeon_ep/otx_ep_mbox.c | 3 ---
 2 files changed, 4 deletions(-)

-- 
2.47.1

[PATCH 1/1] net/{octeon_ep,enetfec}: remove unused value

[Ariel Otilibili]

Coverity issue: 385414, 374016
Fixes: c836a7ba33e ("net/octeon_ep: support mailbox between VF and PF")
Fixes: bb5b5bf1e5c ("net/enetfec: support queue configuration")
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
--
Cc: stable@dpdk.org
Cc: Vamsi Attunuru <vattunuru@marvell.com>
Cc: Apeksha Gupta <apeksha.gupta@nxp.com>
Cc: Sachin Saxena <sachin.saxena@nxp.com>
---
 drivers/net/enetfec/enet_ethdev.c   | 1 -
 drivers/net/octeon_ep/otx_ep_mbox.c | 3 ---
 2 files changed, 4 deletions(-)

diff --git a/drivers/net/enetfec/enet_ethdev.c b/drivers/net/enetfec/enet_ethdev.c
index 91c0f60490..0d27b63953 100644
--- a/drivers/net/enetfec/enet_ethdev.c
+++ b/drivers/net/enetfec/enet_ethdev.c
@@ -415,7 +415,6 @@ enetfec_tx_queue_setup(struct rte_eth_dev *dev,
 			offset_des_active_txq[queue_idx];
 	bd_base = (struct bufdesc *)(((uintptr_t)bd_base) + size);
 	txq->bd.last = (struct bufdesc *)(((uintptr_t)bd_base) - dsize);
-	bdp = txq->bd.base;
 	bdp = txq->bd.cur;
 
 	for (i = 0; i < txq->bd.ring_size; i++) {
diff --git a/drivers/net/octeon_ep/otx_ep_mbox.c b/drivers/net/octeon_ep/otx_ep_mbox.c
index 64a51c1fd0..1d7e08d2cc 100644
--- a/drivers/net/octeon_ep/otx_ep_mbox.c
+++ b/drivers/net/octeon_ep/otx_ep_mbox.c
@@ -256,9 +256,6 @@ int otx_ep_mbox_get_link_info(struct rte_eth_dev *eth_dev,
 	}
 	link->link_status = RTE_ETH_LINK_UP;
 	link->link_duplex = RTE_ETH_LINK_FULL_DUPLEX;
-	link->link_autoneg = (link_info.autoneg ==
-			      OTX_EP_LINK_AUTONEG) ? RTE_ETH_LINK_AUTONEG : RTE_ETH_LINK_FIXED;
-
 	link->link_autoneg = link_info.autoneg;
 	link->link_speed = link_info.speed;
 	return 0;
-- 
2.47.1

Re: [PATCH 1/1] net/{octeon_ep,enetfec}: remove unused value

[Stephen Hemminger]

On Wed, 18 Dec 2024 21:00:09 +0100
Ariel Otilibili <otilibil@eurecom.fr> wrote:

> Coverity issue: 385414, 374016
> Fixes: c836a7ba33e ("net/octeon_ep: support mailbox between VF and PF")
> Fixes: bb5b5bf1e5c ("net/enetfec: support queue configuration")
> Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
> --
> Cc: stable@dpdk.org
> Cc: Vamsi Attunuru <vattunuru@marvell.com>
> Cc: Apeksha Gupta <apeksha.gupta@nxp.com>
> Cc: Sachin Saxena <sachin.saxena@nxp.com>
> ---
>  drivers/net/enetfec/enet_ethdev.c   | 1 -
>  drivers/net/octeon_ep/otx_ep_mbox.c | 3 ---
>  2 files changed, 4 deletions(-)

The standard has changed (in upstream Linux checkpatch) to require longer commit id.

### [PATCH] net/{octeon_ep,enetfec}: remove unused value

WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12+ chars of sha1> ("<title line>")' - ie: 'Fixes: c836a7ba33ee ("net/octeon_ep: support mailbox between VF and PF")'
#7: 
Fixes: c836a7ba33e ("net/octeon_ep: support mailbox between VF and PF")

WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12+ chars of sha1> ("<title line>")' - ie: 'Fixes: bb5b5bf1e5c6 ("net/enetfec: support queue configuration")'
#8: 
Fixes: bb5b5bf1e5c ("net/enetfec: support queue configuration")


Fixed that and applied to next-net

Re: [PATCH 1/1] net/{octeon_ep,enetfec}: remove unused value

[Ariel Otilibili-Anieli]

Hello Stephen,

On Thursday, January 30, 2025 19:39 CET, Stephen Hemminger <stephen@networkplumber.org> wrote:

> Fixed that and applied to next-net
Thanks for having wrapped up the series; much appreciated. I now have the proper length in my git config.

Have a good one,
Ariel