From: Stephen Hemminger <stephen@networkplumber.org>
To: Joshua Washington <joshwash@google.com>
Cc: Jeroen de Borst <jeroendb@google.com>,
Rushil Gupta <rushilg@google.com>,
Junfeng Guo <junfeng.guo@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
dev@dpdk.org, stable@dpdk.org,
Praveen Kaligineedi <pkaligineedi@google.com>
Subject: Re: [PATCH v4] net/gve: allocate RX QPL pages using malloc
Date: Thu, 30 Jan 2025 10:42:18 -0800 [thread overview]
Message-ID: <20250130104218.53836e8c@hermes.local> (raw)
In-Reply-To: <20250109194638.3262043-1-joshwash@google.com>
On Thu, 9 Jan 2025 11:46:38 -0800
Joshua Washington <joshwash@google.com> wrote:
> Kaligineedi <pkaligineedi@google.com>
>
> Allocating QPL for an RX queue might fail if enough contiguous IOVA
> memory cannot be allocated. This can commonly occur when using 2MB huge
> pages because the 1024 4K buffers are allocated for each RX ring by
> default, resulting in 4MB for each ring. However, the only requirement
> for RX QPLs is that each 4K buffer be IOVA contiguous, not the entire
> QPL. Therefore, malloc will be used to allocate RX QPLs instead.
>
> Note that TX queues require the entire QPL to be IOVA contiguous, so it
> will continue to use the memzone-based allocation.
>
> v2: Updated RX path to use malloc exclusively
>
> v3: Changed commit description to match updated code
>
> v4: Add fixes tag to allow 2M hugepages to be used on older versions of
> DPDK
>
> Fixes: a46583cf43c8 ("net/gve: support Rx/Tx")
> Cc: junfeng.guo@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Praveen Kaligineedi <pkaligineedi@google.com>
> Signed-off-by: Joshua Washington <joshwash@google.com>
> ---
The standard practice is to put revision information below the cut line "---"
so it doesn't end up in the commit message.
I fixed that and applied it to next-net
prev parent reply other threads:[~2025-01-30 18:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 23:46 [PATCH] net/gve: Allocate qpl pages using malloc if memzone allocation fails Joshua Washington
2024-12-19 3:51 ` Stephen Hemminger
2024-12-19 20:53 ` Praveen Kaligineedi
2024-12-19 22:34 ` Stephen Hemminger
2024-12-20 0:04 ` Stephen Hemminger
2024-12-23 20:16 ` [PATCH v2] " Joshua Washington
2025-01-07 19:02 ` [PATCH v3] net/gve: allocate RX QPL pages using malloc Joshua Washington
2025-01-09 19:46 ` [PATCH v4] " Joshua Washington
2025-01-09 20:05 ` Joshua Washington
2025-01-09 22:14 ` Stephen Hemminger
2025-01-30 18:42 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130104218.53836e8c@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=junfeng.guo@intel.com \
--cc=pkaligineedi@google.com \
--cc=rushilg@google.com \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).