From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E01945F6A; Thu, 30 Jan 2025 19:42:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EC0A40E17; Thu, 30 Jan 2025 19:42:22 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 81E7940275 for ; Thu, 30 Jan 2025 19:42:21 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2ee397a82f6so1978585a91.2 for ; Thu, 30 Jan 2025 10:42:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1738262540; x=1738867340; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=yjUe5cDj+h2AgUFThOFecj8uiqhH3HlfA6ju32jpFDo=; b=j79i/54nSZw6G49DDG36iQxmnFNR3ulRSp65AsvnnHw0BJDPZksjpEvjXw7kgCJXyg VVLAlHTAGTchWwxz/+FJ/VSLxhNdAtxyZL217sxzIIPH3wjLWBTo6XEbetDKrSgAbOyv 4v7eeB/sHGttflyE9zfbtVxdfyIME9xB/D+6aMIsWg7jdZfjhpODwbNOcptfrsJLmXlS oA5ymNP92YZD3krs73vA7xBpHUNFxYr2hATxrg3Pu6mJTMbZ/izmEF3Vf0G/0uVi6/+C muE/i/DUkeCzCtol1cQTbvzCeeELQKszwM5WwjBQBhZP8viN1mcub9gw9+zKmzcrxNLl f9vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738262540; x=1738867340; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yjUe5cDj+h2AgUFThOFecj8uiqhH3HlfA6ju32jpFDo=; b=Gv6WFO39CrsimPQl75I5inXVLJlYI4HrNCdrB1ci4Ch8UyvEimlJQP4udGT832MNUw PFGLLt2uHAenpLweeyIyveDWZ4KUPDuSbpDraEZhskWyPgrh/7HRTUh3U6NYcld4tdQY yg5fCttBuf1bTFIDH8h6WXlyo1Nu+BRU0qomCwruChcrvZiP/gvY1r1LWMmB1Hz4AA1T nkmVqFuVtFYrPiMKUDZw0M/kLo9tiiSBqsOucP6qXizzw2P5u4R6Q0NMwAZgnglaHXE7 f/Tfrijz8+TrySyVugaKACndy/cCubOTMmHOStn+PNnS46VENd+MPoBmgoXn/Adk1l4g atjg== X-Forwarded-Encrypted: i=1; AJvYcCWOGK/o9EA8LppwrM+ESAoMLo/mT7EYjACWCAwLnkRPCVV1eigR89cy5oGXiK8dm8JqojY=@dpdk.org X-Gm-Message-State: AOJu0YzdvOFE8FQQaOsNPF4byGp/NeMsT9uEJ00pFeUjEqS/Kqqxvih/ H+YhejGhsJVS5PlRnnD/dPa1CDQ8t/UgBHNWk2hdTUc3QXP5tOQONXanVxFSj4I= X-Gm-Gg: ASbGncvew1mQ4o7niKkXsR9qcpp3QP2xTU9l6QK8u8lQm8My4/M7VfRnmCCVGsXtCBy Q0N6qqtjRshbPsLNOKK0VJHBWwrZ7lcTVuYFD6GpCKkiPNwlL1bSkKiwPSJcYrgkHITNjaJF1My JwOYULMnFXQUej90qvKwGHwZuBPr6cSXz8cITDRxxpF/lDHSnj7VbsXSjuCGiewgXaEylmjln5n UE6+2qkL/jIFWnPs2ji5thFhTxnVaVfVp9LinmrpAmJ0HAxEBz26FUrtfnQYR25PwG9qNJwHtCb gXHMdZ3dUH+648dGlhNJAk3383OsylkI/p/SfgpfFHNLSQr+WjJxoBh7ApaiFh6wNt6I X-Google-Smtp-Source: AGHT+IGzbJRxiEUMd8tpwW0+3oB2LZ+AbCQTq7YOi3TEYi+XqcTCcvvD/fc8sbY1KIqRN5GNJb8ZxQ== X-Received: by 2002:a17:90b:5485:b0:2ea:b564:4b31 with SMTP id 98e67ed59e1d1-2f83abff361mr11888865a91.19.1738262540667; Thu, 30 Jan 2025 10:42:20 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f83bc97da0sm4304500a91.3.2025.01.30.10.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2025 10:42:20 -0800 (PST) Date: Thu, 30 Jan 2025 10:42:18 -0800 From: Stephen Hemminger To: Joshua Washington Cc: Jeroen de Borst , Rushil Gupta , Junfeng Guo , Xiaoyun Li , dev@dpdk.org, stable@dpdk.org, Praveen Kaligineedi Subject: Re: [PATCH v4] net/gve: allocate RX QPL pages using malloc Message-ID: <20250130104218.53836e8c@hermes.local> In-Reply-To: <20250109194638.3262043-1-joshwash@google.com> References: <20250107190258.2107909-1-joshwash@google.com> <20250109194638.3262043-1-joshwash@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 9 Jan 2025 11:46:38 -0800 Joshua Washington wrote: > Kaligineedi > > Allocating QPL for an RX queue might fail if enough contiguous IOVA > memory cannot be allocated. This can commonly occur when using 2MB huge > pages because the 1024 4K buffers are allocated for each RX ring by > default, resulting in 4MB for each ring. However, the only requirement > for RX QPLs is that each 4K buffer be IOVA contiguous, not the entire > QPL. Therefore, malloc will be used to allocate RX QPLs instead. > > Note that TX queues require the entire QPL to be IOVA contiguous, so it > will continue to use the memzone-based allocation. > > v2: Updated RX path to use malloc exclusively > > v3: Changed commit description to match updated code > > v4: Add fixes tag to allow 2M hugepages to be used on older versions of > DPDK > > Fixes: a46583cf43c8 ("net/gve: support Rx/Tx") > Cc: junfeng.guo@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Praveen Kaligineedi > Signed-off-by: Joshua Washington > --- The standard practice is to put revision information below the cut line "---" so it doesn't end up in the commit message. I fixed that and applied it to next-net