From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65AE34614B; Thu, 30 Jan 2025 15:38:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E6E34067C; Thu, 30 Jan 2025 15:38:49 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id AED5C402E7 for ; Thu, 30 Jan 2025 15:38:47 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id D8D632109CF8; Thu, 30 Jan 2025 06:38:46 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D8D632109CF8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1738247926; bh=DKezNuv1pjHZIpUIfdhjAySbWyHBJeFSnHnQXcAx0z0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qzCBKrJYhuSbmnQeXlKuSTPPUbgAszTzgRFinEXrnC3bxfcW7kMlM4QUtJsw9uDdz kqbQZV21lzObztbn64UxchqSHBjr4tymVrKOxbhYe9AE8WMedozQpxFNK4ZHB8oxNM 8FyRLK3qgTrDhi8rtLJ8krWA599Q/ujSxFcsZ5cY= Date: Thu, 30 Jan 2025 06:38:46 -0800 From: Andre Muezerie To: David Marchand Cc: Bruce Richardson , dev@dpdk.org, konstantin.ananyev@huawei.com, thomas@monjalon.net Subject: Re: [PATCH v16 00/60] remove use of VLAs for Windows Message-ID: <20250130143846.GA27814@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1736821958-3295-1-git-send-email-andremue@linux.microsoft.com> <20250123163759.GA29129@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 29, 2025 at 04:57:16PM +0100, David Marchand wrote: > On Thu, Jan 23, 2025 at 5:38 PM Andre Muezerie > wrote: > > > > I see there is some back and forth on the topic of passing -Wvla. > > > > It would be less fragile to put a -Wla in a upper level meson.build > > > > (like config/meson.build for example), then disable explicitly in the > > > > parts that are not ready. > > > > > > > > Something like: > > > > diff --git a/config/meson.build b/config/meson.build > > > > index 6aaad6d8a4..be603bd45b 100644 > > > > --- a/config/meson.build > > > > +++ b/config/meson.build > > > > @@ -348,6 +348,17 @@ foreach arg: warning_flags > > > > endif > > > > endforeach > > > > > > > > +if cc.has_argument('-Wvla') > > > > + add_project_arguments('-Wvla', language: 'c') > > > > + if not is_windows > > > > + no_vla_cflag = '-Wno-vla' > > > > + else > > > > + no_vla_cflag = [] > > > > + endif > > > > +else > > > > + no_vla_cflag = [] > > > > +endif > > > > + > > > > > > Minor simplification suggestion, put "no_vla_cflag = []" outside the > > > conditionals at the start, as the default value. Save having multiple > > > copies of that assignment, and having to do "else" legs. > > > > These look like great improvements. I especially like the idea of using -Wvla from the very top. > > Ok, can you work on a new revision and send it for the CI to have a try? > Thanks. > > > -- > David Marchand Yes. I sent out v17 which incorporates the suggestions made. -- Andre Muezerie