DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andre Muezerie <andremue@linux.microsoft.com>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, bruce.richardson@intel.com
Subject: Re: [PATCH] net/ice: fix segmentation fault Rx function
Date: Fri, 31 Jan 2025 07:28:52 -0800	[thread overview]
Message-ID: <20250131152852.GB6944@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20250130192617.2744705-1-vladimir.medvedkin@intel.com>

On Thu, Jan 30, 2025 at 07:26:17PM +0000, Vladimir Medvedkin wrote:
> Fix a typo in avx512 rx function, where accidentally the _mm_load_si128
> argument was passed by value instead of a pointer.
> 
> Fixes: 43fd3624fdfe ("drivers: replace GCC pragma with cast")
> Cc: andremue@linux.microsoft.com
> 
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
>  drivers/net/intel/ice/ice_rxtx_vec_avx512.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/intel/ice/ice_rxtx_vec_avx512.c b/drivers/net/intel/ice/ice_rxtx_vec_avx512.c
> index 681b31f61f..bd49be07c9 100644
> --- a/drivers/net/intel/ice/ice_rxtx_vec_avx512.c
> +++ b/drivers/net/intel/ice/ice_rxtx_vec_avx512.c
> @@ -474,7 +474,7 @@ _ice_recv_raw_pkts_vec_avx512(struct ice_rx_queue *rxq,
>  					(RTE_CAST_PTR(const __m128i *, &rxdp[7].wb.status_error1));
>  				rte_compiler_barrier();
>  				const __m128i raw_desc_bh6 = _mm_load_si128
> -					(RTE_CAST_PTR(const __m128i *, rxdp[6].wb.status_error1));
> +					(RTE_CAST_PTR(const __m128i *, &rxdp[6].wb.status_error1));
>  				rte_compiler_barrier();
>  				const __m128i raw_desc_bh5 = _mm_load_si128
>  					(RTE_CAST_PTR(const __m128i *, &rxdp[5].wb.status_error1));
> -- 
> 2.43.0

Thanks for catching and fixing this.

      parent reply	other threads:[~2025-01-31 15:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30 19:26 Vladimir Medvedkin
2025-01-31 10:43 ` David Marchand
2025-01-31 11:21   ` Bruce Richardson
2025-01-31 15:28 ` Andre Muezerie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250131152852.GB6944@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=andremue@linux.microsoft.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).