From: Stephen Hemminger <stephen@networkplumber.org>
To: Chengwen Feng <fengchengwen@huawei.com>
Cc: <thomas@monjalon.net>, <aman.deep.singh@intel.com>, <dev@dpdk.org>
Subject: Re: [PATCH v2 1/4] app/testpmd: remove restrict of number of TCs in DCB command
Date: Mon, 21 Apr 2025 07:53:10 -0700 [thread overview]
Message-ID: <20250421075259.12683c28@hermes.local> (raw)
In-Reply-To: <20250421072229.33200-2-fengchengwen@huawei.com>
On Mon, 21 Apr 2025 15:22:26 +0800
Chengwen Feng <fengchengwen@huawei.com> wrote:
> Currently, the "port config 0 dcb ..." command only supports 4 or 8
> TCs. Other number of TCs may be used in actual applications.
>
> This commit removes this restriction.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
> app/test-pmd/cmdline.c | 4 ++--
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index b4089d281b..e34e47aaae 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3472,9 +3472,9 @@ cmd_config_dcb_parsed(void *parsed_result,
> return;
> }
>
> - if ((res->num_tcs != RTE_ETH_4_TCS) && (res->num_tcs != RTE_ETH_8_TCS)) {
> + if ((res->num_tcs <= 1 || res->num_tcs > RTE_ETH_8_TCS)) {
> fprintf(stderr,
No longer need nested paren's here.
i.e
if (res->num_tcs <= 1 || res->num_tcs > RTE_ETH_8_TCS) {
next prev parent reply other threads:[~2025-04-21 15:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 9:19 [PATCH 0/4] enhance testpmd " Chengwen Feng
2025-02-25 9:19 ` [PATCH 1/4] app/testpmd: remove restrict of number of TCs in " Chengwen Feng
2025-02-25 9:19 ` [PATCH 2/4] app/testpmd: support config prio-tc map " Chengwen Feng
2025-02-25 9:19 ` [PATCH 3/4] app/testpmd: support don't adjust queue num " Chengwen Feng
2025-02-25 9:19 ` [PATCH 4/4] app/testpmd: support disable " Chengwen Feng
2025-02-25 14:42 ` [PATCH 0/4] enhance testpmd " Stephen Hemminger
2025-03-27 15:53 ` Stephen Hemminger
2025-04-21 7:22 ` [PATCH v2 " Chengwen Feng
2025-04-21 7:22 ` [PATCH v2 1/4] app/testpmd: remove restrict of number of TCs in " Chengwen Feng
2025-04-21 14:53 ` Stephen Hemminger [this message]
2025-04-21 7:22 ` [PATCH v2 2/4] app/testpmd: support config prio-tc map " Chengwen Feng
2025-04-21 7:22 ` [PATCH v2 3/4] app/testpmd: support don't adjust queue num " Chengwen Feng
2025-04-21 7:22 ` [PATCH v2 4/4] app/testpmd: support disable " Chengwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421075259.12683c28@hermes.local \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).