From: Stephen Hemminger <stephen@networkplumber.org>
To: edwin.brossette@6wind.com
Cc: dev@dpdk.org, olivier.matz@6wind.com, didier.pallard@6wind.com,
lauren.hardy@6wind.com, dsinghrawat@marvell.com,
palok@marvell.com, stable@dpdk.org
Subject: Re: [PATCH 2/5] net/qede: fix bad sanity check on Rx queue release
Date: Wed, 23 Apr 2025 08:30:52 -0700 [thread overview]
Message-ID: <20250423083052.63bed101@hermes.local> (raw)
In-Reply-To: <20250422155143.3893525-2-edwin.brossette@6wind.com>
On Tue, 22 Apr 2025 17:51:40 +0200
edwin.brossette@6wind.com wrote:
> From: Edwin Brossette <edwin.brossette@6wind.com>
>
> As per the rte_mbuf API: the driver is responsible of initializing all
> the required fields. This is not done at qede alloc, meaning there can
> be garbage data in mbufs memory, although this garbage data should be
> overwritten when the mbufs are used. Since a sanity check is done when
> freeing the queues, its possible some remaining garbage data causes a
> panic when trying to release the queues if some mbufs are being
> processed.
>
> Use rte_pktmbuf_raw_free() instead of rte_pktmbuf_free() as the sanity
> check is more relaxed.
>
> Fixes: 2ea6f76aff40 ("qede: add core driver")
> CC: stable@dpdk.org
Patch looks fine, but DPDK is trying to follow the inclusive naming
guidelines. The term "sanity check" is on the not allowed list.
I will reword the commit message.
https://inclusivenaming.org/word-lists/tier-2/sanity-check/
next prev parent reply other threads:[~2025-04-23 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 15:39 QEDE bug report Edwin Brossette
2025-04-22 15:51 ` [PATCH 1/5] qede: fix tunnel checksums offload flags edwin.brossette
2025-04-22 15:51 ` [PATCH 2/5] net/qede: fix bad sanity check on Rx queue release edwin.brossette
2025-04-23 15:30 ` Stephen Hemminger [this message]
2025-04-22 15:51 ` [PATCH 3/5] Revert "net/qede: fix maximum Rx packet length" edwin.brossette
2025-04-22 15:51 ` [PATCH 4/5] net/qede: fix QEDE_ETH_OVERHEAD being counted twice in rx_buf_size edwin.brossette
2025-04-22 15:51 ` [PATCH 5/5] net/qede: fix rx_buf_size calculation edwin.brossette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423083052.63bed101@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=didier.pallard@6wind.com \
--cc=dsinghrawat@marvell.com \
--cc=edwin.brossette@6wind.com \
--cc=lauren.hardy@6wind.com \
--cc=olivier.matz@6wind.com \
--cc=palok@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).