Re: [PATCH v2 1/2] ethdev: support RSS based on RoCEv2 header

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue, 29 Apr 2025 15:22:41 +0530
<kirankumark@marvell.com> wrote:

> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index e89af21cec..444e4b0388 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -89,67 +89,69 @@ static const struct {
>  
>  const struct rss_type_info rss_type_table[] = {
>  	/* Group types */
> -	{ "all", RTE_ETH_RSS_ETH | RTE_ETH_RSS_VLAN | RTE_ETH_RSS_IP | RTE_ETH_RSS_TCP |
> -		RTE_ETH_RSS_UDP | RTE_ETH_RSS_SCTP | RTE_ETH_RSS_L2_PAYLOAD |
> -		RTE_ETH_RSS_L2TPV3 | RTE_ETH_RSS_ESP | RTE_ETH_RSS_AH | RTE_ETH_RSS_PFCP |
> -		RTE_ETH_RSS_GTPU | RTE_ETH_RSS_ECPRI | RTE_ETH_RSS_MPLS | RTE_ETH_RSS_L2TPV2},
> -	{ "none", 0 },
> -	{ "ip", RTE_ETH_RSS_IP },
> -	{ "udp", RTE_ETH_RSS_UDP },
> -	{ "tcp", RTE_ETH_RSS_TCP },
> -	{ "sctp", RTE_ETH_RSS_SCTP },
> -	{ "tunnel", RTE_ETH_RSS_TUNNEL },
> -	{ "vlan", RTE_ETH_RSS_VLAN },
> +	{"all", RTE_ETH_RSS_ETH | RTE_ETH_RSS_VLAN | RTE_ETH_RSS_IP | RTE_ETH_RSS_TCP |
> +			RTE_ETH_RSS_UDP | RTE_ETH_RSS_SCTP | RTE_ETH_RSS_L2_PAYLOAD |
> +			RTE_ETH_RSS_L2TPV3 | RTE_ETH_RSS_ESP | RTE_ETH_RSS_AH | RTE_ETH_RSS_PFCP |
> +			RTE_ETH_RSS_GTPU | RTE_ETH_RSS_ECPRI | RTE_ETH_RSS_MPLS |
> +			RTE_ETH_RSS_L2TPV2 | RTE_ETH_RSS_IB_BTH},
> +	{"none", 0},
> +	{"ip", RTE_ETH_RSS_IP},
> +	{"udp", RTE_ETH_RSS_UDP},
> +	{"tcp", RTE_ETH_RSS_TCP},
> +	{"sctp", RTE_ETH_RSS_SCTP},
> +	{"tunnel", RTE_ETH_RSS_TUNNEL},
> +	{"vlan", RTE_ETH_RSS_VLAN},

Why so many changes here. the format was better before with space after the {.

> diff --git a/doc/guides/rel_notes/release_25_07.rst b/doc/guides/rel_notes/release_25_07.rst
> index 093b85d206..1b8ba5ab90 100644
> --- a/doc/guides/rel_notes/release_25_07.rst
> +++ b/doc/guides/rel_notes/release_25_07.rst
> @@ -24,36 +24,10 @@ DPDK Release 25.07
>  New Features
>  ------------
>  
> -.. This section should contain new features added in this release.
> -   Sample format:
> +* **Added new RSS offload types for IB_BTH in RSS flow.**
>  
> -   * **Add a title in the past tense with a full stop.**
> -
> -     Add a short 1-2 sentence description in the past tense.
> -     The description should be enough to allow someone scanning
> -     the release notes to understand the new feature.
> -
> -     If the feature adds a lot of sub-features you can use a bullet list
> -     like this:
> -
> -     * Added feature foo to do something.
> -     * Enhanced feature bar to do something else.
> -
> -     Refer to the previous release notes for examples.
> -
> -     Suggested order in release notes items:
> -     * Core libs (EAL, mempool, ring, mbuf, buses)
> -     * Device abstraction libs and PMDs (ordered alphabetically by vendor name)
> -       - ethdev (lib, PMDs)
> -       - cryptodev (lib, PMDs)
> -       - eventdev (lib, PMDs)
> -       - etc
> -     * Other libs
> -     * Apps, Examples, Tools (if significant)
> -
> -     This section is a comment. Do not overwrite or remove it.
> -     Also, make sure to start the actual text at the margin.
> -     =======================================================
> +  Added ``RTE_ETH_RSS_IB_BTH`` macro so that the IB BTH header can be used as
> +  input set for RSS.


The current practice in DPDK is to leave the release note template stuff in place
until the final steps of the release process.

Also could be one line description.

> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> index ea7f8c4a1a..3f5317c489 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -602,6 +602,7 @@ struct rte_eth_rss_conf {
>  
>  #define RTE_ETH_RSS_L2TPV2             RTE_BIT64(36)
>  #define RTE_ETH_RSS_IPV6_FLOW_LABEL    RTE_BIT64(37)
> +#define RTE_ETH_RSS_IB_BTH RTE_BIT64(38)

Since other related RSS options are indented with spaces, this should be as well.

The golden rules of patches: change as little as possible, and make the new
code look code look the same as the original.