From: Stephen Hemminger <stephen@networkplumber.org>
To: <skori@marvell.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, <dev@dpdk.org>
Subject: Re: [PATCH] ethdev: remove callback checks from fast path
Date: Tue, 29 Apr 2025 16:55:11 -0700 [thread overview]
Message-ID: <20250429165511.26414666@hermes.local> (raw)
In-Reply-To: <20250429181132.2544771-1-skori@marvell.com>
On Tue, 29 Apr 2025 23:41:30 +0530
<skori@marvell.com> wrote:
> @@ -7131,14 +7118,11 @@ rte_eth_tx_queue_count(uint16_t port_id, uint16_t queue_id)
> goto out;
> }
> #endif
> - if (fops->tx_queue_count == NULL) {
> - rc = -ENOTSUP;
> - goto out;
> - }
> -
> rc = fops->tx_queue_count(qd);
>
> +#ifdef RTE_ETHDEV_DEBUG_TX
> out:
> +#endif
I think you could just fix the ETHDEV_DEBUG_TX to just return.
Other ethdev functions skip calling tracing for
the case of errors.
next prev parent reply other threads:[~2025-04-29 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 18:11 skori
2025-04-29 23:55 ` Stephen Hemminger [this message]
2025-04-29 23:59 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429165511.26414666@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).