From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D71D46662; Wed, 30 Apr 2025 03:34:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EADEC402A7; Wed, 30 Apr 2025 03:34:34 +0200 (CEST) Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by mails.dpdk.org (Postfix) with ESMTP id 19D4F402A3 for ; Wed, 30 Apr 2025 03:34:33 +0200 (CEST) Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53U0fK9L010486 for ; Tue, 29 Apr 2025 18:34:33 -0700 Received: from ala-exchng02.corp.ad.wrs.com (ala-exchng02.wrs.com [147.11.82.254]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 46b6ugr6np-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 29 Apr 2025 18:34:33 -0700 (PDT) Received: from ALA-EXCHNG02.corp.ad.wrs.com (147.11.82.254) by ALA-EXCHNG02.corp.ad.wrs.com (147.11.82.254) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.43; Tue, 29 Apr 2025 18:34:32 -0700 Received: from pek-lpg-core6.wrs.com (147.11.136.210) by ALA-EXCHNG02.corp.ad.wrs.com (147.11.82.254) with Microsoft SMTP Server id 15.1.2507.43 via Frontend Transport; Tue, 29 Apr 2025 18:34:31 -0700 From: To: Subject: [PATCH V3] Add new tracepoint function for type time_t Date: Wed, 30 Apr 2025 09:34:30 +0800 Message-ID: <20250430013431.2056969-1-changqing.li@windriver.com> X-Mailer: git-send-email 2.44.1 In-Reply-To: <20250429030437.1128853-1-changqing.li@windriver.com> References: <20250429030437.1128853-1-changqing.li@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: u6tQSgHeHUb1HWW_3ENqfVL5PnQ42B0i X-Proofpoint-ORIG-GUID: u6tQSgHeHUb1HWW_3ENqfVL5PnQ42B0i X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDMwMDAwOSBTYWx0ZWRfX7MjXOoytC0c5 hNrJn4HGUBQM2V5BZpWRH3mfIlRI2P3Vm9GOonCfMT1Ipd5gxSYxQhmHqUsrrC/Va0isyjD5Nam gB+DCT6s0zM2PnISHq993vp2BrPRdsiPz5mB/E91KNEmvS2zjYOZDAlo36lZGDWHQdoWAxnX0Tn P+i+MCL+MFAa7kq4P12cT5Gbio7bnKjo+5IYMzx4AGgpl+HAERweNQMxrb9PTETU5BijlRVY4jQ bBr4vnM97sl4nCq/uMl13fVuSf1068D9F+ceSgGmpitaeibtCwjP8ROw7zRbQBu2oZNV7ReLyYd ++i+kTJMZ7/XJYJx3q1TLDYUFYaM36pzAQo9pZsPFFm+qqirV2cblIK9xkEjKUXsAw8y71HtYc3 Kk0+jtStvDSCCm9u0wM6a15EBLSEO5FkJju0G7VB3ZEHdP64zgIrN46ZV5xsTn7PZfFa/SZA X-Authority-Analysis: v=2.4 cv=Od+YDgTY c=1 sm=1 tr=0 ts=68117e29 cx=c_pps a=K4BcnWQioVPsTJd46EJO2w==:117 a=K4BcnWQioVPsTJd46EJO2w==:17 a=XR8D0OoHHMoA:10 a=t7CeM3EgAAAA:8 a=q8yi_ZPvUVNFa_hMH0IA:9 a=FdTzh2GWekK77mhwV6Dw:22 X-Sensitive_Customer_Information: Yes X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-29_08,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 mlxlogscore=880 mlxscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 clxscore=1015 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.21.0-2504070000 definitions=main-2504300009 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Changqing Li To support Y2038 issue, for 32bit system, -D_TIME_BITS=64 is passed to gcc, struct timespec time->tv_sec is 64bit, but size_t is 32bits, so dpdk will compile failed with error: "../git/lib/ethdev/ethdev_trace.h: In function 'rte_eth_trace_timesync_write_time': ../git/lib/eal/include/rte_common.h:498:55: error: size of unnamed array is negative 498 | #define RTE_BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2*!!(condition)]))" Add a new tracepoint function for type time_t to fix this issue Signed-off-by: Changqing Li --- lib/eal/include/rte_trace_point.h | 5 +++++ lib/ethdev/ethdev_trace.h | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/eal/include/rte_trace_point.h b/lib/eal/include/rte_trace_point.h index 8a317d31d2..d6bacf1752 100644 --- a/lib/eal/include/rte_trace_point.h +++ b/lib/eal/include/rte_trace_point.h @@ -18,6 +18,7 @@ #include #include +#include #include #include @@ -150,6 +151,8 @@ _tp _args \ #define rte_trace_point_emit_ptr(val) /** Tracepoint function payload for string datatype */ #define rte_trace_point_emit_string(val) +/** Tracepoint function payload for time_t datatype */ +#define rte_trace_point_emit_time_t(val) /** * Tracepoint function to capture a blob. * @@ -438,6 +441,7 @@ do { \ #define rte_trace_point_emit_float(in) __rte_trace_point_emit(RTE_STR(in), &in, float) #define rte_trace_point_emit_double(in) __rte_trace_point_emit(RTE_STR(in), &in, double) #define rte_trace_point_emit_ptr(in) __rte_trace_point_emit(RTE_STR(in), &in, uintptr_t) +#define rte_trace_point_emit_time_t(in) __rte_trace_point_emit(RTE_STR(in), &in, time_t) #define rte_trace_point_emit_u64_ptr(in) __rte_trace_point_emit(RTE_STR(in)"_val", in, uint64_t) #define rte_trace_point_emit_i64_ptr(in) __rte_trace_point_emit(RTE_STR(in)"_val", in, int64_t) @@ -452,6 +456,7 @@ do { \ #define rte_trace_point_emit_size_t_ptr(in) __rte_trace_point_emit(RTE_STR(in)"_val", in, size_t) #define rte_trace_point_emit_float_ptr(in) __rte_trace_point_emit(RTE_STR(in)"_val", in, float) #define rte_trace_point_emit_double_ptr(in) __rte_trace_point_emit(RTE_STR(in)"_val", in, double) +#define rte_trace_point_emit_time_t_ptr(in) __rte_trace_point_emit(RTE_STR(in)"_val", in, time_t) #endif /* __DOXYGEN__ */ diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h index c65b78590a..482befc209 100644 --- a/lib/ethdev/ethdev_trace.h +++ b/lib/ethdev/ethdev_trace.h @@ -1121,7 +1121,7 @@ RTE_TRACE_POINT( RTE_TRACE_POINT_ARGS(uint16_t port_id, const struct timespec *time, int ret), rte_trace_point_emit_u16(port_id); - rte_trace_point_emit_size_t(time->tv_sec); + rte_trace_point_emit_time_t(time->tv_sec); rte_trace_point_emit_long(time->tv_nsec); rte_trace_point_emit_int(ret); ) @@ -2151,7 +2151,7 @@ RTE_TRACE_POINT_FP( RTE_TRACE_POINT_ARGS(uint16_t port_id, const struct timespec *timestamp, uint32_t flags, int ret), rte_trace_point_emit_u16(port_id); - rte_trace_point_emit_size_t(timestamp->tv_sec); + rte_trace_point_emit_time_t(timestamp->tv_sec); rte_trace_point_emit_long(timestamp->tv_nsec); rte_trace_point_emit_u32(flags); rte_trace_point_emit_int(ret); @@ -2163,7 +2163,7 @@ RTE_TRACE_POINT_FP( RTE_TRACE_POINT_ARGS(uint16_t port_id, const struct timespec *timestamp, int ret), rte_trace_point_emit_u16(port_id); - rte_trace_point_emit_size_t(timestamp->tv_sec); + rte_trace_point_emit_time_t(timestamp->tv_sec); rte_trace_point_emit_long(timestamp->tv_nsec); rte_trace_point_emit_int(ret); ) @@ -2174,7 +2174,7 @@ RTE_TRACE_POINT_FP( RTE_TRACE_POINT_ARGS(uint16_t port_id, const struct timespec *time, int ret), rte_trace_point_emit_u16(port_id); - rte_trace_point_emit_size_t(time->tv_sec); + rte_trace_point_emit_time_t(time->tv_sec); rte_trace_point_emit_long(time->tv_nsec); rte_trace_point_emit_int(ret); ) -- 2.44.1