From: Nicolas Chautru <nicolas.chautru@intel.com>
To: dev@dpdk.org, maxime.coquelin@redhat.com
Cc: hemant.agrawal@nxp.com, hernan.vargas@intel.com,
Nicolas Chautru <nicolas.chautru@intel.com>
Subject: [PATCH v1 1/1] bbdev: fix possible null pointer dereference
Date: Thu, 1 May 2025 15:10:31 -0700 [thread overview]
Message-ID: <20250501221031.4569-2-nicolas.chautru@intel.com> (raw)
In-Reply-To: <20250501221031.4569-1-nicolas.chautru@intel.com>
This change addresses the CID 457446: Null pointer dereferences
(REVERSE_INULL). Not expected to happen in practice, but the
config may be potentially undefined through API.
Coverity issue: 457446
Fixes: 61aa25b96e14 ("bbdev: add trace points")
Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
lib/bbdev/rte_bbdev.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c
index f341e6f3b9..56f313ee64 100644
--- a/lib/bbdev/rte_bbdev.c
+++ b/lib/bbdev/rte_bbdev.c
@@ -440,10 +440,6 @@ int
rte_bbdev_queue_configure(uint16_t dev_id, uint16_t queue_id,
const struct rte_bbdev_queue_conf *conf)
{
-
- rte_bbdev_trace_queue_configure(dev_id, queue_id, rte_bbdev_op_type_str(conf->op_type),
- conf->priority);
-
int ret = 0;
struct rte_bbdev_driver_info dev_info;
struct rte_bbdev *dev = get_dev(dev_id);
@@ -451,6 +447,11 @@ rte_bbdev_queue_configure(uint16_t dev_id, uint16_t queue_id,
struct rte_bbdev_queue_conf *stored_conf;
const char *op_type_str;
unsigned int max_priority;
+
+ rte_bbdev_trace_queue_configure(dev_id, queue_id,
+ conf != NULL ? rte_bbdev_op_type_str(conf->op_type) : NULL,
+ conf != NULL ? conf->priority : 0);
+
VALID_DEV_OR_RET_ERR(dev, dev_id);
VALID_DEV_OPS_OR_RET_ERR(dev, dev_id);
--
2.34.1
prev parent reply other threads:[~2025-05-01 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 22:10 [PATCH v1 0/1] bbdev: fix possible null pointer dereferencing Nicolas Chautru
2025-05-01 22:10 ` Nicolas Chautru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250501221031.4569-2-nicolas.chautru@intel.com \
--to=nicolas.chautru@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=hernan.vargas@intel.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).