From: Oleksandr Kolomeiets <okl-plv@napatech.com>
To: dev@dpdk.org
Cc: mko-plv@napatech.com, sil-plv@napatech.com, ckm@napatech.com,
stephen@networkplumber.org, thomas@monjalon.net
Subject: [PATCH v2 05/26] net/ntnic: include all queues into statistics
Date: Mon, 5 May 2025 09:12:45 +0200 [thread overview]
Message-ID: <20250505071309.586015-6-okl-plv@napatech.com> (raw)
In-Reply-To: <20250505071309.586015-1-okl-plv@napatech.com>
Queues with indices greater than or equal to RTE_ETHDEV_QUEUE_STAT_CNTRS
are ignored when calculating per-queue statistics,
however they should be taken into account for calculating the total.
Signed-off-by: Oleksandr Kolomeiets <okl-plv@napatech.com>
---
drivers/net/ntnic/ntnic_ethdev.c | 32 ++++++++++++++++++--------------
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntnic_ethdev.c
index f9644b5826..6857191ef2 100644
--- a/drivers/net/ntnic/ntnic_ethdev.c
+++ b/drivers/net/ntnic/ntnic_ethdev.c
@@ -200,20 +200,24 @@ static int dpdk_stats_collect(struct pmd_internals *internals, struct rte_eth_st
*/
ntnic_filter_ops->poll_statistics(internals);
- for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS && i < internals->nb_rx_queues; i++) {
- stats->q_ipackets[i] = internals->rxq_scg[i].rx_pkts;
- stats->q_ibytes[i] = internals->rxq_scg[i].rx_bytes;
- rx_total += stats->q_ipackets[i];
- rx_total_b += stats->q_ibytes[i];
- }
-
- for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS && i < internals->nb_tx_queues; i++) {
- stats->q_opackets[i] = internals->txq_scg[i].tx_pkts;
- stats->q_obytes[i] = internals->txq_scg[i].tx_bytes;
- stats->q_errors[i] = internals->txq_scg[i].err_pkts;
- tx_total += stats->q_opackets[i];
- tx_total_b += stats->q_obytes[i];
- tx_err_total += stats->q_errors[i];
+ for (i = 0; i < internals->nb_rx_queues; i++) {
+ if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
+ stats->q_ipackets[i] = internals->rxq_scg[i].rx_pkts;
+ stats->q_ibytes[i] = internals->rxq_scg[i].rx_bytes;
+ }
+ rx_total += internals->rxq_scg[i].rx_pkts;
+ rx_total_b += internals->rxq_scg[i].rx_bytes;
+ }
+
+ for (i = 0; i < internals->nb_tx_queues; i++) {
+ if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
+ stats->q_opackets[i] = internals->txq_scg[i].tx_pkts;
+ stats->q_obytes[i] = internals->txq_scg[i].tx_bytes;
+ stats->q_errors[i] = internals->txq_scg[i].err_pkts;
+ }
+ tx_total += internals->txq_scg[i].tx_pkts;
+ tx_total_b += internals->txq_scg[i].tx_bytes;
+ tx_err_total += internals->txq_scg[i].err_pkts;
}
stats->imissed = internals->rx_missed;
--
2.47.1
next prev parent reply other threads:[~2025-05-05 7:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 7:12 [PATCH v2 00/26] net/ntnic: fixes and improvements Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 01/26] net/ntnic: remove usage of the variable-length arrays Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 02/26] net/ntnic: handle string truncations when using strlcpy Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 03/26] net/ntnic: replace pragma pack with DPDK defined macros Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 04/26] net/ntnic: remove extra memset Oleksandr Kolomeiets
2025-05-05 7:12 ` Oleksandr Kolomeiets [this message]
2025-05-05 7:12 ` [PATCH v2 06/26] net/ntnic: avoid misleading variable names Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 07/26] net/ntnic: apply packing to the structure Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 08/26] net/ntnic: correct misspelled variable names Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 09/26] net/ntnic: improve logging format specifiers Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 10/26] net/ntnic: remove usless expressions Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 11/26] net/ntnic: remove unused code Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 12/26] net/ntnic: remove usless part of conditional expression Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 13/26] net/ntnic: add error logging for hsh Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 14/26] net/ntnic: add explicitly specificator Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 15/26] net/ntnic: add handle memory allocation failures Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 16/26] net/ntnic: remove redundant initialization Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 17/26] net/ntnic: enhance null checks and assertions Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 18/26] net/ntnic: add return value check Oleksandr Kolomeiets
2025-05-05 7:12 ` [PATCH v2 19/26] net/ntnic: remove redundant assignments and branching Oleksandr Kolomeiets
2025-05-05 7:13 ` [PATCH v2 20/26] net/ntnic: rework array usage Oleksandr Kolomeiets
2025-05-05 7:13 ` [PATCH v2 21/26] net/ntnic: avoid divide by zero Oleksandr Kolomeiets
2025-05-05 7:13 ` [PATCH v2 22/26] net/ntnic: remove unnecessary void cast Oleksandr Kolomeiets
2025-05-05 7:13 ` [PATCH v2 23/26] net/ntnic: remove unnecessary memset Oleksandr Kolomeiets
2025-05-05 7:13 ` [PATCH v2 24/26] net/ntnic: add null verification Oleksandr Kolomeiets
2025-05-05 7:13 ` [PATCH v2 25/26] net/ntnic: avoid possible deadlock Oleksandr Kolomeiets
2025-05-05 7:13 ` [PATCH v2 26/26] net/ntnic: fix operation with rte ring queue Oleksandr Kolomeiets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505071309.586015-6-okl-plv@napatech.com \
--to=okl-plv@napatech.com \
--cc=ckm@napatech.com \
--cc=dev@dpdk.org \
--cc=mko-plv@napatech.com \
--cc=sil-plv@napatech.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).