From: Sunyang Wu <sunyang.wu@jaguarmicro.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru
Subject: [PATCH] ethdev: optimize how the values of the flag variables are assigned
Date: Thu, 8 May 2025 10:33:34 +0800 [thread overview]
Message-ID: <20250508023334.28416-1-sunyang.wu@jaguarmicro.com> (raw)
Set the values of the promiscuous and all_multicast variables
according to the return value.
Signed-off-by: Sunyang Wu <sunyang.wu@jaguarmicro.com>
---
lib/ethdev/rte_ethdev.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index d4197322a0..b1f593edc4 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -3044,10 +3044,8 @@ rte_eth_promiscuous_disable(uint16_t port_id)
if (dev->dev_ops->promiscuous_disable == NULL)
return -ENOTSUP;
- dev->data->promiscuous = 0;
diag = dev->dev_ops->promiscuous_disable(dev);
- if (diag != 0)
- dev->data->promiscuous = 1;
+ dev->data->promiscuous = (diag == 0) ? 0 : 1;
diag = eth_err(port_id, diag);
@@ -3112,10 +3110,9 @@ rte_eth_allmulticast_disable(uint16_t port_id)
if (dev->dev_ops->allmulticast_disable == NULL)
return -ENOTSUP;
- dev->data->all_multicast = 0;
+
diag = dev->dev_ops->allmulticast_disable(dev);
- if (diag != 0)
- dev->data->all_multicast = 1;
+ dev->data->all_multicast = (diag == 0) ? 0 : 1;
diag = eth_err(port_id, diag);
--
2.19.0.rc0.windows.1
next reply other threads:[~2025-05-08 2:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 2:33 Sunyang Wu [this message]
2025-05-08 5:34 ` Stephen Hemminger
2025-05-08 6:26 ` 回复: " Sunyang Wu
2025-05-08 8:17 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508023334.28416-1-sunyang.wu@jaguarmicro.com \
--to=sunyang.wu@jaguarmicro.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).