From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
To: <dev@dpdk.org>, Ankur Dwivedi <adwivedi@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>,
"Gowrishankar Muthukrishnan" <gmuthukrishn@marvell.com>
Cc: Akhil Goyal <gakhil@marvell.com>, <stable@dpdk.org>
Subject: [PATCH] crypto/cnxk: fix out-of-bounds access
Date: Thu, 15 May 2025 13:35:25 +0530 [thread overview]
Message-ID: <20250515080528.1644-1-gmuthukrishn@marvell.com> (raw)
Fix coverity issue on out-of-bounds access.
Coverity-issue: 403166, 403171, 403172
Fixes: 5686b573e4b ("crypto/cnxk: support SM2")
Cc: stable@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
drivers/crypto/cnxk/cnxk_ae.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/crypto/cnxk/cnxk_ae.h b/drivers/crypto/cnxk/cnxk_ae.h
index cd66f66e70..75d6a536ae 100644
--- a/drivers/crypto/cnxk/cnxk_ae.h
+++ b/drivers/crypto/cnxk/cnxk_ae.h
@@ -1090,6 +1090,9 @@ cnxk_ae_sm2_sign_prep(struct rte_crypto_sm2_op_param *sm2,
if (order_len > ROC_AE_EC_DATA_MAX)
order_len = ROC_AE_EC_DATA_MAX;
+ if (pkey_len > ROC_AE_EC_DATA_MAX)
+ pkey_len = ROC_AE_EC_DATA_MAX;
+
/* Truncate input length to curve prime length */
if (message_len > prime_len)
message_len = prime_len;
@@ -1181,6 +1184,12 @@ cnxk_ae_sm2_verify_prep(struct rte_crypto_sm2_op_param *sm2,
if (order_len > ROC_AE_EC_DATA_MAX)
order_len = ROC_AE_EC_DATA_MAX;
+ if (qx_len > ROC_AE_EC_DATA_MAX)
+ qx_len = ROC_AE_EC_DATA_MAX;
+
+ if (qy_len > ROC_AE_EC_DATA_MAX)
+ qy_len = ROC_AE_EC_DATA_MAX;
+
/* Truncate input length to curve prime length */
if (message_len > prime_len)
message_len = prime_len;
--
2.25.1
reply other threads:[~2025-05-15 8:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515080528.1644-1-gmuthukrishn@marvell.com \
--to=gmuthukrishn@marvell.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=ktejasree@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).