Re: [PATCH v6 1/2] ethdev: support RSS based on RoCEv2 header

[Stephen Hemminger <stephen@networkplumber.org>]

On Mon, 5 May 2025 11:27:15 +0530
<kirankumark@marvell.com> wrote:
> @@ -149,6 +151,7 @@ const struct rss_type_info rss_type_table[] = {
>  	{ "l3-dst-only", RTE_ETH_RSS_L3_DST_ONLY },
>  	{ "l3-src-only", RTE_ETH_RSS_L3_SRC_ONLY },
>  	{ "ipv6-flow-label", RTE_ETH_RSS_IPV6_FLOW_LABEL },
> +	{ "ib_bth", RTE_ETH_RSS_IB_BTH },

Please follow convention of other options. Use minus instead of underscore.
Consistency matters.

> diff --git a/doc/guides/rel_notes/release_25_07.rst b/doc/guides/rel_notes/release_25_07.rst
> index 093b85d206..d1293893be 100644
> --- a/doc/guides/rel_notes/release_25_07.rst
> +++ b/doc/guides/rel_notes/release_25_07.rst
> @@ -55,6 +55,10 @@ New Features
>       Also, make sure to start the actual text at the margin.
>       =======================================================
>  
> +* **Added new RSS offload types for IB_BTH in RSS flow.**
> +
> +     Added ``RTE_ETH_RSS_IB_BTH`` macro so that the IB BTH header can be used as input set for RSS.
> +

Please add reference to the relevant standard and expand the acronym
at least one place in the documentation.


> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> index ea7f8c4a1a..edcd6b75b5 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -602,6 +602,7 @@ struct rte_eth_rss_conf {
>  
>  #define RTE_ETH_RSS_L2TPV2             RTE_BIT64(36)
>  #define RTE_ETH_RSS_IPV6_FLOW_LABEL    RTE_BIT64(37)
> +#define RTE_ETH_RSS_IB_BTH		RTE_BIT64(38)
>  

Why is the acronym IB_BTH rather than ROCEV2?
Wouldn't it be clearer if it followed convention?