From: Stephen Hemminger <stephen@networkplumber.org>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, chenbox@nvidia.com
Subject: Re: [PATCH v1] net/virtio-user: implement MAC setting for Vhost-kernel
Date: Wed, 21 May 2025 07:52:58 -0700 [thread overview]
Message-ID: <20250521075258.01d6bc50@hermes.local> (raw)
In-Reply-To: <20250521142305.343264-1-maxime.coquelin@redhat.com>
On Wed, 21 May 2025 16:23:05 +0200
Maxime Coquelin <maxime.coquelin@redhat.com> wrote:
> iff --git a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
> index 611e2e25ec..3e13f8f65b 100644
> --- a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
> +++ b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
> @@ -112,7 +112,7 @@ tap_get_flags(int tapfd, unsigned int *tap_flags)
> }
>
> int
> -tap_set_mac(int tapfd, uint8_t *mac)
> +tap_set_mac(int tapfd, const uint8_t *mac)
> {
> struct ifreq ifr;
Since static building of DPDK does not have namespaces, it would be
good if virtio use of tap and tap device did not get name conflicts.
I.e make all the global function names start with "virtio_tap_" prefix
prev parent reply other threads:[~2025-05-21 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 14:23 Maxime Coquelin
2025-05-21 14:52 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250521075258.01d6bc50@hermes.local \
--to=stephen@networkplumber.org \
--cc=chenbox@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).