From: Shai Brandes <shaibran@amazon.com>
To: <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>
Subject: [PATCH v3 1/7] net/ena/base: avoid recalculating desc per entry
Date: Thu, 22 May 2025 16:26:08 +0300 [thread overview]
Message-ID: <20250522132614.3379-2-shaibran@amazon.com> (raw)
In-Reply-To: <20250522132614.3379-1-shaibran@amazon.com>
desc_per_entry is precomputed in ena_com_config_llq_info() using
desc_stride_ctrl and desc_list_entry_size, which remain unchanged after
device negotiation. Reuse the existing value instead of recalculating it
in the fast path.
Signed-off-by: Shai Brandes <shaibran@amazon.com>
Reviewed-by: Amit Bernstein <amitbern@amazon.com>
Reviewed-by: Yosef Raisman <yraisman@amazon.com>
---
drivers/net/ena/base/ena_eth_com.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ena/base/ena_eth_com.c b/drivers/net/ena/base/ena_eth_com.c
index 90dd85c7ff..c6668238e5 100644
--- a/drivers/net/ena/base/ena_eth_com.c
+++ b/drivers/net/ena/base/ena_eth_com.c
@@ -248,11 +248,7 @@ static int ena_com_sq_update_llq_tail(struct ena_com_io_sq *io_sq)
0x0, llq_info->desc_list_entry_size);
pkt_ctrl->idx = 0;
- if (unlikely(llq_info->desc_stride_ctrl == ENA_ADMIN_SINGLE_DESC_PER_ENTRY))
- pkt_ctrl->descs_left_in_line = 1;
- else
- pkt_ctrl->descs_left_in_line =
- llq_info->desc_list_entry_size / io_sq->desc_entry_size;
+ pkt_ctrl->descs_left_in_line = llq_info->descs_per_entry;
}
return ENA_COM_OK;
--
2.17.1
next prev parent reply other threads:[~2025-05-22 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 13:26 [PATCH v3 0/7] net/ena: release 2.13.0 Shai Brandes
2025-05-22 13:26 ` Shai Brandes [this message]
2025-05-22 13:26 ` [PATCH v3 2/7] net/ena/base: coding style changes Shai Brandes
2025-05-22 13:26 ` [PATCH v3 3/7] net/ena: separate doorbell logic for Rx and Tx Shai Brandes
2025-05-22 13:26 ` [PATCH v3 4/7] net/ena: support fragment bypass mode Shai Brandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522132614.3379-2-shaibran@amazon.com \
--to=shaibran@amazon.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).