From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB654467CA; Fri, 23 May 2025 15:56:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 218F640E68; Fri, 23 May 2025 15:53:19 +0200 (CEST) Received: from mx0a-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id EB67E40F35 for ; Fri, 23 May 2025 15:53:17 +0200 (CEST) Received: from pps.filterd (m0431384.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54NBAf19031533 for ; Fri, 23 May 2025 06:53:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=H PZ7sOzYDMPkRPz+e0g1kz0MR8qsA+uGOiYcUQnPUvA=; b=OUhnlftWdFDNmtFXH BjcYYVzSzh0fI4KlMRrxK9Hct5OB7oMlHSC/OiKTALxQka3O5rJQe1No04O3ke7k Io9Oj341L3lG9d5J01RIY1gSgTLV6HQ+uSN7YnCnAfgxTbdAXkNJ3lBTQAAhNAkg FhejAv6+Ck/DEUHxYPVO6PfDsgJ4KnCBcc+5pE0WfFcG5TackPextQwds7zZCGwi k4HFJYDQJtCG9rlztH/a4J/Q4eGR9hp/4ajUI3tpJfZBCQQ8NpvbsQ8DiCXFCgpF a6biJ11MFNzQjUuOfJteLa+gLGJmqw8AwohXDOokdAbqPm7Gc2wY/3uMg14CY9kO WnYsg== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 46tqw589kr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 23 May 2025 06:53:16 -0700 (PDT) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 23 May 2025 06:53:15 -0700 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Fri, 23 May 2025 06:53:15 -0700 Received: from hyd1554.caveonetworks.com (unknown [10.29.56.32]) by maili.marvell.com (Postfix) with ESMTP id C1F403F7041; Fri, 23 May 2025 06:53:12 -0700 (PDT) From: Tejasree Kondoj To: Akhil Goyal CC: Vidya Sagar Velumuri , Anoob Joseph , Aakash Sasidharan , "Nithinsen Kaithakadan" , Rupesh Chiluka , Subject: [PATCH 37/40] crypto/cnxk: add support for sessionless asym Date: Fri, 23 May 2025 19:21:08 +0530 Message-ID: <20250523135111.2178408-38-ktejasree@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250523135111.2178408-1-ktejasree@marvell.com> References: <20250523135111.2178408-1-ktejasree@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Authority-Analysis: v=2.4 cv=F8xXdrhN c=1 sm=1 tr=0 ts=68307dcc cx=c_pps a=gIfcoYsirJbf48DBMSPrZA==:117 a=gIfcoYsirJbf48DBMSPrZA==:17 a=dt9VzEwgFbYA:10 a=M5GUcnROAAAA:8 a=V96RGjsnX57IfUnXaCcA:9 a=OBjm3rFKGHvpk9ecZwUJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIzMDEyMyBTYWx0ZWRfXzC/qZz/Ptw2U 6E6RSTF0TqNbbIwSKPuanDrKQVzv12zLGVXoVDk25uWIAeaPnM/j9Z5IJ30dJr/q/laSId+gvcx 2/J08ocGyp5r4MZSpFx37Co2eAjWZ7WbSUlZ/7QSzuHBNSKya5R/xz526hSoHtS83Q0YRl+iwaR G9JNz58xZldsBEx25KtNKg3nTaV1Qdl21p8HJoIEuggW6RL95z6334zmxCygsHz4P4iqOPWrjs9 8bB5RuCtqsbIH/IyMGn6Ky0QssK7UHJJL1oLzkWhNjOg3DyH2FCC6vleUq/Idbv7lPOocuf+xKm U2eH80n2NqWBP1paTRM3ugSPVav/GkzIhXA9kDCAk+vR1Si/hNcYerRqW4tYWkZ+xhkjTWMVJDY MzFoswxySJFKyq3TSuGWUrAx+Fc/mSK4Rx83EsW1SevsnBGE8K1hrYXebIaNT7G3iWxvNlCj X-Proofpoint-GUID: ABTFoo4SQ8g11nc_qmI9fJ9Ay95yLFwi X-Proofpoint-ORIG-GUID: ABTFoo4SQ8g11nc_qmI9fJ9Ay95yLFwi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-23_04,2025-05-22_01,2025-03-28_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Vidya Sagar Velumuri Add support for sessionless asymmetric operations for cnxk Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 72 ++++++++++++++++++++++- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 57 +++++++++++++++++- drivers/crypto/cnxk/cnxk_cryptodev.c | 3 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 5 +- 4 files changed, 130 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c index 813a2deb66..4f7b34cc21 100644 --- a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c @@ -76,6 +76,55 @@ cn10k_cpt_sym_temp_sess_create(struct cnxk_cpt_qp *qp, struct rte_crypto_op *op) return NULL; } +static inline struct cnxk_ae_sess * +cn10k_cpt_asym_temp_sess_create(struct cnxk_cpt_qp *qp, struct rte_crypto_op *op) +{ + struct rte_crypto_asym_op *asym_op = op->asym; + struct roc_cpt *roc_cpt = qp->lf.roc_cpt; + struct rte_cryptodev_asym_session *sess; + struct cnxk_ae_sess *priv; + struct cnxk_cpt_vf *vf; + union cpt_inst_w7 w7; + struct hw_ctx_s *hwc; + + /* Create temporary session */ + if (rte_mempool_get(qp->sess_mp, (void **)&sess) < 0) + return NULL; + + priv = (struct cnxk_ae_sess *)sess; + if (cnxk_ae_fill_session_parameters(priv, asym_op->xform)) + goto sess_put; + + priv->lf = &qp->lf; + + if (roc_errata_cpt_hang_on_mixed_ctx_val()) { + hwc = &priv->hw_ctx; + hwc->w0.s.aop_valid = 1; + hwc->w0.s.ctx_hdr_size = 0; + hwc->w0.s.ctx_size = 1; + hwc->w0.s.ctx_push_size = 1; + + w7.s.ctx_val = 1; + w7.s.cptr = (uint64_t)hwc; + } + + w7.u64 = 0; + w7.s.egrp = roc_cpt->eng_grp[CPT_ENG_TYPE_AE]; + + vf = container_of(roc_cpt, struct cnxk_cpt_vf, cpt); + priv->cpt_inst_w7 = w7.u64; + priv->cnxk_fpm_iova = vf->cnxk_fpm_iova; + priv->ec_grp = vf->ec_grp; + + asym_op->session = sess; + + return priv; + +sess_put: + rte_mempool_put(qp->sess_mp, sess); + return NULL; +} + static __rte_always_inline int __rte_hot cpt_sec_ipsec_inst_fill(struct cnxk_cpt_qp *qp, struct rte_crypto_op *op, struct cn10k_sec_session *sess, struct cpt_inst_s *inst, @@ -177,7 +226,6 @@ cn10k_cpt_fill_inst(struct cnxk_cpt_qp *qp, struct rte_crypto_op *ops[], struct w7 = sess->cpt_inst_w7; } } else if (op->type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC) { - if (op->sess_type == RTE_CRYPTO_OP_WITH_SESSION) { asym_op = op->asym; ae_sess = (struct cnxk_ae_sess *)asym_op->session; @@ -186,9 +234,22 @@ cn10k_cpt_fill_inst(struct cnxk_cpt_qp *qp, struct rte_crypto_op *ops[], struct return 0; w7 = ae_sess->cpt_inst_w7; } else { - plt_dp_err("Not supported Asym op without session"); - return 0; + ae_sess = cn10k_cpt_asym_temp_sess_create(qp, op); + if (unlikely(ae_sess == NULL)) { + plt_dp_err("Could not create temp session"); + return 0; + } + + ret = cnxk_ae_enqueue(qp, op, infl_req, &inst[0], ae_sess); + if (unlikely(ret)) { + cnxk_ae_session_clear(NULL, + (struct rte_cryptodev_asym_session *)ae_sess); + rte_mempool_put(qp->sess_mp, ae_sess); + return 0; + } + w7 = ae_sess->cpt_inst_w7; } + } else { plt_dp_err("Unsupported op type"); return 0; @@ -1145,6 +1206,11 @@ cn10k_cpt_dequeue_post_process(struct cnxk_cpt_qp *qp, struct rte_crypto_op *cop rte_mempool_put(qp->sess_mp, cop->sym->session); cop->sym->session = NULL; } + if (cop->type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC) { + cnxk_ae_session_clear(NULL, cop->asym->session); + rte_mempool_put(qp->sess_mp, cop->asym->session); + cop->asym->session = NULL; + } } } diff --git a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c index fa22b5ce44..570051518c 100644 --- a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c @@ -67,6 +67,43 @@ cn9k_cpt_sym_temp_sess_create(struct cnxk_cpt_qp *qp, struct rte_crypto_op *op) return NULL; } +static inline struct cnxk_ae_sess * +cn9k_cpt_asym_temp_sess_create(struct cnxk_cpt_qp *qp, struct rte_crypto_op *op) +{ + struct rte_crypto_asym_op *asym_op = op->asym; + struct roc_cpt *roc_cpt = qp->lf.roc_cpt; + struct rte_cryptodev_asym_session *sess; + struct cnxk_ae_sess *priv; + struct cnxk_cpt_vf *vf; + union cpt_inst_w7 w7; + + /* Create temporary session */ + if (rte_mempool_get(qp->sess_mp, (void **)&sess) < 0) + return NULL; + + priv = (struct cnxk_ae_sess *)sess; + if (cnxk_ae_fill_session_parameters(priv, asym_op->xform)) + goto sess_put; + + priv->lf = &qp->lf; + + w7.u64 = 0; + w7.s.egrp = roc_cpt->eng_grp[CPT_ENG_TYPE_AE]; + + vf = container_of(roc_cpt, struct cnxk_cpt_vf, cpt); + priv->cpt_inst_w7 = w7.u64; + priv->cnxk_fpm_iova = vf->cnxk_fpm_iova; + priv->ec_grp = vf->ec_grp; + + asym_op->session = sess; + + return priv; + +sess_put: + rte_mempool_put(qp->sess_mp, sess); + return NULL; +} + static inline int cn9k_cpt_inst_prep(struct cnxk_cpt_qp *qp, struct rte_crypto_op *op, struct cpt_inflight_req *infl_req, struct cpt_inst_s *inst) @@ -106,7 +143,20 @@ cn9k_cpt_inst_prep(struct cnxk_cpt_qp *qp, struct rte_crypto_op *op, ret = cnxk_ae_enqueue(qp, op, infl_req, inst, sess); inst->w7.u64 = sess->cpt_inst_w7; } else { - ret = -EINVAL; + sess = cn9k_cpt_asym_temp_sess_create(qp, op); + if (unlikely(sess == NULL)) { + plt_dp_err("Could not create temp session"); + return 0; + } + + ret = cnxk_ae_enqueue(qp, op, infl_req, inst, sess); + if (unlikely(ret)) { + cnxk_ae_session_clear(NULL, + (struct rte_cryptodev_asym_session *)sess); + rte_mempool_put(qp->sess_mp, sess); + return 0; + } + inst->w7.u64 = sess->cpt_inst_w7; } } else { ret = -EINVAL; @@ -607,6 +657,11 @@ cn9k_cpt_dequeue_post_process(struct cnxk_cpt_qp *qp, struct rte_crypto_op *cop, rte_mempool_put(qp->sess_mp, cop->sym->session); cop->sym->session = NULL; } + if (cop->type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC) { + cnxk_ae_session_clear(NULL, cop->asym->session); + rte_mempool_put(qp->sess_mp, cop->asym->session); + cop->asym->session = NULL; + } } } diff --git a/drivers/crypto/cnxk/cnxk_cryptodev.c b/drivers/crypto/cnxk/cnxk_cryptodev.c index 96b5121097..5828a502e4 100644 --- a/drivers/crypto/cnxk/cnxk_cryptodev.c +++ b/drivers/crypto/cnxk/cnxk_cryptodev.c @@ -19,7 +19,8 @@ cnxk_cpt_default_ff_get(void) RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | RTE_CRYPTODEV_FF_IN_PLACE_SGL | RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT | RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT | RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT | RTE_CRYPTODEV_FF_SYM_SESSIONLESS | - RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED | RTE_CRYPTODEV_FF_SECURITY; + RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED | RTE_CRYPTODEV_FF_SECURITY | + RTE_CRYPTODEV_FF_ASYM_SESSIONLESS; if (roc_model_is_cn10k() || roc_model_is_cn20k()) ff |= RTE_CRYPTODEV_FF_SECURITY_INNER_CSUM | RTE_CRYPTODEV_FF_SYM_RAW_DP; diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c b/drivers/crypto/cnxk/cnxk_cryptodev_ops.c index e5ca082e10..261e14b418 100644 --- a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cnxk_cryptodev_ops.c @@ -866,7 +866,8 @@ cnxk_ae_session_size_get(struct rte_cryptodev *dev __rte_unused) } void -cnxk_ae_session_clear(struct rte_cryptodev *dev, struct rte_cryptodev_asym_session *sess) +cnxk_ae_session_clear(struct rte_cryptodev *dev __rte_unused, + struct rte_cryptodev_asym_session *sess) { struct cnxk_ae_sess *priv = (struct cnxk_ae_sess *)sess; @@ -878,7 +879,7 @@ cnxk_ae_session_clear(struct rte_cryptodev *dev, struct rte_cryptodev_asym_sessi cnxk_ae_free_session_parameters(priv); /* Reset and free object back to pool */ - memset(priv, 0, cnxk_ae_session_size_get(dev)); + memset(priv, 0, sizeof(struct cnxk_ae_sess)); } int -- 2.25.1