DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nicolas Chautru <nicolas.chautru@intel.com>
To: dev@dpdk.org, maxime.coquelin@redhat.com
Cc: hemant.agrawal@nxp.com, hernan.vargas@intel.com,
	Nicolas Chautru <nicolas.chautru@intel.com>
Subject: [PATCH v1 2/2] baseband/acc: add trace points per operation
Date: Tue, 27 May 2025 15:36:42 -0700	[thread overview]
Message-ID: <20250527223642.31577-3-nicolas.chautru@intel.com> (raw)
In-Reply-To: <20250527223642.31577-1-nicolas.chautru@intel.com>

Add the details of the operation parameters into
trace when that operation is rejected by the PMD.

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 drivers/baseband/acc/acc_common.h | 1 +
 drivers/baseband/acc/vrb_trace.h  | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h
index 4880444450..3d411cd25f 100644
--- a/drivers/baseband/acc/acc_common.h
+++ b/drivers/baseband/acc/acc_common.h
@@ -700,6 +700,7 @@ acc_error_log(struct acc_queue *q, void *op, uint8_t acc_error_idx, const char *
 
 	rte_bbdev_vrb_trace_error(0, rte_bbdev_op_type_str(q->op_type),
 			acc_error_string[acc_error_idx]);
+	rte_bbdev_ops_trace(op, q->op_type);
 
 	va_end(args);
 }
diff --git a/drivers/baseband/acc/vrb_trace.h b/drivers/baseband/acc/vrb_trace.h
index 0bbfdc47d1..c9ae239fec 100644
--- a/drivers/baseband/acc/vrb_trace.h
+++ b/drivers/baseband/acc/vrb_trace.h
@@ -11,7 +11,7 @@ extern "C" {
 
 #include <rte_trace_point.h>
 
-RTE_TRACE_POINT_FP(
+RTE_TRACE_POINT(
 	rte_bbdev_vrb_trace_error,
 	RTE_TRACE_POINT_ARGS(uint8_t dev_id, const char *op_string, const char *err_string),
 	rte_trace_point_emit_u8(dev_id);
@@ -19,7 +19,7 @@ RTE_TRACE_POINT_FP(
 	rte_trace_point_emit_string(err_string);
 )
 
-RTE_TRACE_POINT_FP(
+RTE_TRACE_POINT(
 	rte_bbdev_vrb_trace_queue_error,
 	RTE_TRACE_POINT_ARGS(uint8_t qg_id, uint8_t aq_id, const char *str),
 	rte_trace_point_emit_u8(qg_id);
-- 
2.34.1


      parent reply	other threads:[~2025-05-27 22:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-27 22:36 [PATCH v1 0/2] bbdev: add trace point per operations Nicolas Chautru
2025-05-27 22:36 ` [PATCH v1 1/2] bbdev: add trace points per operation Nicolas Chautru
2025-05-27 22:36 ` Nicolas Chautru [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250527223642.31577-3-nicolas.chautru@intel.com \
    --to=nicolas.chautru@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=hernan.vargas@intel.com \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).