DPDK patches and discussions
 help / color / mirror / Atom feed
From: <skori@marvell.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Satha Rao <skoteshwar@marvell.com>,
	Harman Kalra <hkalra@marvell.com>
Cc: <dev@dpdk.org>
Subject: [PATCH 2/7] common/cnxk: support link mode configuration
Date: Thu, 5 Jun 2025 14:36:37 +0530	[thread overview]
Message-ID: <20250605090657.3032918-2-skori@marvell.com> (raw)
In-Reply-To: <20250605090657.3032918-1-skori@marvell.com>

From: Sunil Kumar Kori <skori@marvell.com>

CGX MAC can be configured into different modes and speeds
as mentioned below:

 - fixed/autoneg
 - half/full duplex
 - 10M/100M/1G/10G etc speeds.

Sync mailbox and implement that to configure above mentioned
settings.

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
 drivers/common/cnxk/hw/nix.h                  | 70 ++++++++++++++
 drivers/common/cnxk/roc_mbox.h                | 15 ++-
 drivers/common/cnxk/roc_nix.h                 | 95 ++++++++++++++++++-
 drivers/common/cnxk/roc_nix_mac.c             | 38 +++++++-
 drivers/common/cnxk/roc_nix_priv.h            |  2 +
 .../common/cnxk/roc_platform_base_symbols.c   |  1 +
 6 files changed, 211 insertions(+), 10 deletions(-)

diff --git a/drivers/common/cnxk/hw/nix.h b/drivers/common/cnxk/hw/nix.h
index d16fa3b3ec..f344d4de99 100644
--- a/drivers/common/cnxk/hw/nix.h
+++ b/drivers/common/cnxk/hw/nix.h
@@ -2681,4 +2681,74 @@ struct nix_lso_format {
  */
 #define NIX_CHAN_CPT_X2P_MASK (0x7ffull)
 
+/* CGX lmac types defined by firmware */
+enum cgx_lmac_type {
+	CGX_LMAC_TYPE_SGMII = 0,
+	CGX_LMAC_TYPE_XAUI = 1,
+	CGX_LMAC_TYPE_RXAUI = 2,
+	CGX_LMAC_TYPE_10G_R = 3,
+	CGX_LMAC_TYPE_40G_R = 4,
+	CGX_LMAC_TYPE_QSGMII = 6,
+	CGX_LMAC_TYPE_25G_R = 7,
+	CGX_LMAC_TYPE_50G_R = 8,
+	CGX_LMAC_TYPE_100G_R = 9,
+	CGX_LMAC_TYPE_USXGMII = 10,
+	CGX_LMAC_TYPE_USGMII = 11,
+	CGX_LMAC_TYPE_MAX,
+};
+
+/* CGX modes defined by firmware */
+enum cgx_mode {
+	CGX_MODE_SGMII,
+	CGX_MODE_1000_BASEX,
+	CGX_MODE_QSGMII,
+	CGX_MODE_10G_C2C,
+	CGX_MODE_10G_C2M,
+	CGX_MODE_10G_KR,
+	CGX_MODE_20G_C2C,
+	CGX_MODE_25G_C2C,
+	CGX_MODE_25G_C2M,
+	CGX_MODE_25G_2_C2C,
+	CGX_MODE_25G_CR,
+	CGX_MODE_25G_KR,
+	CGX_MODE_40G_C2C,
+	CGX_MODE_40G_C2M,
+	CGX_MODE_40G_CR4,
+	CGX_MODE_40G_KR4,
+	CGX_MODE_40GAUI_C2C,
+	CGX_MODE_50G_C2C,
+	CGX_MODE_50G_C2M,
+	CGX_MODE_50G_4_C2C,
+	CGX_MODE_50G_CR,
+	CGX_MODE_50G_KR,
+	CGX_MODE_80GAUI_C2C,
+	CGX_MODE_100G_C2C,
+	CGX_MODE_100G_C2M,
+	CGX_MODE_100G_CR4,
+	CGX_MODE_100G_KR4,
+	CGX_MODE_LAUI_2_C2C_BIT,
+	CGX_MODE_LAUI_2_C2M_BIT,
+	CGX_MODE_50GBASE_CR2_C_BIT,
+	CGX_MODE_50GBASE_KR2_C_BIT, /* = 30 */
+	CGX_MODE_100GAUI_2_C2C_BIT,
+	CGX_MODE_100GAUI_2_C2M_BIT,
+	CGX_MODE_100GBASE_CR2_BIT,
+	CGX_MODE_100GBASE_KR2_BIT,
+	CGX_MODE_SFI_1G_BIT,
+	CGX_MODE_25GBASE_CR_C_BIT,
+	CGX_MODE_25GBASE_KR_C_BIT,
+	ETH_MODE_SGMII_10M_BIT,
+	ETH_MODE_SGMII_100M_BIT,      /* = 39 */
+	ETH_MODE_2500_BASEX_BIT = 42, /* Mode group 1 */
+	ETH_MODE_5000_BASEX_BIT,
+	ETH_MODE_O_USGMII_BIT,
+	ETH_MODE_Q_USGMII_BIT,
+	ETH_MODE_2_5G_USXGMII_BIT,
+	ETH_MODE_5G_USXGMII_BIT,
+	ETH_MODE_10G_SXGMII_BIT,
+	ETH_MODE_10G_DXGMII_BIT,
+	ETH_MODE_10G_QXGMII_BIT,
+	CGX_MODE_MAX /* = 51 */
+};
+
 #endif /* __NIX_HW_H__ */
diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h
index d2192cb6f9..59287253fe 100644
--- a/drivers/common/cnxk/roc_mbox.h
+++ b/drivers/common/cnxk/roc_mbox.h
@@ -764,13 +764,18 @@ struct cgx_lmac_fwdata_s {
 	uint64_t __io supported_fec;
 	uint64_t __io supported_an;
 	uint64_t __io supported_link_modes;
-	/* Only applicable if AN is supported */
+	/* only applicable if AN is supported */
 	uint64_t __io advertised_fec;
-	uint64_t __io advertised_link_modes;
+	uint64_t __io advertised_link_modes_own : 1; /* CGX_CMD_OWN */
+	uint64_t __io advertised_link_modes : 63;
 	/* Only applicable if SFP/QSFP slot is present */
 	struct sfp_eeprom_s sfp_eeprom;
 	struct phy_s phy;
-#define LMAC_FWDATA_RESERVED_MEM 1023
+	uint32_t __io lmac_type;
+	uint32_t __io portm_idx;
+	uint64_t __io mgmt_port : 1;
+	uint64_t __io port;
+#define LMAC_FWDATA_RESERVED_MEM 1018
 	uint64_t __io reserved[LMAC_FWDATA_RESERVED_MEM];
 };
 
@@ -798,8 +803,10 @@ struct cgx_set_link_mode_args {
 	uint32_t __io speed;
 	uint8_t __io duplex;
 	uint8_t __io an;
-	uint8_t __io ports;
+	uint8_t __io mode_baseidx;
+	uint8_t __io multimode;
 	uint64_t __io mode;
+	uint64_t __io advertising;
 };
 
 struct cgx_set_link_mode_req {
diff --git a/drivers/common/cnxk/roc_nix.h b/drivers/common/cnxk/roc_nix.h
index a9cdc42617..41334327bb 100644
--- a/drivers/common/cnxk/roc_nix.h
+++ b/drivers/common/cnxk/roc_nix.h
@@ -16,6 +16,7 @@
 #define ROC_NIX_SQB_THRESH	      30U
 #define ROC_NIX_SQB_SLACK	      12U
 #define ROC_NIX_AURA_THRESH	      95U
+#define ROC_NIX_LINK_SPEED_ALL	      0xFFFFF
 
 /* Reserved interface types for BPID allocation */
 #define ROC_NIX_INTF_TYPE_CGX  0
@@ -109,6 +110,89 @@ enum roc_nix_bpf_stats {
 	ROC_NIX_BPF_RED_OCTS_F_DROP = BIT_ULL(11),
 };
 
+enum roc_nix_link_duplex {
+	ROC_NIX_LINK_DUPLEX_FULL = 0,
+	ROC_NIX_LINK_DUPLEX_HALF = 1
+};
+
+enum roc_nix_link_speed_bits {
+	ROC_NIX_LINK_SPEED_NONE_BIT = BIT_ULL(0),
+	ROC_NIX_LINK_SPEED_10M_HD_BIT = BIT_ULL(1),
+	ROC_NIX_LINK_SPEED_10M_BIT = BIT_ULL(2),
+	ROC_NIX_LINK_SPEED_100M_HD_BIT = BIT_ULL(3),
+	ROC_NIX_LINK_SPEED_100M_BIT = BIT_ULL(4),
+	ROC_NIX_LINK_SPEED_1G_BIT = BIT_ULL(5),
+	ROC_NIX_LINK_SPEED_2_5G_BIT = BIT_ULL(6),
+	ROC_NIX_LINK_SPEED_5G_BIT = BIT_ULL(7),
+	ROC_NIX_LINK_SPEED_10G_BIT = BIT_ULL(8),
+	ROC_NIX_LINK_SPEED_20G_BIT = BIT_ULL(9),
+	ROC_NIX_LINK_SPEED_25G_BIT = BIT_ULL(10),
+	ROC_NIX_LINK_SPEED_40G_BIT = BIT_ULL(11),
+	ROC_NIX_LINK_SPEED_50G_BIT = BIT_ULL(12),
+	ROC_NIX_LINK_SPEED_56G_BIT = BIT_ULL(13),
+	ROC_NIX_LINK_SPEED_100G_BIT = BIT_ULL(14),
+	ROC_NIX_LINK_SPEED_200G_BIT = BIT_ULL(15),
+	ROC_NIX_LINK_SPEED_400G_BIT = BIT_ULL(16),
+	ROC_NIX_LINK_SPEED_MAX = 17
+};
+
+enum roc_nix_link_mode {
+	ROC_NIX_LINK_MODE_10BASET_HD = BIT_ULL(0),
+	ROC_NIX_LINK_MODE_10BASET_FD = BIT_ULL(1),
+	ROC_NIX_LINK_MODE_100BASET_HD = BIT_ULL(2),
+	ROC_NIX_LINK_MODE_100BASET_FD = BIT_ULL(3),
+	ROC_NIX_LINK_MODE_1000BASET_HD = BIT_ULL(4),
+	ROC_NIX_LINK_MODE_1000BASET_FD = BIT_ULL(5),
+	ROC_NIX_LINK_MODE_AUTONEG = BIT_ULL(6),
+	ROC_NIX_LINK_MODE_10000BASET_FD = BIT_ULL(12),
+	ROC_NIX_LINK_MODE_2500BASEX_FD = BIT_ULL(15),
+	ROC_NIX_LINK_MODE_1000BASEKX_FD = BIT_ULL(17),
+	ROC_NIX_LINK_MODE_10000BASEKX4_FD = BIT_ULL(18),
+	ROC_NIX_LINK_MODE_10000BASEKR_FD = BIT_ULL(19),
+	ROC_NIX_LINK_MODE_10000BASER_FEC = BIT_ULL(20),
+	ROC_NIX_LINK_MODE_20000BASEMLD2_FD = BIT_ULL(21),
+	ROC_NIX_LINK_MODE_20000BASEKR2_FD = BIT_ULL(22),
+	ROC_NIX_LINK_MODE_40000BASEKR4_FD = BIT_ULL(23),
+	ROC_NIX_LINK_MODE_40000BASECR4_FD = BIT_ULL(24),
+	ROC_NIX_LINK_MODE_40000BASESR4_FD = BIT_ULL(25),
+	ROC_NIX_LINK_MODE_40000BASELR4_FD = BIT_ULL(26),
+	ROC_NIX_LINK_MODE_56000BASEKR4_FD = BIT_ULL(27),
+	ROC_NIX_LINK_MODE_56000BASECR4_FD = BIT_ULL(28),
+	ROC_NIX_LINK_MODE_56000BASESR4_FD = BIT_ULL(29),
+	ROC_NIX_LINK_MODE_56000BASELR4_FD = BIT_ULL(30),
+	ROC_NIX_LINK_MODE_25000BASECR_FD = BIT_ULL(31),
+	ROC_NIX_LINK_MODE_25000BASEKR_FD = BIT_ULL(32),
+	ROC_NIX_LINK_MODE_25000BASESR_FD = BIT_ULL(33),
+	ROC_NIX_LINK_MODE_50000BASECR2_FD = BIT_ULL(34),
+	ROC_NIX_LINK_MODE_50000BASEKR2_FD = BIT_ULL(35),
+	ROC_NIX_LINK_MODE_100000BASEKR4_FD = BIT_ULL(36),
+	ROC_NIX_LINK_MODE_100000BASESR4_FD = BIT_ULL(37),
+	ROC_NIX_LINK_MODE_100000BASECR4_FD = BIT_ULL(38),
+	ROC_NIX_LINK_MODE_100000BASELR4_ER4_FD = BIT_ULL(39),
+	ROC_NIX_LINK_MODE_50000BASESR2_FD = BIT_ULL(40),
+	ROC_NIX_LINK_MODE_1000BASEX_FD = BIT_ULL(41),
+	ROC_NIX_LINK_MODE_10000BASECR_FD = BIT_ULL(42),
+	ROC_NIX_LINK_MODE_10000BASESR_FD = BIT_ULL(43),
+	ROC_NIX_LINK_MODE_10000BASELR_FD = BIT_ULL(44),
+	ROC_NIX_LINK_MODE_10000BASELRM_FD = BIT_ULL(45),
+	ROC_NIX_LINK_MODE_10000BASEER_FD = BIT_ULL(46),
+	ROC_NIX_LINK_MODE_2500BASET_FD = BIT_ULL(47),
+	ROC_NIX_LINK_MODE_5000BASET_FD = BIT_ULL(48),
+	ROC_NIX_LINK_MODE_FEC_NONE = BIT_ULL(49),
+	ROC_NIX_LINK_MODE_FEC_RS = BIT_ULL(50),
+	ROC_NIX_LINK_MODE_FEC_BASER = BIT_ULL(51),
+	ROC_NIX_LINK_MODE_50000BASEKR_FD = BIT_ULL(52),
+	ROC_NIX_LINK_MODE_50000BASESR_FD = BIT_ULL(53),
+	ROC_NIX_LINK_MODE_50000BASECR_FD = BIT_ULL(54),
+	ROC_NIX_LINK_MODE_50000BASELR_ER_FR_FD = BIT_ULL(55),
+	ROC_NIX_LINK_MODE_50000BASEDR_FD = BIT_ULL(56),
+	ROC_NIX_LINK_MODE_100000BASEKR2_FD = BIT_ULL(57),
+	ROC_NIX_LINK_MODE_100000BASESR2_FD = BIT_ULL(58),
+	ROC_NIX_LINK_MODE_100000BASECR2_FD = BIT_ULL(59),
+	ROC_NIX_LINK_MODE_100000BASELR2_ER2_FR2_FD = BIT_ULL(60),
+	ROC_NIX_LINK_MODE_100000BASEDR2_FD = BIT_ULL(61),
+};
+
 struct roc_nix_bpf_cfg {
 	enum roc_nix_bpf_algo alg;
 	enum roc_nix_bpf_lmode lmode;
@@ -413,9 +497,17 @@ struct roc_nix_link_info {
 	uint64_t full_duplex : 1;
 	uint64_t lmac_type_id : 4;
 	uint64_t speed : 20;
+	uint64_t speed_bitmask : 16;
 	uint64_t autoneg : 1;
 	uint64_t fec : 2;
 	uint64_t port : 8;
+	uint64_t advertising;
+};
+
+struct roc_nix_mac_fwdata {
+	uint64_t advertised_link_modes;
+	uint64_t supported_link_modes;
+	uint64_t supported_an;
 };
 
 /** Maximum name length for extended statistics counters */
@@ -502,7 +594,7 @@ struct roc_nix {
 	bool reass_ena;
 	TAILQ_ENTRY(roc_nix) next;
 
-#define ROC_NIX_MEM_SZ (6 * 1112)
+#define ROC_NIX_MEM_SZ (6 * 1131)
 	uint8_t reserved[ROC_NIX_MEM_SZ] __plt_cache_aligned;
 } __plt_cache_aligned;
 
@@ -865,6 +957,7 @@ void __roc_api roc_nix_mac_link_info_get_cb_unregister(struct roc_nix *roc_nix);
 int __roc_api roc_nix_q_err_cb_register(struct roc_nix *roc_nix, q_err_get_t sq_err_handle);
 void __roc_api roc_nix_q_err_cb_unregister(struct roc_nix *roc_nix);
 int __roc_api roc_nix_mac_stats_reset(struct roc_nix *roc_nix);
+int __roc_api roc_nix_mac_fwdata_get(struct roc_nix *roc_nix, struct roc_nix_mac_fwdata *fwdata);
 
 /* Ops */
 int __roc_api roc_nix_switch_hdr_set(struct roc_nix *roc_nix,
diff --git a/drivers/common/cnxk/roc_nix_mac.c b/drivers/common/cnxk/roc_nix_mac.c
index 54db1adf17..08b4f30810 100644
--- a/drivers/common/cnxk/roc_nix_mac.c
+++ b/drivers/common/cnxk/roc_nix_mac.c
@@ -267,20 +267,19 @@ roc_nix_mac_link_info_set(struct roc_nix *roc_nix,
 	struct cgx_set_link_mode_req *req;
 	int rc;
 
-	rc = roc_nix_mac_link_state_set(roc_nix, link_info->status);
-	if (rc)
-		goto exit;
-
 	req = mbox_alloc_msg_cgx_set_link_mode(mbox);
 	if (req == NULL) {
 		rc =  -ENOSPC;
 		goto exit;
 	}
+
+	req->args.advertising = link_info->advertising;
 	req->args.speed = link_info->speed;
 	req->args.duplex = link_info->full_duplex;
 	req->args.an = link_info->autoneg;
 
-	rc = mbox_process(mbox);
+	/* Link mode changes takes more time. */
+	rc = mbox_process_tmo(mbox, mbox->rsp_tmo * 4);
 exit:
 	mbox_put(mbox);
 	return rc;
@@ -412,3 +411,32 @@ roc_nix_mac_link_info_get_cb_unregister(struct roc_nix *roc_nix)
 
 	dev->ops->link_status_get = NULL;
 }
+
+int
+roc_nix_mac_fwdata_get(struct roc_nix *roc_nix, struct roc_nix_mac_fwdata *data)
+{
+	struct nix *nix = roc_nix_to_nix_priv(roc_nix);
+	struct cgx_fw_data *fw_data;
+	struct dev *dev = &nix->dev;
+	struct mbox *mbox;
+	int rc;
+
+	if (roc_nix_is_sdp(roc_nix))
+		return 0;
+
+	mbox = mbox_get(dev->mbox);
+
+	mbox_alloc_msg_cgx_get_aux_link_info(mbox);
+	rc = mbox_process_msg(mbox, (void *)&fw_data);
+	if (rc)
+		goto exit;
+
+	nix->supported_link_modes = fw_data->fwdata.supported_link_modes;
+	nix->advertised_link_modes = fw_data->fwdata.advertised_link_modes;
+	data->supported_link_modes = nix->supported_link_modes;
+	data->advertised_link_modes = nix->advertised_link_modes;
+	data->supported_an = fw_data->fwdata.supported_an;
+exit:
+	mbox_put(mbox);
+	return rc;
+}
diff --git a/drivers/common/cnxk/roc_nix_priv.h b/drivers/common/cnxk/roc_nix_priv.h
index dc3450a3d4..c949621196 100644
--- a/drivers/common/cnxk/roc_nix_priv.h
+++ b/drivers/common/cnxk/roc_nix_priv.h
@@ -138,6 +138,8 @@ struct nix {
 	uint16_t bpid[NIX_MAX_CHAN];
 	struct nix_qint *qints_mem;
 	struct nix_qint *cints_mem;
+	uint64_t supported_link_modes;
+	uint64_t advertised_link_modes;
 	uint8_t configured_qints;
 	uint8_t configured_cints;
 	uint8_t exact_match_ena;
diff --git a/drivers/common/cnxk/roc_platform_base_symbols.c b/drivers/common/cnxk/roc_platform_base_symbols.c
index 7f0fe601ad..152798e360 100644
--- a/drivers/common/cnxk/roc_platform_base_symbols.c
+++ b/drivers/common/cnxk/roc_platform_base_symbols.c
@@ -307,6 +307,7 @@ RTE_EXPORT_INTERNAL_SYMBOL(roc_nix_mac_link_info_set)
 RTE_EXPORT_INTERNAL_SYMBOL(roc_nix_mac_mtu_set)
 RTE_EXPORT_INTERNAL_SYMBOL(roc_nix_mac_max_rx_len_set)
 RTE_EXPORT_INTERNAL_SYMBOL(roc_nix_mac_stats_reset)
+RTE_EXPORT_INTERNAL_SYMBOL(roc_nix_mac_fwdata_get)
 RTE_EXPORT_INTERNAL_SYMBOL(roc_nix_mac_link_cb_register)
 RTE_EXPORT_INTERNAL_SYMBOL(roc_nix_mac_link_cb_unregister)
 RTE_EXPORT_INTERNAL_SYMBOL(roc_nix_mac_link_info_get_cb_register)
-- 
2.43.0


  reply	other threads:[~2025-06-05  9:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05  9:06 [PATCH 1/7] ethdev: add support to provide link type skori
2025-06-05  9:06 ` skori [this message]
2025-06-05  9:06 ` [PATCH 3/7] common/cnxk: provide port type from fwdata skori
2025-06-05  9:06 ` [PATCH 4/7] net/cnxk: get speed capability from firmware skori
2025-06-05  9:06 ` [PATCH 5/7] net/cnxk: support link mode configuration skori
2025-06-05  9:06 ` [PATCH 6/7] net/cnxk: report link type and status skori
2025-06-05  9:06 ` [PATCH 7/7] net/cnxk: report link mode skori
2025-06-05 15:22 ` [PATCH 1/7] ethdev: add support to provide link type Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250605090657.3032918-2-skori@marvell.com \
    --to=skori@marvell.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=skoteshwar@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).