Re: [PATCH v2 1/1] ethdev: add support to provide link type

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri, 6 Jun 2025 11:54:52 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:

> > From: skori@marvell.com [mailto:skori@marvell.com]
> > Sent: Friday, 6 June 2025 11.28
> > 
> > From: Sunil Kumar Kori <skori@marvell.com>
> > 
> > Adding link type parameter to provide the type
> > of port like twisted pair, fibre etc.
> > 
> > Also added an API to convert the RTE_ETH_LINK_TYPE_XXX
> > to a readable string.
> > 
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> > ---
> > +/**@{@name PORT type
> > + * Ethernet port type
> > + */
> > +#define RTE_ETH_LINK_TYPE_NONE  0x00 /**< Not defined */
> > +#define RTE_ETH_LINK_TYPE_TP    0x01 /**< Twisted Pair */
> > +#define RTE_ETH_LINK_TYPE_AUI   0x02 /**< Attachment Unit Interface */
> > +#define RTE_ETH_LINK_TYPE_MII   0x03 /**< Media Independent Interface
> > */
> > +#define RTE_ETH_LINK_TYPE_FIBRE 0x04 /**< Fibre */
> > +#define RTE_ETH_LINK_TYPE_BNC   0x05 /**< BNC */
> > +#define RTE_ETH_LINK_TYPE_DA    0x06 /**< Direct Attach copper */
> > +#define RTE_ETH_LINK_TYPE_OTHER 0x1F /**< Other type */
> > +/**@}*/  
> 
> I don't see the use case for this patch, when only ancient interface types are defined.
> How about RMII, GMII, RGMII, XGMII, XAUI, XAUI4, CAUI4, SFP, SFP+, SFP28, etc.
> 
> Please don't blindly port stuff from Linux to DPDK.
> 
> 

Agree with Morten here.
Plus, it isn't really much use to user unless all drivers report it.
Also, it breaks ABI (see build failures).