DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH] latencystats: make errors visible
Date: Tue, 15 Jul 2025 08:06:46 -0700	[thread overview]
Message-ID: <20250715150722.39575-1-stephen@networkplumber.org> (raw)

This is attempt to get more info from latencystats test failures.
When updating stats fails print message with ERR priority
so it is not hidden. When updating stats fails in the test
print the error code.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/test_latencystats.c        | 3 ++-
 lib/latencystats/rte_latencystats.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/test/test_latencystats.c b/app/test/test_latencystats.c
index 676a99d385..cdfc033b59 100644
--- a/app/test/test_latencystats.c
+++ b/app/test/test_latencystats.c
@@ -49,7 +49,8 @@ static int test_latency_update(void)
 	int ret = 0;
 
 	ret = rte_latencystats_update();
-	TEST_ASSERT(ret >= 0, "Test Failed: rte_latencystats_update failed");
+	TEST_ASSERT(ret >= 0, "Test Failed: rte_latencystats_update failed: %d (%s)",
+		    ret, strerror(-ret));
 
 	return TEST_SUCCESS;
 }
diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c
index f61d5a273f..1ce94fc5e5 100644
--- a/lib/latencystats/rte_latencystats.c
+++ b/lib/latencystats/rte_latencystats.c
@@ -129,7 +129,7 @@ rte_latencystats_update(void)
 					latency_stats_index,
 					values, NUM_LATENCY_STATS);
 	if (ret < 0)
-		LATENCY_STATS_LOG(INFO, "Failed to push the stats");
+		LATENCY_STATS_LOG(ERR, "Failed to push the stats");
 
 	return ret;
 }
-- 
2.47.2


                 reply	other threads:[~2025-07-15 15:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250715150722.39575-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).