From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Subject: [PATCH v4 18/22] net: fix IPv4 macro with highest bit
Date: Wed, 16 Jul 2025 15:02:05 +0200 [thread overview]
Message-ID: <20250716130212.1736407-19-david.marchand@redhat.com> (raw)
In-Reply-To: <20250716130212.1736407-1-david.marchand@redhat.com>
Without an explicit type, all parameters of this macro are considered as
a signed integer.
../app/test/test_fib.c:270:20: runtime error: left shift of
128 by 24 places cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../app/test/test_fib.c:270:20 in
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/net/rte_ip4.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/net/rte_ip4.h b/lib/net/rte_ip4.h
index d4b38c513c..822a660cfb 100644
--- a/lib/net/rte_ip4.h
+++ b/lib/net/rte_ip4.h
@@ -65,10 +65,8 @@ struct __rte_aligned(2) __rte_packed_begin rte_ipv4_hdr {
} __rte_packed_end;
/** Create IPv4 address */
-#define RTE_IPV4(a, b, c, d) ((uint32_t)(((a) & 0xff) << 24) | \
- (((b) & 0xff) << 16) | \
- (((c) & 0xff) << 8) | \
- ((d) & 0xff))
+#define RTE_IPV4(a, b, c, d) (((uint32_t)((a) & 0xff) << 24) | ((uint32_t)((b) & 0xff) << 16) | \
+ ((uint32_t)((c) & 0xff) << 8) | ((uint32_t)((d) & 0xff)))
/** Maximal IPv4 packet length (including a header) */
#define RTE_IPV4_MAX_PKT_LEN 65535
--
2.50.0
next prev parent reply other threads:[~2025-07-16 13:05 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 7:10 [PATCH 00/10] Run with UBSan in GHA David Marchand
2025-06-19 7:10 ` [PATCH 01/10] ci: save ccache on failure David Marchand
2025-06-25 12:16 ` Aaron Conole
2025-06-19 7:10 ` [PATCH 02/10] test/telemetry: fix test calling all commands David Marchand
2025-06-20 9:16 ` Bruce Richardson
2025-06-23 9:54 ` David Marchand
2025-06-19 7:10 ` [PATCH 03/10] test/mempool: fix test without stack driver David Marchand
2025-06-20 8:54 ` Andrew Rybchenko
2025-06-19 7:10 ` [PATCH 04/10] eal: fix plugin dir walk David Marchand
2025-06-20 9:19 ` Bruce Richardson
2025-06-23 9:41 ` David Marchand
2025-06-19 7:10 ` [PATCH 05/10] cmdline: fix port list parsing David Marchand
2025-06-20 9:58 ` Bruce Richardson
2025-06-23 9:40 ` David Marchand
2025-06-23 10:41 ` Bruce Richardson
2025-06-19 7:10 ` [PATCH 06/10] cmdline: fix highest bit " David Marchand
2025-06-20 9:21 ` Bruce Richardson
2025-06-23 9:32 ` David Marchand
2025-06-19 7:10 ` [PATCH 07/10] tailq: fix cast macro for null pointer David Marchand
2025-06-20 9:23 ` Bruce Richardson
2025-06-19 7:10 ` [PATCH 08/10] hash: fix unaligned access in predictable RSS David Marchand
2025-06-19 7:10 ` [PATCH 09/10] stack: fix unaligned accesses on 128-bit David Marchand
2025-06-19 7:10 ` [PATCH 10/10] build: support Undefined Behavior Sanitizer David Marchand
2025-06-25 12:17 ` Aaron Conole
2025-06-23 13:52 ` [PATCH v2 00/10] Run with UBSan in GHA David Marchand
2025-06-23 13:52 ` [PATCH v2 01/10] ci: save ccache on failure David Marchand
2025-06-23 13:52 ` [PATCH v2 02/10] test/telemetry: fix test calling all commands David Marchand
2025-06-24 15:59 ` Marat Khalili
2025-06-26 8:32 ` David Marchand
2025-06-26 9:51 ` Marat Khalili
2025-07-03 14:09 ` David Marchand
2025-07-03 15:08 ` Marat Khalili
2025-06-23 13:52 ` [PATCH v2 03/10] test/mempool: fix test without stack driver David Marchand
2025-06-24 16:21 ` Marat Khalili
2025-06-23 13:52 ` [PATCH v2 04/10] eal: fix plugin dir walk David Marchand
2025-06-25 8:43 ` Marat Khalili
2025-07-03 14:27 ` David Marchand
2025-06-23 13:52 ` [PATCH v2 05/10] cmdline: fix port list parsing David Marchand
2025-06-23 14:00 ` Bruce Richardson
2025-06-26 9:32 ` Marat Khalili
2025-06-23 13:52 ` [PATCH v2 06/10] cmdline: fix highest bit " David Marchand
2025-06-30 15:25 ` Marat Khalili
2025-06-23 13:52 ` [PATCH v2 07/10] tailq: fix cast macro for null pointer David Marchand
2025-06-30 16:06 ` Marat Khalili
2025-07-16 8:25 ` David Marchand
2025-06-23 13:52 ` [PATCH v2 08/10] hash: fix unaligned access in predictable RSS David Marchand
2025-06-30 15:32 ` Bruce Richardson
2025-07-01 8:36 ` Konstantin Ananyev
2025-07-08 7:32 ` David Marchand
2025-07-08 17:58 ` Konstantin Ananyev
2025-07-15 11:57 ` David Marchand
2025-07-15 13:32 ` Konstantin Ananyev
2025-07-15 14:54 ` David Marchand
2025-07-16 6:00 ` Mattias Rönnblom
2025-06-23 13:52 ` [PATCH v2 09/10] stack: fix unaligned accesses on 128-bit David Marchand
2025-06-30 15:33 ` Bruce Richardson
2025-06-23 13:52 ` [PATCH v2 10/10] build: support Undefined Behavior Sanitizer David Marchand
2025-07-08 12:28 ` [PATCH v3 00/18] Run with UBSan in GHA David Marchand
2025-07-08 12:28 ` [PATCH v3 01/18] ci: save ccache on failure David Marchand
2025-07-08 12:28 ` [PATCH v3 02/18] test/telemetry: fix test calling all commands David Marchand
2025-07-08 12:28 ` [PATCH v3 03/18] test/mempool: fix test without stack driver David Marchand
2025-07-08 15:15 ` Morten Brørup
2025-07-08 12:28 ` [PATCH v3 04/18] eal: fix plugin dir walk David Marchand
2025-07-08 12:28 ` [PATCH v3 05/18] cmdline: fix port list parsing David Marchand
2025-07-08 12:28 ` [PATCH v3 06/18] cmdline: fix highest bit " David Marchand
2025-07-08 12:28 ` [PATCH v3 07/18] tailq: fix cast macro for null pointer David Marchand
2025-07-08 12:28 ` [PATCH v3 08/18] hash: fix unaligned access in predictable RSS David Marchand
2025-07-08 12:35 ` Medvedkin, Vladimir
2025-07-08 12:28 ` [PATCH v3 09/18] stack: fix unaligned accesses on 128-bit David Marchand
2025-07-08 15:41 ` Morten Brørup
2025-07-09 8:23 ` Konstantin Ananyev
2025-07-08 12:28 ` [PATCH v3 10/18] build: support Undefined Behavior Sanitizer David Marchand
2025-07-11 12:19 ` Aaron Conole
2025-07-08 12:28 ` [PATCH v3 11/18] test/telemetry: catch errors in subshell David Marchand
2025-07-08 12:28 ` [PATCH v3 12/18] malloc: fix mp message alignment David Marchand
2025-07-08 12:44 ` Bruce Richardson
2025-07-08 12:46 ` David Marchand
2025-07-08 13:25 ` Bruce Richardson
2025-07-08 13:33 ` David Marchand
2025-07-08 12:28 ` [PATCH v3 13/18] graph: fix stats query with no node xstats David Marchand
2025-07-08 12:28 ` [PATCH v3 14/18] graph: fix unaligned access in stats David Marchand
2025-07-15 5:27 ` [EXTERNAL] " Kiran Kumar Kokkilagadda
2025-07-08 12:28 ` [PATCH v3 15/18] eventdev: fix listing timer adapters with telemetry David Marchand
2025-07-08 12:28 ` [PATCH v3 16/18] test/power: fix tests without power drivers David Marchand
2025-07-08 12:47 ` Bruce Richardson
2025-07-08 12:53 ` David Marchand
2025-07-08 13:26 ` Bruce Richardson
2025-07-08 12:28 ` [PATCH v3 17/18] test/raw: fix test without skeleton driver David Marchand
2025-07-08 12:48 ` Bruce Richardson
2025-07-08 12:28 ` [PATCH v3 18/18] ci: extend coverage with UBSan David Marchand
2025-07-16 13:01 ` [PATCH v4 00/22] Run with UBSan in GHA David Marchand
2025-07-16 13:01 ` [PATCH v4 01/22] ci: save ccache on failure David Marchand
2025-07-16 13:01 ` [PATCH v4 02/22] test/telemetry: fix test calling all commands David Marchand
2025-07-16 13:01 ` [PATCH v4 03/22] test/mempool: fix test without stack driver David Marchand
2025-07-16 13:01 ` [PATCH v4 04/22] eal: fix plugin dir walk David Marchand
2025-07-16 13:01 ` [PATCH v4 05/22] cmdline: fix port list parsing David Marchand
2025-07-16 13:01 ` [PATCH v4 06/22] cmdline: fix highest bit " David Marchand
2025-07-16 13:01 ` [PATCH v4 07/22] tailq: fix lookup macro David Marchand
2025-07-16 13:01 ` [PATCH v4 08/22] hash: fix unaligned access in predictable RSS David Marchand
2025-07-16 14:32 ` Konstantin Ananyev
2025-07-16 13:01 ` [PATCH v4 09/22] stack: fix unaligned accesses on 128-bit David Marchand
2025-07-16 13:01 ` [PATCH v4 10/22] build: support Undefined Behavior Sanitizer David Marchand
2025-07-16 13:01 ` [PATCH v4 11/22] test/telemetry: catch errors in subshell David Marchand
2025-07-16 13:01 ` [PATCH v4 12/22] ipc: fix mp message alignment for malloc David Marchand
2025-07-16 13:02 ` [PATCH v4 13/22] graph: fix stats query with no node xstats David Marchand
2025-07-16 13:02 ` [PATCH v4 14/22] graph: fix unaligned access in stats David Marchand
2025-07-16 13:02 ` [PATCH v4 15/22] eventdev: fix listing timer adapters with telemetry David Marchand
2025-07-16 13:02 ` [PATCH v4 16/22] test/power: fix tests without power drivers David Marchand
2025-07-16 13:02 ` [PATCH v4 17/22] test/raw: fix test without skeleton driver David Marchand
2025-07-16 13:02 ` David Marchand [this message]
2025-07-16 14:32 ` [PATCH v4 18/22] net: fix IPv4 macro with highest bit Konstantin Ananyev
2025-07-16 13:02 ` [PATCH v4 19/22] rib6: fix some highest bits handling David Marchand
2025-07-16 13:02 ` [PATCH v4 20/22] cfgfile: fix section count with no name David Marchand
2025-07-16 13:02 ` [PATCH v4 21/22] test/func_reentrancy: fix EAL init call David Marchand
2025-07-16 13:02 ` [PATCH v4 22/22] ci: extend coverage with UBSan David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716130212.1736407-19-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).