From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA6FD46BCF; Mon, 21 Jul 2025 17:09:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2965540687; Mon, 21 Jul 2025 17:09:16 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id D8D2C40661 for ; Mon, 21 Jul 2025 17:09:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753110555; x=1784646555; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3jqnjrBFuhuWA99pVBtQ8baOvnu1ti4Xkkteq6XhXxQ=; b=Ql2fkpoz/z3f//Yc6ygREc/6Q49MvnpkZfqdU2p1vz3Mj9P4nLd5hBFi cJQ5VOPDUkN5PEEQRY12WhHRGNg4Yux/ShOC3NvLbWOAyGadwtkeUKskC QyFQvy4Qz7M2vfr8iGOJCb/peAezSB68RgJjgC1MfpqcEB1eQCeNoLoOr LBdKzHlminSZ95rkgz8SM604sXNpkweESJKlqZyZjVDw52FZMnPNNgCc9 m1tqlm9qMzDy/rpoMpFYgzBnVb7aAJnKkalq9QL/gcllM7msLo5HbZ1+n xeIMs3gzGzWq2PNRK6y5e4XK/b4mkjE3+j/KXyR/bc/G5n8yP7j1+fBoV A==; X-CSE-ConnectionGUID: uusqmMNLT9KhSlEzB0kkMA== X-CSE-MsgGUID: iIPKD6sBRXyB/PX54ZwnPw== X-IronPort-AV: E=McAfee;i="6800,10657,11499"; a="55179780" X-IronPort-AV: E=Sophos;i="6.16,329,1744095600"; d="scan'208";a="55179780" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2025 08:09:14 -0700 X-CSE-ConnectionGUID: nXD6ShR8QxC4ObK+dTe7iw== X-CSE-MsgGUID: e7od5l8jSX+iJLuqWStX9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,329,1744095600"; d="scan'208";a="159291180" Received: from silpixa00401385.ir.intel.com ([10.237.214.33]) by orviesa008.jf.intel.com with ESMTP; 21 Jul 2025 08:09:13 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: david.marchand@redhat.com, Bruce Richardson , Tyler Retzlaff Subject: [PATCH v4 4/9] eal: add long options for each short option Date: Mon, 21 Jul 2025 16:08:37 +0100 Message-ID: <20250721150843.2737763-6-bruce.richardson@intel.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250520164025.2055721-1-bruce.richardson@intel.com> References: <20250520164025.2055721-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org To simplify future rework of the EAL arg handling, add a long-option equivalent for each short option that doesn't already have one. When updating the docs with the new long options, standardize the format of options which have both short and long variants, and drop the deprecated service-coremask option from the docs, rather than adding its new long option. Signed-off-by: Bruce Richardson --- doc/guides/linux_gsg/eal_args.include.rst | 20 ++++++++------------ lib/eal/common/eal_common_options.c | 9 +++++++++ lib/eal/common/eal_options.h | 16 ++++++++++++++++ 3 files changed, 33 insertions(+), 12 deletions(-) diff --git a/doc/guides/linux_gsg/eal_args.include.rst b/doc/guides/linux_gsg/eal_args.include.rst index 9ced54af40..0b17879d42 100644 --- a/doc/guides/linux_gsg/eal_args.include.rst +++ b/doc/guides/linux_gsg/eal_args.include.rst @@ -4,7 +4,7 @@ Lcore-related options ~~~~~~~~~~~~~~~~~~~~~ -* ``-l/--lcores `` +* ``-l, --lcores `` List of cores to run on @@ -71,11 +71,7 @@ Lcore-related options Core ID that is used as main. -* ``-s `` - - Hexadecimal bitmask of cores to be used as service cores. - -* ``-S `` +* ``-S, --service-corelist `` List of cores to be used as service cores. @@ -108,7 +104,7 @@ Device-related options --vdev 'net_pcap0,rx_pcap=input.pcap,tx_pcap=output.pcap' -* ``-d `` +* ``-d, --driver-path `` Load external drivers. An argument can be a single shared object file, or a directory containing multiple driver shared objects. Multiple -d options are @@ -134,15 +130,15 @@ Multiprocessing-related options Memory-related options ~~~~~~~~~~~~~~~~~~~~~~ -* ``-n `` +* ``-n, --memory-channels `` Set the number of memory channels to use. -* ``-r `` +* ``-r, --memory-ranks `` Set the number of memory ranks (auto-detected by default). -* ``-m `` +* ``-m, --memory-size `` Amount of memory to preallocate at startup. @@ -236,11 +232,11 @@ Debugging options Other options ~~~~~~~~~~~~~ -* ``-h``, ``--help`` +* ``-h, --help`` Display help message listing all EAL parameters. -* ``-v`` +* ``-v, --version`` Display the version information on startup. diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index f0a9ddeeb7..cafae9d9d7 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -66,7 +66,9 @@ eal_short_options[] = const struct option eal_long_options[] = { {OPT_BASE_VIRTADDR, 1, NULL, OPT_BASE_VIRTADDR_NUM }, + {OPT_COREMASK, 1, NULL, OPT_COREMASK_NUM }, {OPT_CREATE_UIO_DEV, 0, NULL, OPT_CREATE_UIO_DEV_NUM }, + {OPT_DRIVER_PATH, 1, NULL, OPT_DRIVER_PATH_NUM }, {OPT_FILE_PREFIX, 1, NULL, OPT_FILE_PREFIX_NUM }, {OPT_HELP, 0, NULL, OPT_HELP_NUM }, {OPT_HUGE_DIR, 1, NULL, OPT_HUGE_DIR_NUM }, @@ -76,6 +78,11 @@ eal_long_options[] = { {OPT_LOG_COLOR, 2, NULL, OPT_LOG_COLOR_NUM }, {OPT_LOG_LEVEL, 1, NULL, OPT_LOG_LEVEL_NUM }, {OPT_LOG_TIMESTAMP, 2, NULL, OPT_LOG_TIMESTAMP_NUM }, + {OPT_MEMORY_CHANNELS, 1, NULL, OPT_MEMORY_CHANNELS_NUM }, + {OPT_MEMORY_RANKS, 1, NULL, OPT_MEMORY_RANKS_NUM }, + {OPT_MEMORY_SIZE, 1, NULL, OPT_MEMORY_SIZE_NUM }, + {OPT_SERVICE_CORELIST, 1, NULL, OPT_SERVICE_CORELIST_NUM }, + {OPT_SERVICE_COREMASK, 1, NULL, OPT_SERVICE_COREMASK_NUM }, {OPT_TRACE, 1, NULL, OPT_TRACE_NUM }, {OPT_TRACE_DIR, 1, NULL, OPT_TRACE_DIR_NUM }, {OPT_TRACE_BUF_SIZE, 1, NULL, OPT_TRACE_BUF_SIZE_NUM }, @@ -109,6 +116,8 @@ eal_long_options[] = { {OPT_NO_TELEMETRY, 0, NULL, OPT_NO_TELEMETRY_NUM }, {OPT_FORCE_MAX_SIMD_BITWIDTH, 1, NULL, OPT_FORCE_MAX_SIMD_BITWIDTH_NUM}, {OPT_HUGE_WORKER_STACK, 2, NULL, OPT_HUGE_WORKER_STACK_NUM }, + {OPT_VERSION, 0, NULL, OPT_VERSION_NUM }, + {0, 0, NULL, 0 } }; diff --git a/lib/eal/common/eal_options.h b/lib/eal/common/eal_options.h index 7a56aa3810..6ef45559f0 100644 --- a/lib/eal/common/eal_options.h +++ b/lib/eal/common/eal_options.h @@ -17,8 +17,24 @@ enum { OPT_DEV_ALLOW_NUM = 'a', #define OPT_DEV_BLOCK "block" OPT_DEV_BLOCK_NUM = 'b', +#define OPT_COREMASK "coremask" + OPT_COREMASK_NUM = 'c', +#define OPT_DRIVER_PATH "driver-path" + OPT_DRIVER_PATH_NUM = 'd', #define OPT_LCORES "lcores" OPT_LCORES_NUM = 'l', +#define OPT_MEMORY_SIZE "memory-size" + OPT_MEMORY_SIZE_NUM = 'm', +#define OPT_MEMORY_CHANNELS "memory-channels" + OPT_MEMORY_CHANNELS_NUM = 'n', +#define OPT_MEMORY_RANKS "memory-ranks" + OPT_MEMORY_RANKS_NUM = 'r', +#define OPT_SERVICE_COREMASK "service-coremask" + OPT_SERVICE_COREMASK_NUM = 's', +#define OPT_SERVICE_CORELIST "service-corelist" + OPT_SERVICE_CORELIST_NUM = 'S', +#define OPT_VERSION "version" + OPT_VERSION_NUM = 'v', /* first long only option value must be >= 256, so that we won't * conflict with short options */ -- 2.48.1