From: Stephen Hemminger <stephen@networkplumber.org>
To: <skori@marvell.com>
Cc: Shepard Siegel <shepard.siegel@atomicrules.com>,
Ed Czeck <ed.czeck@atomicrules.com>,
John Miller <john.miller@atomicrules.com>,
"Igor Russkikh" <irusskikh@marvell.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
"Harman Kalra" <hkalra@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
"Sachin Saxena" <sachin.saxena@nxp.com>,
John Daley <johndale@cisco.com>,
"Hyong Youb Kim" <hyonkim@cisco.com>,
Jie Hai <haijie1@huawei.com>, Ian Stokes <ian.stokes@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Long Li <longli@microsoft.com>,
Wei Hu <weh@microsoft.com>,
Chaoyong He <chaoyong.he@corigine.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Jerin Jacob <jerinj@marvell.com>,
Maciej Czekaj <mczekaj@marvell.com>,
"Jian Wang" <jianwang@trustnetic.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbox@nvidia.com>,
Jochen Behrens <jochen.behrens@broadcom.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Ferruh Yigit" <ferruh.yigit@amd.com>, <dev@dpdk.org>
Subject: Re: [PATCH v2 1/2] ethdev: remove unnecessary type conversion
Date: Mon, 28 Jul 2025 21:28:30 -0700 [thread overview]
Message-ID: <20250728212830.172fba10@hermes.local> (raw)
In-Reply-To: <20250512150732.65743-1-skori@marvell.com>
On Mon, 12 May 2025 20:37:19 +0530
<skori@marvell.com> wrote:
> From: Sunil Kumar Kori <skori@marvell.com>
>
> As rte_eth_rx_queue_count() returns signed value to represent
> the error cases but internally invoked callback is returning
> unsigned value. Hence unnecessary type conversion is done.
>
> To avoid this typecasting from signed to unsigned, fixed
> return type of callback functions.
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> drivers/net/ark/ark_ethdev_rx.c | 2 +-
> drivers/net/ark/ark_ethdev_rx.h | 2 +-
> drivers/net/atlantic/atl_ethdev.h | 2 +-
> drivers/net/atlantic/atl_rxtx.c | 2 +-
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> drivers/net/cnxk/cnxk_ethdev.h | 2 +-
> drivers/net/cnxk/cnxk_ethdev_ops.c | 2 +-
> drivers/net/dpaa/dpaa_ethdev.c | 2 +-
> drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
> drivers/net/enic/enic_ethdev.c | 2 +-
> drivers/net/hns3/hns3_rxtx.c | 2 +-
> drivers/net/hns3/hns3_rxtx.h | 2 +-
> drivers/net/intel/e1000/e1000_ethdev.h | 4 ++--
> drivers/net/intel/e1000/em_rxtx.c | 2 +-
> drivers/net/intel/e1000/igb_rxtx.c | 2 +-
> drivers/net/intel/e1000/igc_txrx.c | 2 +-
> drivers/net/intel/e1000/igc_txrx.h | 2 +-
> drivers/net/intel/fm10k/fm10k.h | 2 +-
> drivers/net/intel/fm10k/fm10k_rxtx.c | 2 +-
> drivers/net/intel/i40e/i40e_rxtx.c | 2 +-
> drivers/net/intel/i40e/i40e_rxtx.h | 2 +-
> drivers/net/intel/iavf/iavf_rxtx.c | 2 +-
> drivers/net/intel/iavf/iavf_rxtx.h | 2 +-
> drivers/net/intel/ice/ice_rxtx.c | 2 +-
> drivers/net/intel/ice/ice_rxtx.h | 2 +-
> drivers/net/intel/ixgbe/ixgbe_ethdev.h | 2 +-
> drivers/net/intel/ixgbe/ixgbe_rxtx.c | 2 +-
> drivers/net/mlx5/mlx5_rx.c | 4 ++--
> drivers/net/mlx5/mlx5_rx.h | 2 +-
> drivers/net/netvsc/hn_rxtx.c | 2 +-
> drivers/net/netvsc/hn_var.h | 2 +-
> drivers/net/nfp/nfp_rxtx.c | 2 +-
> drivers/net/nfp/nfp_rxtx.h | 2 +-
> drivers/net/ngbe/ngbe_ethdev.h | 2 +-
> drivers/net/ngbe/ngbe_rxtx.c | 2 +-
> drivers/net/sfc/sfc_ethdev.c | 2 +-
> drivers/net/thunderx/nicvf_rxtx.c | 2 +-
> drivers/net/thunderx/nicvf_rxtx.h | 2 +-
> drivers/net/txgbe/txgbe_ethdev.h | 2 +-
> drivers/net/txgbe/txgbe_rxtx.c | 2 +-
> drivers/net/vhost/rte_eth_vhost.c | 2 +-
> drivers/net/vmxnet3/vmxnet3_ethdev.h | 2 +-
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 +-
> lib/ethdev/rte_ethdev.h | 2 +-
> lib/ethdev/rte_ethdev_core.h | 2 +-
> 45 files changed, 47 insertions(+), 47 deletions(-)
Was going to apply this for 25.11 (next-net).
But the Intel drivers got rearranged and no longer applies.
Would prefer that you rebase and resubmit, instead of me trying to patch a patch for this.
next prev parent reply other threads:[~2025-07-29 4:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 18:11 [PATCH] ethdev: remove callback checks from fast path skori
2025-04-29 23:55 ` Stephen Hemminger
2025-04-29 23:59 ` Stephen Hemminger
2025-04-30 7:26 ` Morten Brørup
2025-05-12 15:07 ` [PATCH v2 1/2] ethdev: remove unnecessary type conversion skori
2025-05-12 15:07 ` [PATCH v2 2/2] ethdev: remove callback checks from fast path skori
2025-05-12 16:12 ` Morten Brørup
2025-05-28 9:35 ` Morten Brørup
2025-06-10 5:11 ` Sunil Kumar Kori
2025-06-16 8:36 ` Sunil Kumar Kori
2025-06-16 14:30 ` Morten Brørup
2025-07-26 9:09 ` Andrew Rybchenko
2025-07-26 9:15 ` Andrew Rybchenko
2025-05-12 16:04 ` [PATCH v2 1/2] ethdev: remove unnecessary type conversion Morten Brørup
2025-07-26 8:44 ` Andrew Rybchenko
2025-05-27 15:07 ` Stephen Hemminger
2025-05-27 16:24 ` Morten Brørup
2025-05-28 8:17 ` Konstantin Ananyev
2025-05-28 8:23 ` Konstantin Ananyev
2025-05-28 8:48 ` Morten Brørup
2025-05-28 9:14 ` Konstantin Ananyev
2025-05-28 9:39 ` Morten Brørup
2025-07-29 4:28 ` Stephen Hemminger [this message]
2025-07-29 5:31 ` [EXTERNAL] " Sunil Kumar Kori
2025-05-26 12:30 ` [EXTERNAL] [PATCH] ethdev: remove callback checks from fast path Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250728212830.172fba10@hermes.local \
--to=stephen@networkplumber.org \
--cc=ajit.khaparde@broadcom.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bingz@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=chaoyong.he@corigine.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=ed.czeck@atomicrules.com \
--cc=ferruh.yigit@amd.com \
--cc=haijie1@huawei.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=hyonkim@cisco.com \
--cc=ian.stokes@intel.com \
--cc=irusskikh@marvell.com \
--cc=jerinj@marvell.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=jochen.behrens@broadcom.com \
--cc=john.miller@atomicrules.com \
--cc=johndale@cisco.com \
--cc=kirankumark@marvell.com \
--cc=longli@microsoft.com \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=mczekaj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=orika@nvidia.com \
--cc=sachin.saxena@nxp.com \
--cc=shepard.siegel@atomicrules.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=vladimir.medvedkin@intel.com \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).