DPDK patches and discussions
 help / color / mirror / Atom feed
From: Patrick Robb <probb@iol.unh.edu>
To: Luca.Vizzarro@arm.com
Cc: dev@dpdk.org, Patrick Robb <probb@iol.unh.edu>,
	Luca Vizzarro <luca.vizzarro@arm.com>
Subject: [PATCH v2] dts: call hugepages configure at node setup
Date: Mon, 28 Jul 2025 17:32:09 -0400	[thread overview]
Message-ID: <20250728213209.1834486-1-probb@iol.unh.edu> (raw)
In-Reply-To: <20250725200553.1262542-1-probb@iol.unh.edu>

The node class contains a configure hugepages method to be called
on the DTS nodes if the user has specified a hugepages config value
in their nodes configurations. However, the commit referenced below
removed the code path to this function, making it unreachable. If
the user has configured hugepages already via kernel parameters
this is harmless, but if they haven't, this bug will cause the DTS
execution to fail. This patch adds a call to the hugepages
configuration method at node setup.

Fixes: d77a4a27bd24 ("dts: remove node distinction")

Signed-off-by: Patrick Robb <probb@iol.unh.edu>
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
---
 dts/framework/testbed_model/node.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dts/framework/testbed_model/node.py b/dts/framework/testbed_model/node.py
index e6737cd173..7c5a35e0dd 100644
--- a/dts/framework/testbed_model/node.py
+++ b/dts/framework/testbed_model/node.py
@@ -76,6 +76,7 @@ def __init__(self, node_config: NodeConfiguration):
         self._logger = get_dts_logger(self.name)
         self.main_session = create_session(self.config, self.name, self._logger)
         self.arch = Architecture(self.main_session.get_arch_info())
+        self._setup_hugepages()
         self._logger.info(f"Connected to node: {self.name}")
         self._get_remote_cpus()
         self._other_sessions = []
-- 
2.49.0


  parent reply	other threads:[~2025-07-28 21:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-25 20:05 [PATCH] dts: call hugepages configure at testrun setup Patrick Robb
2025-07-28 11:31 ` Luca Vizzarro
2025-07-28 14:19   ` Patrick Robb
2025-07-28 21:32 ` Patrick Robb [this message]
2025-07-29  9:50   ` [PATCH v2] dts: call hugepages configure at node setup Luca Vizzarro
2025-07-29 13:20     ` Patrick Robb
2025-07-29 15:28       ` Patrick Robb
2025-07-29 16:29   ` Luca Vizzarro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250728213209.1834486-1-probb@iol.unh.edu \
    --to=probb@iol.unh.edu \
    --cc=Luca.Vizzarro@arm.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).