From: Stephen Hemminger <stephen@networkplumber.org>
To: Shivaji Kant <shivajikant@google.com>
Cc: Ivan Malov <ivan.malov@arknetworks.am>,
dev@dpdk.org, Ciara Loftus <ciara.loftus@intel.com>,
Maryam Tahhan <mtahhan@redhat.com>
Subject: Re: [PATCH v3] net/af_xdp: enable AF_XDP program attachment mode
Date: Tue, 29 Jul 2025 07:50:29 -0700 [thread overview]
Message-ID: <20250729075029.7fbf5468@hermes.local> (raw)
In-Reply-To: <20250729100845.819452-1-shivajikant@google.com>
On Tue, 29 Jul 2025 10:08:45 +0000
Shivaji Kant <shivajikant@google.com> wrote:
> @@ -2147,6 +2189,10 @@ parse_parameters(struct rte_kvargs *kvlist, char *if_name, int *start_queue,
>
> ret = rte_kvargs_process(kvlist, ETH_AF_XDP_DP_PATH_ARG,
> &parse_prog_arg, dp_path);
> +
> + ret = rte_kvargs_process(kvlist, ETH_AF_XDP_MODE_ARG,
> + &parse_mode_arg, xdp_mode);
> +
> if (ret < 0)
> goto free_kvlist;
You lost the check for invalid path argument return.
next prev parent reply other threads:[~2025-07-29 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 7:42 [PATCH] " Shivaji Kant
2025-07-23 12:30 ` Ivan Malov
2025-07-29 8:24 ` [PATCH v2] " Shivaji Kant
2025-07-29 10:08 ` [PATCH v3] " Shivaji Kant
2025-07-29 14:48 ` Stephen Hemminger
2025-07-29 14:50 ` Stephen Hemminger [this message]
2025-07-29 16:17 ` [PATCH v4] " Shivaji Kant
2025-07-29 22:10 ` Stephen Hemminger
2025-07-30 11:41 ` [PATCH v5] " Shivaji Kant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250729075029.7fbf5468@hermes.local \
--to=stephen@networkplumber.org \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@arknetworks.am \
--cc=mtahhan@redhat.com \
--cc=shivajikant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).