From: Shaiq Wani <shaiq.wani@intel.com>
To: dev@dpdk.org, bruce.richardson@intel.com, aman.deep.singh@intel.com
Cc: Jeff Shaw <jeffrey.b.shaw@intel.com>
Subject: [PATCH 1/2] net/ice: add flag for direction lookup to occur
Date: Thu, 31 Jul 2025 10:11:31 +0530 [thread overview]
Message-ID: <20250731044132.110174-2-shaiq.wani@intel.com> (raw)
In-Reply-To: <20250731044132.110174-1-shaiq.wani@intel.com>
The tx packets were dropped when creating drop any rule
for ingress direction only. Added a direction lookup flag
to fix the issue.
Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
---
drivers/net/intel/ice/base/ice_switch.c | 8 ++++----
drivers/net/intel/ice/ice_switch_filter.c | 2 ++
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/intel/ice/base/ice_switch.c b/drivers/net/intel/ice/base/ice_switch.c
index 777fc88d01..9b2c4536e0 100644
--- a/drivers/net/intel/ice/base/ice_switch.c
+++ b/drivers/net/intel/ice/base/ice_switch.c
@@ -8273,10 +8273,6 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
*/
ice_get_compat_fv_bitmap(hw, rinfo, fv_bitmap);
- status = ice_get_sw_fv_list(hw, lkup_exts, fv_bitmap, &rm->fv_list);
- if (status)
- goto err_unroll;
-
/* Create any special protocol/offset pairs, such as looking at tunnel
* bits by extracting metadata
*/
@@ -8284,6 +8280,10 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
if (status)
goto err_free_lkup_exts;
+ status = ice_get_sw_fv_list(hw, lkup_exts, fv_bitmap, &rm->fv_list);
+ if (status)
+ goto err_unroll;
+
/* Group match words into recipes using preferred recipe grouping
* criteria.
*/
diff --git a/drivers/net/intel/ice/ice_switch_filter.c b/drivers/net/intel/ice/ice_switch_filter.c
index 28bc775a2c..358387ad8f 100644
--- a/drivers/net/intel/ice/ice_switch_filter.c
+++ b/drivers/net/intel/ice/ice_switch_filter.c
@@ -1594,6 +1594,7 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
return -rte_errno;
case RTE_FLOW_ACTION_TYPE_DROP:
+ rule_info->add_dir_lkup = 1;
rule_info->sw_act.fltr_act = ICE_DROP_PACKET;
break;
@@ -1676,6 +1677,7 @@ ice_switch_parse_action(struct ice_pf *pf,
break;
case RTE_FLOW_ACTION_TYPE_DROP:
+ rule_info->add_dir_lkup = 1;
rule_info->sw_act.fltr_act =
ICE_DROP_PACKET;
break;
--
2.34.1
next prev parent reply other threads:[~2025-07-31 4:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 4:41 [PATCH 0/2] net/ice: fix drop rule handling and stats Shaiq Wani
2025-07-31 4:41 ` Shaiq Wani [this message]
2025-07-31 4:41 ` [PATCH 2/2] net/ice: count drop- all filter stats in Rx stats Shaiq Wani
2025-07-31 5:43 ` Ivan Malov
2025-07-31 6:03 ` Wani, Shaiq
2025-08-01 0:56 ` zhoumin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250731044132.110174-2-shaiq.wani@intel.com \
--to=shaiq.wani@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jeffrey.b.shaw@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).