[PATCH 0/2] net/ice: fix drop rule handling and stats

[PATCH 0/2] net/ice: fix drop rule handling and stats

[Shaiq Wani]

Patch 1.Tx packets were dropped when a drop-any rule was applied
        only on ingress. A direction lookup flag is added to resolve this.
Patch 2.Added accounting for Rx drop packets in ipackets and ibytes.

Shaiq Wani (2):
  net/ice: add flag for direction lookup to occur
  net/ice: count drop- all filter stats in Rx stats

 drivers/net/intel/ice/base/ice_switch.c   | 8 ++++----
 drivers/net/intel/ice/ice_ethdev.c        | 3 ++-
 drivers/net/intel/ice/ice_switch_filter.c | 2 ++
 3 files changed, 8 insertions(+), 5 deletions(-)

-- 
2.34.1

[PATCH 1/2] net/ice: add flag for direction lookup to occur

[Shaiq Wani]

The tx packets were dropped when creating drop any rule
for ingress direction only. Added a direction lookup flag
to fix the issue.

Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
---
 drivers/net/intel/ice/base/ice_switch.c   | 8 ++++----
 drivers/net/intel/ice/ice_switch_filter.c | 2 ++
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/net/intel/ice/base/ice_switch.c b/drivers/net/intel/ice/base/ice_switch.c
index 777fc88d01..9b2c4536e0 100644
--- a/drivers/net/intel/ice/base/ice_switch.c
+++ b/drivers/net/intel/ice/base/ice_switch.c
@@ -8273,10 +8273,6 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
 	 */
 	ice_get_compat_fv_bitmap(hw, rinfo, fv_bitmap);
 
-	status = ice_get_sw_fv_list(hw, lkup_exts, fv_bitmap, &rm->fv_list);
-	if (status)
-		goto err_unroll;
-
 	/* Create any special protocol/offset pairs, such as looking at tunnel
 	 * bits by extracting metadata
 	 */
@@ -8284,6 +8280,10 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
 	if (status)
 		goto err_free_lkup_exts;
 
+	status = ice_get_sw_fv_list(hw, lkup_exts, fv_bitmap, &rm->fv_list);
+	if (status)
+		goto err_unroll;
+
 	/* Group match words into recipes using preferred recipe grouping
 	 * criteria.
 	 */
diff --git a/drivers/net/intel/ice/ice_switch_filter.c b/drivers/net/intel/ice/ice_switch_filter.c
index 28bc775a2c..358387ad8f 100644
--- a/drivers/net/intel/ice/ice_switch_filter.c
+++ b/drivers/net/intel/ice/ice_switch_filter.c
@@ -1594,6 +1594,7 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
 			return -rte_errno;
 
 		case RTE_FLOW_ACTION_TYPE_DROP:
+			rule_info->add_dir_lkup = 1;
 			rule_info->sw_act.fltr_act = ICE_DROP_PACKET;
 			break;
 
@@ -1676,6 +1677,7 @@ ice_switch_parse_action(struct ice_pf *pf,
 			break;
 
 		case RTE_FLOW_ACTION_TYPE_DROP:
+			rule_info->add_dir_lkup = 1;
 			rule_info->sw_act.fltr_act =
 				ICE_DROP_PACKET;
 			break;
-- 
2.34.1

[PATCH 2/2] net/ice: count drop- all filter stats in Rx stats

[Shaiq Wani]

Packets dropped in the receive direction are counted as
"rx_unknown_protocol" (GLSWID_RUPP),these packets need to be added
to the "ipackets" and the GLV_GORCH/GLV_GORCL counters
need to be added to rx_bytes.

Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
---
 drivers/net/intel/ice/ice_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
index 513777e372..0ebe58f858 100644
--- a/drivers/net/intel/ice/ice_ethdev.c
+++ b/drivers/net/intel/ice/ice_ethdev.c
@@ -6383,12 +6383,13 @@ ice_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 
 	stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
 			  pf->main_vsi->eth_stats.rx_multicast +
+			  ns->eth.rx_unknown_protocol +
 			  pf->main_vsi->eth_stats.rx_broadcast -
 			  pf->main_vsi->eth_stats.rx_discards;
 	stats->opackets = ns->eth.tx_unicast +
 			  ns->eth.tx_multicast +
 			  ns->eth.tx_broadcast;
-	stats->ibytes   = pf->main_vsi->eth_stats.rx_bytes;
+	stats->ibytes   = ns->eth.rx_bytes;
 	stats->obytes   = ns->eth.tx_bytes;
 	stats->oerrors  = ns->eth.tx_errors +
 			  pf->main_vsi->eth_stats.tx_errors;
-- 
2.34.1

Re: [PATCH 2/2] net/ice: count drop- all filter stats in Rx stats

[Ivan Malov]

Hi,

On Thu, 31 Jul 2025, Shaiq Wani wrote:

> Packets dropped in the receive direction are counted as
> "rx_unknown_protocol" (GLSWID_RUPP),these packets need to be added
> to the "ipackets" and the GLV_GORCH/GLV_GORCL counters
> need to be added to rx_bytes.
>
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
> drivers/net/intel/ice/ice_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
> index 513777e372..0ebe58f858 100644
> --- a/drivers/net/intel/ice/ice_ethdev.c
> +++ b/drivers/net/intel/ice/ice_ethdev.c
> @@ -6383,12 +6383,13 @@ ice_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
>
> 	stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
> 			  pf->main_vsi->eth_stats.rx_multicast +
> +			  ns->eth.rx_unknown_protocol +

I may be wrong, but shan't drops and discards contribute to 'imissed' instead?
According to [1], 'ipackets' is 'Total number of successfully received packets',
and per-queue version of 'ipackets' also exists, hinting at the host Rx nature.

[1] https://doc.dpdk.org/api-25.07/structrte__eth__stats.html#ac14b69830000494630c8897b70c5fc54

And if, say, they contribute to 'imissed', then no update to the 'ibytes'?
Please correct me if I'm wrong, -- I really prefer just to clarify this.

Thank you.

> 			  pf->main_vsi->eth_stats.rx_broadcast -
> 			  pf->main_vsi->eth_stats.rx_discards;
> 	stats->opackets = ns->eth.tx_unicast +
> 			  ns->eth.tx_multicast +
> 			  ns->eth.tx_broadcast;
> -	stats->ibytes   = pf->main_vsi->eth_stats.rx_bytes;
> +	stats->ibytes   = ns->eth.rx_bytes;
> 	stats->obytes   = ns->eth.tx_bytes;
> 	stats->oerrors  = ns->eth.tx_errors +
> 			  pf->main_vsi->eth_stats.tx_errors;
> -- 
> 2.34.1
>
>

RE: [PATCH 2/2] net/ice: count drop- all filter stats in Rx stats

[Wani, Shaiq]

-----Original Message-----
From: Ivan Malov <ivan.malov@arknetworks.am> 
Sent: Thursday, July 31, 2025 11:14 AM
To: Wani, Shaiq <shaiq.wani@intel.com>
Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Singh, Aman Deep <aman.deep.singh@intel.com>; Shaw, Jeffrey B <jeffrey.b.shaw@intel.com>
Subject: Re: [PATCH 2/2] net/ice: count drop- all filter stats in Rx stats

Hi,

On Thu, 31 Jul 2025, Shaiq Wani wrote:

> Packets dropped in the receive direction are counted as 
> "rx_unknown_protocol" (GLSWID_RUPP),these packets need to be added to 
> the "ipackets" and the GLV_GORCH/GLV_GORCL counters need to be added 
> to rx_bytes.
>
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
> drivers/net/intel/ice/ice_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/intel/ice/ice_ethdev.c 
> b/drivers/net/intel/ice/ice_ethdev.c
> index 513777e372..0ebe58f858 100644
> --- a/drivers/net/intel/ice/ice_ethdev.c
> +++ b/drivers/net/intel/ice/ice_ethdev.c
> @@ -6383,12 +6383,13 @@ ice_stats_get(struct rte_eth_dev *dev, struct 
> rte_eth_stats *stats)
>
> 	stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
> 			  pf->main_vsi->eth_stats.rx_multicast +
> +			  ns->eth.rx_unknown_protocol +

I may be wrong, but shan't drops and discards contribute to 'imissed' instead?
According to [1], 'ipackets' is 'Total number of successfully received packets', and per-queue version of 'ipackets' also exists, hinting at the host Rx nature.

[1] https://doc.dpdk.org/api-25.07/structrte__eth__stats.html#ac14b69830000494630c8897b70c5fc54

And if, say, they contribute to 'imissed', then no update to the 'ibytes'?
Please correct me if I'm wrong, -- I really prefer just to clarify this.

Thank you.

Hi,

To clarify - the packets we're accounting for were dropped intentionally due to user-defined "drop" rules (intentional) not due to errors.
Since the drop is deliberate, not due to resource issues or errors, we account them in ipackets and ibytes, not imissed.

Thanks.


> 			  pf->main_vsi->eth_stats.rx_broadcast -
> 			  pf->main_vsi->eth_stats.rx_discards;
> 	stats->opackets = ns->eth.tx_unicast +
> 			  ns->eth.tx_multicast +
> 			  ns->eth.tx_broadcast;
> -	stats->ibytes   = pf->main_vsi->eth_stats.rx_bytes;
> +	stats->ibytes   = ns->eth.rx_bytes;
> 	stats->obytes   = ns->eth.tx_bytes;
> 	stats->oerrors  = ns->eth.tx_errors +
> 			  pf->main_vsi->eth_stats.tx_errors;
> --
> 2.34.1
>
>