DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: stephen@networkplumber.org, andremue@linux.microsoft.com,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH v4 0/4] improve cmdline file handling in testpmd
Date: Thu, 31 Jul 2025 16:00:37 +0000	[thread overview]
Message-ID: <20250731160041.914837-1-bruce.richardson@intel.com> (raw)
In-Reply-To: <20250704140551.4151993-1-bruce.richardson@intel.com>

Some small improvements to cmdline file handling testpmd, inspired by the
desire to have support for multiple cmdline files passed on the commandline
of a testpmd run.

The implementation is somewhat complicated by the setting for echo/noecho
of the commands, because the current implementation uses a global flag for
that - shared between cmdline parameters and interactive CLI commands.

The final complication/addition, is the need for a common basename function
across our supported OS's. This is provided by the rte_basename function in
patch 1.

V4:
* remove ifdefs in testpmd code, by providing common rte_basename fn

V3:
* Fix windows support, no libgen or basename, no asprintf...

V2:
* remove global echo flag, and now support echo/noecho per file loaded
* when echoing, output the file being processed, to clarify things when
  loading multiple files.


Bruce Richardson (4):
  eal: add basename function for common path manipulation
  app/testpmd: explicitly set command echoing on file load
  app/testpmd: allow multiple commandline file parameters
  app/testpmd: improve output when processing cmdline files

 app/test-pmd/cmdline.c                      |  69 ++++++++++--
 app/test-pmd/parameters.c                   |  17 +--
 app/test-pmd/testpmd.c                      |  13 ++-
 app/test-pmd/testpmd.h                      |  15 ++-
 app/test/test_string_fns.c                  | 111 ++++++++++++++++++++
 doc/guides/testpmd_app_ug/run_app.rst       |   3 +-
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  12 +--
 lib/eal/include/rte_string_fns.h            |  32 ++++++
 lib/eal/unix/meson.build                    |   1 +
 lib/eal/unix/rte_basename.c                 |  37 +++++++
 lib/eal/windows/meson.build                 |   1 +
 lib/eal/windows/rte_basename.c              |  53 ++++++++++
 12 files changed, 336 insertions(+), 28 deletions(-)
 create mode 100644 lib/eal/unix/rte_basename.c
 create mode 100644 lib/eal/windows/rte_basename.c

-- 
2.48.1


  parent reply	other threads:[~2025-07-31 16:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04 14:05 [PATCH] app/testpmd: allow multiple cmdline-file parameters Bruce Richardson
2025-07-04 18:34 ` [PATCH v2 0/3] improve cmdline file handling in testpmd Bruce Richardson
2025-07-04 18:34   ` [PATCH v2 1/3] app/testpmd: explicitly set command echoing on file load Bruce Richardson
2025-07-04 18:34   ` [PATCH v2 2/3] app/testpmd: allow multiple commandline file parameters Bruce Richardson
2025-07-04 18:34   ` [PATCH v2 3/3] app/testpmd: improve output when processing cmdline files Bruce Richardson
2025-07-07 11:17 ` [PATCH v3 0/3] improve cmdline file handling in testpmd Bruce Richardson
2025-07-07 11:17   ` [PATCH v3 1/3] app/testpmd: explicitly set command echoing on file load Bruce Richardson
2025-07-07 11:17   ` [PATCH v3 2/3] app/testpmd: allow multiple commandline file parameters Bruce Richardson
2025-07-07 11:17   ` [PATCH v3 3/3] app/testpmd: improve output when processing cmdline files Bruce Richardson
2025-07-29  4:24     ` Stephen Hemminger
2025-07-31 16:00 ` Bruce Richardson [this message]
2025-07-31 16:00   ` [PATCH v4 1/4] eal: add basename function for common path manipulation Bruce Richardson
2025-08-01 14:25     ` Andre Muezerie
2025-08-01 21:56     ` Stephen Hemminger
2025-07-31 16:00   ` [PATCH v4 2/4] app/testpmd: explicitly set command echoing on file load Bruce Richardson
2025-07-31 16:00   ` [PATCH v4 3/4] app/testpmd: allow multiple commandline file parameters Bruce Richardson
2025-07-31 16:00   ` [PATCH v4 4/4] app/testpmd: improve output when processing cmdline files Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250731160041.914837-1-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=andremue@linux.microsoft.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).