From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Peter Spreadborough <peter.spreadborough@broadcom.com>,
Farah Smith <farah.smith@broadcom.com>,
Jay Ding <jay.ding@broadcom.com>,
Shahaji Bhosle <sbhosle@broadcom.com>
Subject: Re: [PATCH] net/bnxt: fix free of not allocated object
Date: Sat, 2 Aug 2025 09:03:03 -0700 [thread overview]
Message-ID: <20250802090303.3f76b97e@hermes.local> (raw)
In-Reply-To: <20250521193727.382342-1-stephen@networkplumber.org>
On Wed, 21 May 2025 12:37:27 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> This was found as error when compiling with LTO.
> The function allocates new data with rte_zmalloc and then
> stores pointer in the pointer-to-pointer passed as argument.
> In the unwind case, it would call rte_free() with wrong one.
>
> Fixes: 80317ff6adfd ("net/bnxt/tf_core: support Thor2")
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Ping. This fixes a real bug why is it being ignored?
In function ‘tfo_open’,
inlined from ‘tfc_open’ at ../drivers/net/bnxt/tf_core/v3/tfc_init.c:34:2,
inlined from ‘ulp_tfc_ctx_attach’ at ../drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c:783:7:
../drivers/net/bnxt/tf_core/v3/tfo.c:108:17: warning: ‘rte_free’ called on pointer ‘bp_44(D)’ with nonzero offset 800 [-Wfree-nonheap-object]
108 | rte_free(tfo);
| ^
In function ‘tfo_open’,
inlined from ‘tfc_open’ at ../drivers/net/bnxt/tf_core/v3/tfc_init.c:34:2,
inlined from ‘ulp_tfc_init’ at ../drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c:957:7:
../drivers/net/bnxt/tf_core/v3/tfo.c:108:17: warning: ‘rte_free’ called on pointer ‘bp_74(D)’ with nonzero offset 800 [-Wfree-nonheap-object]
108 | rte_free(tfo);
| ^
prev parent reply other threads:[~2025-08-02 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 19:37 Stephen Hemminger
2025-06-17 13:51 ` Stephen Hemminger
2025-08-02 16:03 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250802090303.3f76b97e@hermes.local \
--to=stephen@networkplumber.org \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=farah.smith@broadcom.com \
--cc=jay.ding@broadcom.com \
--cc=peter.spreadborough@broadcom.com \
--cc=sbhosle@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).