From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0E9946C9C; Sun, 3 Aug 2025 21:42:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A5214026C; Sun, 3 Aug 2025 21:42:29 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id D137E400D5 for ; Sun, 3 Aug 2025 21:42:27 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 1661920CE7; Sun, 3 Aug 2025 21:42:27 +0200 (CEST) Received: from dkrd4.smartsharesys.local ([192.168.4.26]) by smartserver.smartsharesystems.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 3 Aug 2025 21:42:26 +0200 From: =?UTF-8?q?Morten=20Br=C3=B8rup?= To: dev@dpdk.org, Aman Singh , Thomas Monjalon , Andrew Rybchenko , Ivan Malov , Stephen Hemminger Cc: Konstantin Ananyev , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson Subject: [PATCH v3 3/3] ethdev: Reject conflicting TX offloads configuration Date: Sun, 3 Aug 2025 19:42:18 +0000 Message-ID: <20250803194218.683318-3-mb@smartsharesystems.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250803194218.683318-1-mb@smartsharesystems.com> References: <20250731090731.671589-1-mb@smartsharesystems.com> <20250803194218.683318-1-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 03 Aug 2025 19:42:26.0794 (UTC) FILETIME=[BDB664A0:01DC04AE] X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When an ethdev port is configured for fast mbuf release, the driver can use a TX burst function relying on the fast mbuf release preconditions. Thus, also configuring this port or a queue on the port for transmitting segmented packets is prohibited. Checks for these conflicting configurations have been added to the ethdev library, so the drivers don't have to implement them. Signed-off-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko Acked-by: Konstantin Ananyev --- v3: * Shorten the added log messages. (Stephen Hemminger, Ivan Malov) --- lib/ethdev/rte_ethdev.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index dd7c00bc94..00afda873f 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -1531,6 +1531,18 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, goto rollback; } + /* MBUF_FAST_FREE preconditions conflict with MULTI_SEGS support. */ + if ((dev_conf->txmode.offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) && + (dev_conf->txmode.offloads & RTE_ETH_TX_OFFLOAD_MULTI_SEGS)) { + RTE_ETHDEV_LOG_LINE(ERR, + "id=%d offload clash, %s vs %s", + port_id, + rte_eth_dev_tx_offload_name(RTE_ETH_TX_OFFLOAD_MULTI_SEGS), + rte_eth_dev_tx_offload_name(RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE)); + ret = -EINVAL; + goto rollback; + } + dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf = rte_eth_rss_hf_refine(dev_conf->rx_adv_conf.rss_conf.rss_hf); @@ -2709,6 +2721,31 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id, return -EINVAL; } + /* + * If the driver uses a Tx function with MBUF_FAST_FREE preconditions, + * per-queue MULTI_SEGS support is not possible. + */ + if ((dev->data->dev_conf.txmode.offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) && + (local_conf.offloads & RTE_ETH_TX_OFFLOAD_MULTI_SEGS)) { + RTE_ETHDEV_LOG_LINE(ERR, + "id=%d txq=%d offload clash, per-queue %s vs per-port %s", + port_id, tx_queue_id, + rte_eth_dev_tx_offload_name(RTE_ETH_TX_OFFLOAD_MULTI_SEGS), + rte_eth_dev_tx_offload_name(RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE)); + return -EINVAL; + } + /* + * If the driver uses a Tx function with MULTI_SEGS support, + * runtime support for per-queue MBUF_FAST_FREE optimization depends on the driver. + */ + if ((dev->data->dev_conf.txmode.offloads & RTE_ETH_TX_OFFLOAD_MULTI_SEGS) && + (local_conf.offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE)) + RTE_ETHDEV_LOG_LINE(DEBUG, + "id=%d txq=%d potential offload clash, per-queue %s vs per-port %s: PMD to decide", + port_id, tx_queue_id, + rte_eth_dev_tx_offload_name(RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE), + rte_eth_dev_tx_offload_name(RTE_ETH_TX_OFFLOAD_MULTI_SEGS)); + rte_ethdev_trace_txq_setup(port_id, tx_queue_id, nb_tx_desc, tx_conf); return eth_err(port_id, dev->dev_ops->tx_queue_setup(dev, tx_queue_id, nb_tx_desc, socket_id, &local_conf)); -- 2.43.0