DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ciara Loftus <ciara.loftus@intel.com>
To: dev@dpdk.org
Cc: Ciara Loftus <ciara.loftus@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH v3 09/15] net/iavf: remove redundant field from iavf adapter struct
Date: Mon, 18 Aug 2025 10:59:08 +0000	[thread overview]
Message-ID: <20250818105914.169732-10-ciara.loftus@intel.com> (raw)
In-Reply-To: <20250818105914.169732-1-ciara.loftus@intel.com>

The variable rx_vec_allowed was only used in one function, so
it's not necessary to have it part of the iavf_adapter structure.

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/intel/iavf/iavf.h        | 1 -
 drivers/net/intel/iavf/iavf_ethdev.c | 1 -
 drivers/net/intel/iavf/iavf_rxtx.c   | 6 ++----
 3 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/net/intel/iavf/iavf.h b/drivers/net/intel/iavf/iavf.h
index dacfb92d5f..69f9abbef3 100644
--- a/drivers/net/intel/iavf/iavf.h
+++ b/drivers/net/intel/iavf/iavf.h
@@ -375,7 +375,6 @@ struct iavf_adapter {
 
 	bool rx_bulk_alloc_allowed;
 	/* For vector PMD */
-	bool rx_vec_allowed;
 	bool tx_vec_allowed;
 	alignas(RTE_CACHE_LINE_MIN_SIZE) uint32_t ptype_tbl[IAVF_MAX_PKT_TYPE];
 	bool stopped;
diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c
index 335a8126c4..33b00e8ae4 100644
--- a/drivers/net/intel/iavf/iavf_ethdev.c
+++ b/drivers/net/intel/iavf/iavf_ethdev.c
@@ -668,7 +668,6 @@ iavf_dev_configure(struct rte_eth_dev *dev)
 	/* Initialize to TRUE. If any of Rx queues doesn't meet the
 	 * vector Rx/Tx preconditions, it will be reset.
 	 */
-	ad->rx_vec_allowed = true;
 	ad->tx_vec_allowed = true;
 
 	if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG)
diff --git a/drivers/net/intel/iavf/iavf_rxtx.c b/drivers/net/intel/iavf/iavf_rxtx.c
index e36a07d5ac..367dde89ca 100644
--- a/drivers/net/intel/iavf/iavf_rxtx.c
+++ b/drivers/net/intel/iavf/iavf_rxtx.c
@@ -725,12 +725,10 @@ iavf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
 		ad->rx_bulk_alloc_allowed = false;
 	}
 
-	if (!ci_rxq_vec_capable(rxq->nb_rx_desc, rxq->rx_free_thresh, rxq->offloads))
-		ad->rx_vec_allowed = false;
-
 #if defined RTE_ARCH_X86 || defined RTE_ARCH_ARM
 	/* check vector conflict */
-	if (ad->rx_vec_allowed && iavf_rxq_vec_setup(rxq)) {
+	if (ci_rxq_vec_capable(rxq->nb_rx_desc, rxq->rx_free_thresh, rxq->offloads) &&
+			iavf_rxq_vec_setup(rxq)) {
 		PMD_DRV_LOG(ERR, "Failed vector rx setup.");
 		return -EINVAL;
 	}
-- 
2.34.1


  parent reply	other threads:[~2025-08-18 11:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 10:58 [PATCH v3 00/15] net/intel: rx path selection simplification Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 01/15] net/ice: use the same Rx path across process types Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 02/15] net/iavf: rename Rx/Tx function type variables Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 03/15] net/iavf: use the same Rx path across process types Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 04/15] net/i40e: " Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 05/15] net/intel: introduce common vector capability function Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 06/15] net/ice: use the new " Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 07/15] net/iavf: " Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 08/15] net/i40e: " Ciara Loftus
2025-08-18 10:59 ` Ciara Loftus [this message]
2025-08-18 10:59 ` [PATCH v3 10/15] net/ice: remove unsupported Rx offload Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 11/15] net/iavf: reorder enum of Rx function types Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 12/15] net/intel: introduce infrastructure for Rx path selection Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 13/15] net/ice: use the common Rx path selection infrastructure Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 14/15] net/iavf: " Ciara Loftus
2025-08-18 10:59 ` [PATCH v3 15/15] net/i40e: " Ciara Loftus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250818105914.169732-10-ciara.loftus@intel.com \
    --to=ciara.loftus@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).