DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v4 0/9] avoid unnecessary use of commaa operator
Date: Mon, 18 Aug 2025 09:18:05 -0700	[thread overview]
Message-ID: <20250818161815.23611-1-stephen@networkplumber.org> (raw)
In-Reply-To: <20250312232739.228295-1-stephen@networkplumber.org>

Clang has ability to detect suspicious use of comma operator
where a semicolon would have the same effect.
Easy enough to fix in DPDK code.

v4 - review feedback about consolidating assignments
     fix Broadcom drivers (Intel and Nvidia still have warnings)

Stephen Hemminger (9):
  eal: replace unnecessary comma operator
  ipsec: replace unnecessary comma operator
  graph: replace unnecessary comma operator
  test: replace unnecessary comma operators
  app/testpmd: replace comma operator with bracket
  examples: remove unnecessary use of comma operator
  net/bnx2x: remove unnecessary comma operator
  net/bnxt: remove unnecessary use of comma operator
  config: enable comma warnings

 app/test-pmd/cmdline_flow.c                |  6 ++++--
 app/test-pmd/config.c                      | 10 ++++++----
 app/test/test_compressdev.c                |  4 ++--
 app/test/test_link_bonding_rssconf.c       |  2 +-
 app/test/test_thash.c                      |  7 +++----
 config/meson.build                         |  1 +
 drivers/meson.build                        |  2 +-
 drivers/net/bnx2x/bnx2x.c                  |  4 ++--
 drivers/net/bnxt/tf_core/tf_msg.c          |  4 ++--
 examples/l2fwd-event/l2fwd_event_generic.c |  2 +-
 examples/l3fwd/l3fwd_event_generic.c       |  2 +-
 lib/eal/common/rte_malloc.c                |  4 ++--
 lib/eal/linux/eal_alarm.c                  |  6 ++++--
 lib/graph/graph_stats.c                    |  2 +-
 lib/ipsec/misc.h                           |  8 +++-----
 15 files changed, 34 insertions(+), 30 deletions(-)

--
2.47.2

  parent reply	other threads:[~2025-08-18 16:18 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 23:26 [RFC 0/7] avoid unnecessary use of comma op Stephen Hemminger
2025-03-12 23:26 ` [RFC 1/7] eal: replace unnecessary comma operator Stephen Hemminger
2025-03-12 23:26 ` [RFC 2/7] ipsec: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 3/7] graph: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 4/7] net/mlx4: replace unnecessary comma operators Stephen Hemminger
2025-03-12 23:27 ` [RFC 5/7] net/mlx5: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 6/7] test: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 7/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 0/6] Enable warnings about use of comma operator Stephen Hemminger
2025-08-14 21:28   ` [PATCH v2 1/6] eal: replace unnecessary " Stephen Hemminger
2025-08-15 13:48     ` Konstantin Ananyev
2025-08-18  7:59     ` Bruce Richardson
2025-08-14 21:28   ` [PATCH v2 2/6] ipsec: " Stephen Hemminger
2025-08-15 13:47     ` Konstantin Ananyev
2025-08-18  8:00     ` Bruce Richardson
2025-08-18  8:14       ` Morten Brørup
2025-08-14 21:28   ` [PATCH v2 3/6] graph: " Stephen Hemminger
2025-08-15 13:49     ` Konstantin Ananyev
2025-08-18  8:01     ` Bruce Richardson
2025-08-14 21:28   ` [PATCH v2 4/6] test: replace unnecessary comma operators Stephen Hemminger
2025-08-15 13:50     ` Konstantin Ananyev
2025-08-18  8:02     ` Bruce Richardson
2025-08-14 21:28   ` [PATCH v2 5/6] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-18  8:05     ` Bruce Richardson
2025-08-14 21:28   ` [PATCH v2 6/6] config: enable comma warnings Stephen Hemminger
2025-08-15 14:00     ` Konstantin Ananyev
2025-08-15  0:30   ` [PATCH v2 0/6] Enable warnings about use of comma operator fengchengwen
2025-08-15  6:40   ` Morten Brørup
2025-08-15 16:15     ` Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 0/7] avoid unnecessary " Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 1/7] eal: replace unnecessary " Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 2/7] ipsec: " Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 3/7] graph: " Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 4/7] test: replace unnecessary comma operators Stephen Hemminger
2025-08-16  7:37     ` Morten Brørup
2025-08-15 16:26   ` [PATCH v3 5/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 6/7] examples: remove unnecessary use of comma operator Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 7/7] config: enable comma warnings Stephen Hemminger
2025-08-16  7:45   ` [PATCH v3 0/7] avoid unnecessary use of comma operator Morten Brørup
2025-08-18 16:18 ` Stephen Hemminger [this message]
2025-08-18 16:18   ` [PATCH v4 1/9] eal: replace unnecessary " Stephen Hemminger
2025-08-18 16:18   ` [PATCH v4 2/9] ipsec: " Stephen Hemminger
2025-08-18 16:32     ` Bruce Richardson
2025-08-18 16:34     ` Bruce Richardson
2025-08-18 16:18   ` [PATCH v4 3/9] graph: " Stephen Hemminger
2025-08-18 16:18   ` [PATCH v4 4/9] test: replace unnecessary comma operators Stephen Hemminger
2025-08-18 16:18   ` [PATCH v4 5/9] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-18 16:18   ` [PATCH v4 6/9] examples: remove unnecessary use of comma operator Stephen Hemminger
2025-08-18 16:18   ` [PATCH v4 7/9] net/bnx2x: remove unnecessary " Stephen Hemminger
2025-08-18 16:18   ` [PATCH v4 8/9] net/bnxt: remove unnecessary use of " Stephen Hemminger
2025-08-18 16:18   ` [PATCH v4 9/9] config: enable comma warnings Stephen Hemminger
2025-08-18 16:36     ` Bruce Richardson
2025-08-18 17:15       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250818161815.23611-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).