[PATCH] ethdev: hide internal ethtool symbol

[PATCH] ethdev: hide internal ethtool symbol

[David Marchand]

No code call this symbol out of ethdev, remove it from exported symbols
and rename it.

Note: there is nothing particularly wrong with exporting this symbol.
It is just unneeded, and this symbol referencing a linux kernel enum
triggers a abidiff warning in the RHEL CI when this enum gets updated.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/ethdev/ethdev_linux_ethtool.c | 7 +++----
 lib/ethdev/ethdev_linux_ethtool.h | 6 ------
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/lib/ethdev/ethdev_linux_ethtool.c b/lib/ethdev/ethdev_linux_ethtool.c
index 5eddda1da3..e989ddfbf2 100644
--- a/lib/ethdev/ethdev_linux_ethtool.c
+++ b/lib/ethdev/ethdev_linux_ethtool.c
@@ -133,9 +133,8 @@ static const uint32_t link_modes[] = {
 	[120] =  800000, /* ETHTOOL_LINK_MODE_800000baseVR4_Full_BIT */
 };
 
-RTE_EXPORT_INTERNAL_SYMBOL(rte_eth_link_speed_ethtool)
-uint32_t
-rte_eth_link_speed_ethtool(enum ethtool_link_mode_bit_indices bit)
+static uint32_t
+eth_link_speed_ethtool(enum ethtool_link_mode_bit_indices bit)
 {
 	uint32_t speed;
 	int duplex;
@@ -171,7 +170,7 @@ rte_eth_link_speed_glink(const uint32_t *bitmap, int8_t nwords)
 		for (bit = 0; bit < 32; bit++) {
 			if ((bitmap[word] & RTE_BIT32(bit)) == 0)
 				continue;
-			ethdev_bitmap |= rte_eth_link_speed_ethtool(word * 32 + bit);
+			ethdev_bitmap |= eth_link_speed_ethtool(word * 32 + bit);
 		}
 	}
 
diff --git a/lib/ethdev/ethdev_linux_ethtool.h b/lib/ethdev/ethdev_linux_ethtool.h
index de235bd5f4..59fc84dfa0 100644
--- a/lib/ethdev/ethdev_linux_ethtool.h
+++ b/lib/ethdev/ethdev_linux_ethtool.h
@@ -14,12 +14,6 @@
 extern "C" {
 #endif
 
-/*
- * Convert bit from ETHTOOL_LINK_MODE_* to RTE_ETH_LINK_SPEED_*
- */
-__rte_internal
-uint32_t rte_eth_link_speed_ethtool(enum ethtool_link_mode_bit_indices bit);
-
 /*
  * Convert bitmap from ETHTOOL_GLINKSETTINGS ethtool_link_settings::link_mode_masks
  * to bitmap RTE_ETH_LINK_SPEED_*
-- 
2.50.1

Re: [PATCH] ethdev: hide internal ethtool symbol

[Thomas Monjalon]

20/08/2025 10:41, David Marchand:
> No code call this symbol out of ethdev, remove it from exported symbols
> and rename it.
> 
> Note: there is nothing particularly wrong with exporting this symbol.
> It is just unneeded, and this symbol referencing a linux kernel enum
> triggers a abidiff warning in the RHEL CI when this enum gets updated.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Re: [PATCH] ethdev: hide internal ethtool symbol

[Stephen Hemminger]

On Wed, 20 Aug 2025 10:41:46 +0200
David Marchand <david.marchand@redhat.com> wrote:

> No code call this symbol out of ethdev, remove it from exported symbols
> and rename it.
> 
> Note: there is nothing particularly wrong with exporting this symbol.
> It is just unneeded, and this symbol referencing a linux kernel enum
> triggers a abidiff warning in the RHEL CI when this enum gets updated.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Queued in next-net