From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] devtools: ignore new warnings on reported-by tag
Date: Wed, 20 Aug 2025 15:58:30 +0200 [thread overview]
Message-ID: <20250820135830.pn3fi3p6rq7xlnyz@ds-vm-debian.local> (raw)
In-Reply-To: <2450283.yKrmzQ4Hd0@thomas>
On Wed, Aug 20, 2025 at 03:33:00PM +0200, Thomas Monjalon wrote:
> 20/08/2025 11:50, Dariusz Sosnowski:
> > There were 2 changes introduced in checkpatch.pl script [1][2]
> > which verify if Reported-by tag is followed by Link or Closes tag.
> > Example of the warning output:
> >
> > WARNING:BAD_REPORTED_BY_LINK:
> > Reported-by: should be immediately followed by Closes:
> > with a URL to the report
> >
> > Original purpose is to link the patch to the mailing list discussion
> > and/or a bug report.
> >
> > Since in DPDK these tags are not used, these warnings are false
> > positives and can be ignored in devtools/checkpatches.sh.
>
> We use "Reported-by", it gives credit to people doing this precious work.
> But we don't mandate a link for this credit.
Sorry, maybe my commit message was misleading.
I was referring to Link and Closes tags in that last sentence.
The new check in checkpatch.pl will warn if there is no Link or Closes
tag assuming Reported-by is present.
It does not warn on Reported-by itself.
> /* snip */
prev parent reply other threads:[~2025-08-20 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 9:50 Dariusz Sosnowski
2025-08-20 10:35 ` Bruce Richardson
2025-08-20 13:33 ` Thomas Monjalon
2025-08-20 13:58 ` Dariusz Sosnowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820135830.pn3fi3p6rq7xlnyz@ds-vm-debian.local \
--to=dsosnowski@nvidia.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).