From: Stephen Hemminger <stephen@networkplumber.org>
To: Sunil Kumar Kori <skori@marvell.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"dev@dpdk.org" <dev@dpdk.org>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>
Subject: Re: [EXTERNAL] Re: [PATCH v7 1/1] ethdev: add support to provide link type
Date: Thu, 21 Aug 2025 08:20:12 -0700 [thread overview]
Message-ID: <20250821082012.1264dbc1@hermes.local> (raw)
In-Reply-To: <SN7PR18MB386917862951DD1A6ABE715FB432A@SN7PR18MB3869.namprd18.prod.outlook.com>
On Thu, 21 Aug 2025 04:51:47 +0000
Sunil Kumar Kori <skori@marvell.com> wrote:
> >
> > IMHO adding a trace point to a helper function like this is just extra clutter,
> > remove it.
> >
> Ack, I will share a separate patch to add trace in this API.
No, please no tracepoint. Tracing is meant for datapath and control path operations
not every helper library. For example, the string functions should not have tracing.
next prev parent reply other threads:[~2025-08-21 15:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 11:31 [PATCH] " skori
2025-06-05 15:26 ` Stephen Hemminger
2025-06-06 9:28 ` [PATCH v2 1/1] " skori
2025-06-06 9:54 ` Morten Brørup
2025-06-06 15:23 ` Stephen Hemminger
2025-06-10 5:02 ` [EXTERNAL] " Sunil Kumar Kori
2025-06-10 6:45 ` Morten Brørup
2025-08-13 7:42 ` Sunil Kumar Kori
2025-08-13 8:42 ` [PATCH] " skori
2025-08-13 8:43 ` [PATCH v3 1/1] " skori
2025-08-13 10:25 ` Thomas Monjalon
2025-08-13 12:16 ` Ivan Malov
2025-08-13 14:17 ` Stephen Hemminger
2025-08-14 5:09 ` [EXTERNAL] " Sunil Kumar Kori
2025-08-13 15:04 ` Stephen Hemminger
2025-08-14 8:10 ` [PATCH v4 " skori
2025-08-14 9:04 ` Morten Brørup
2025-08-14 16:15 ` Stephen Hemminger
2025-08-18 6:21 ` [EXTERNAL] " Sunil Kumar Kori
2025-08-18 7:24 ` Morten Brørup
2025-08-18 8:13 ` Ivan Malov
2025-08-18 8:39 ` Morten Brørup
2025-08-18 8:50 ` Ivan Malov
2025-08-18 22:41 ` Jochen Behrens
2025-08-19 9:57 ` Morten Brørup
2025-08-18 6:20 ` Sunil Kumar Kori
2025-08-14 16:07 ` Stephen Hemminger
2025-08-18 6:13 ` [EXTERNAL] " Sunil Kumar Kori
2025-08-19 5:51 ` [PATCH v5 " skori
2025-08-19 16:29 ` Stephen Hemminger
2025-08-20 9:55 ` [EXTERNAL] " Sunil Kumar Kori
2025-08-20 11:13 ` [PATCH v6 " skori
2025-08-20 12:51 ` Morten Brørup
2025-08-20 17:52 ` [PATCH v7 " skori
2025-08-20 18:58 ` Stephen Hemminger
2025-08-21 4:51 ` [EXTERNAL] " Sunil Kumar Kori
2025-08-21 15:20 ` Stephen Hemminger [this message]
2025-08-21 5:32 ` [PATCH v8 " skori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821082012.1264dbc1@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).