From: Stephen Hemminger <stephen@networkplumber.org>
To: Tejasree Kondoj <ktejasree@marvell.com>
Cc: Akhil Goyal <gakhil@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Aakash Sasidharan <asasidharan@marvell.com>,
Nithinsen Kaithakadan <nkaithakadan@marvell.com>,
Rupesh Chiluka <rchiluka@marvell.com>,
Sucharitha Sarananaga <ssarananaga@marvell.com>,
Vidya Sagar Velumuri <vvelumuri@marvell.com>, <dev@dpdk.org>
Subject: Re: [PATCH v2 0/8] fixes and improvements to cnxk crypto PMD
Date: Thu, 21 Aug 2025 08:35:25 -0700 [thread overview]
Message-ID: <20250821083525.094aeabe@hermes.local> (raw)
In-Reply-To: <20250821061341.3790775-1-ktejasree@marvell.com>
On Thu, 21 Aug 2025 11:43:33 +0530
Tejasree Kondoj <ktejasree@marvell.com> wrote:
> Adding fixes and improvements to cnxk crypto PMD.
>
> v2:
> - Fixed coding style issues.
>
> Nithinsen Kaithakadan (3):
> common/cnxk: get context ilen as devarg
> crypto/cnxk: fix compilation error and warnings
> crypto/cnxk: align cptr to 256B in cn20k
>
> Sucharitha Sarananaga (3):
> crypto/cnxk: add new API to get fpm tbl address
> crypto/cnxk: add new API to get EC grp tbl address
> crypto/cnxk: refactor rsa verification
>
> Tejasree Kondoj (2):
> crypto/cnxk: align PDCP API with latest firmware
> crypto/cnxk: support custom metadata with CN20K
>
> doc/guides/cryptodevs/cnxk.rst | 11 +
> drivers/common/cnxk/cnxk_security.c | 20 +-
> drivers/common/cnxk/cnxk_security.h | 25 +-
> drivers/common/cnxk/hw/cpt.h | 14 +-
> drivers/common/cnxk/roc_cpt.c | 8 +-
> drivers/common/cnxk/roc_cpt.h | 5 +
> drivers/common/cnxk/roc_se.h | 37 +-
> drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 16 +-
> drivers/crypto/cnxk/cn10k_ipsec.c | 4 +-
> drivers/crypto/cnxk/cn10k_tls.c | 16 +-
> drivers/crypto/cnxk/cn20k_cryptodev_ops.c | 20 +-
> drivers/crypto/cnxk/cn20k_ipsec.c | 80 +++--
> drivers/crypto/cnxk/cn20k_ipsec.h | 15 +-
> drivers/crypto/cnxk/cn20k_ipsec_la_ops.h | 41 ++-
> drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 4 +-
> drivers/crypto/cnxk/cnxk_ae.h | 15 +-
> drivers/crypto/cnxk/cnxk_cryptodev.h | 1 +
> drivers/crypto/cnxk/cnxk_cryptodev_devargs.c | 49 +++
> drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 130 ++++++-
> drivers/crypto/cnxk/cnxk_se.h | 340 +++++++++++++------
> drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h | 96 ++++++
> drivers/net/cnxk/cn10k_ethdev_sec.c | 14 +-
> drivers/net/cnxk/cn20k_ethdev_sec.c | 8 +-
> 23 files changed, 725 insertions(+), 244 deletions(-)
>
I have been doing test builds with more warnings enabled.
These drivers have a lot of shadowed variables which are often a source of bugs.
In file included from ../drivers/crypto/cnxk/cnxk_cryptodev_ops.c:30:
../drivers/crypto/cnxk/cnxk_se.h: In function ‘cpt_sm_prep’:
../drivers/crypto/cnxk/cnxk_se.h:1160:41: warning: declaration of ‘src’ shadows a previous local [-Wshadow]
1160 | const uint64_t *src = fc_params->iv_buf;
| ^~~
../drivers/crypto/cnxk/cnxk_se.h:1105:24: note: shadowed declaration is here
1105 | const uint8_t *src = NULL;
| ^~~
../drivers/crypto/cnxk/cnxk_se.h: In function ‘cpt_enc_hmac_prep’:
../drivers/crypto/cnxk/cnxk_se.h:1330:41: warning: declaration of ‘src’ shadows a previous local [-Wshadow]
1330 | const uint64_t *src = fc_params->iv_buf;
| ^~~
../drivers/crypto/cnxk/cnxk_se.h:1200:24: note: shadowed declaration is here
1200 | const uint8_t *src = NULL;
| ^~~
../drivers/crypto/cnxk/cnxk_se.h: In function ‘cpt_dec_hmac_prep’:
../drivers/crypto/cnxk/cnxk_se.h:1487:41: warning: declaration of ‘src’ shadows a previous local [-Wshadow]
1487 | const uint64_t *src = fc_params->iv_buf;
| ^~~
../drivers/crypto/cnxk/cnxk_se.h:1369:24: note: shadowed declaration is here
1369 | const uint8_t *src = NULL;
| ^~~
../drivers/crypto/cnxk/cnxk_se.h: In function ‘fill_digest_params’:
../drivers/crypto/cnxk/cnxk_se.h:3233:34: warning: declaration of ‘src’ shadows a previous local [-Wshadow]
3233 | uint8_t *src, direction = 0;
| ^~~
../drivers/crypto/cnxk/cnxk_se.h:3200:14: note: shadowed declaration is here
3200 | char src[SRC_IOV_SIZE];
| ^~~
../drivers/crypto/cnxk/cnxk_se.h:3273:39: warning: declaration of ‘space’ shadows a previous local [-Wshadow]
3273 | int32_t dlen, space;
| ^~~~~
../drivers/crypto/cnxk/cnxk_se.h:3190:18: note: shadowed declaration is here
3190 | uint32_t space = 0;
| ^~~~~
../drivers/crypto/cnxk/cnxk_se.h: In function ‘fill_raw_fc_params’:
../drivers/crypto/cnxk/cnxk_se.h:3576:12: warning: this condition has identical branches [-Wduplicated-branches]
3576 | if (is_kasumi) {
| ^
next prev parent reply other threads:[~2025-08-21 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 6:13 Tejasree Kondoj
2025-08-21 6:13 ` [PATCH v2 1/8] common/cnxk: get context ilen as devarg Tejasree Kondoj
2025-08-21 6:13 ` [PATCH v2 2/8] crypto/cnxk: fix compilation error and warnings Tejasree Kondoj
2025-08-21 6:13 ` [PATCH v2 3/8] crypto/cnxk: add new API to get fpm tbl address Tejasree Kondoj
2025-08-21 6:13 ` [PATCH v2 4/8] crypto/cnxk: add new API to get EC grp " Tejasree Kondoj
2025-08-21 6:13 ` [PATCH v2 5/8] crypto/cnxk: align cptr to 256B in cn20k Tejasree Kondoj
2025-08-21 6:13 ` [PATCH v2 6/8] crypto/cnxk: refactor rsa verification Tejasree Kondoj
2025-08-21 6:13 ` [PATCH v2 7/8] crypto/cnxk: align PDCP API with latest firmware Tejasree Kondoj
2025-08-21 6:13 ` [PATCH v2 8/8] crypto/cnxk: support custom metadata with CN20K Tejasree Kondoj
2025-08-21 15:35 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-20 5:27 [PATCH v2 0/8] fixes and improvements to CNXK crypto PMD Tejasree Kondoj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821083525.094aeabe@hermes.local \
--to=stephen@networkplumber.org \
--cc=anoobj@marvell.com \
--cc=asasidharan@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=ktejasree@marvell.com \
--cc=nkaithakadan@marvell.com \
--cc=rchiluka@marvell.com \
--cc=ssarananaga@marvell.com \
--cc=vvelumuri@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).