From: "Morten Brørup" <mb@smartsharesystems.com>
To: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Stephen Hemminger <stephen@networkplumber.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.ananyev@huawei.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ivan Malov <ivan.malov@arknetworks.am>,
Chengwen Feng <fengchengwen@huawei.com>
Cc: "Morten Brørup" <mb@smartsharesystems.com>
Subject: [PATCH v4 3/3] mbuf: no need to reset all fields on reinitialized mbufs
Date: Thu, 21 Aug 2025 14:25:44 +0000 [thread overview]
Message-ID: <20250821142544.16211-4-mb@smartsharesystems.com> (raw)
In-Reply-To: <20250821142544.16211-1-mb@smartsharesystems.com>
The 'next' and 'nb_segs' fields are already reset on newly allocated
reinitialized mbufs (a.k.a. raw mbufs), so a simpler reset function for
such mbufs was added.
Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
---
lib/mbuf/rte_mbuf.h | 39 ++++++++++++++++++++++++++++++++++-----
1 file changed, 34 insertions(+), 5 deletions(-)
diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
index 49c93ab356..3517ca6858 100644
--- a/lib/mbuf/rte_mbuf.h
+++ b/lib/mbuf/rte_mbuf.h
@@ -954,6 +954,35 @@ static inline void rte_pktmbuf_reset_headroom(struct rte_mbuf *m)
(uint16_t)m->buf_len);
}
+/**
+ * Reset the fields of a packet mbuf to their default values.
+ *
+ * The caller must ensure that the mbuf is direct and properly
+ * reinitialized (refcnt=1, next=NULL, nb_segs=1), as done by
+ * rte_pktmbuf_prefree_seg().
+ *
+ * This function should be used with care, when optimization is required.
+ * For standard needs, prefer rte_pktmbuf_reset().
+ *
+ * @param m
+ * The packet mbuf to be reset.
+ */
+static inline void rte_mbuf_raw_reset(struct rte_mbuf *m)
+{
+ m->pkt_len = 0;
+ m->tx_offload = 0;
+ m->vlan_tci = 0;
+ m->vlan_tci_outer = 0;
+ m->port = RTE_MBUF_PORT_INVALID;
+
+ m->ol_flags &= RTE_MBUF_F_EXTERNAL;
+ m->packet_type = 0;
+ rte_pktmbuf_reset_headroom(m);
+
+ m->data_len = 0;
+ __rte_mbuf_sanity_check(m, 1);
+}
+
/**
* Reset the fields of a packet mbuf to their default values.
*
@@ -997,7 +1026,7 @@ static inline struct rte_mbuf *rte_pktmbuf_alloc(struct rte_mempool *mp)
{
struct rte_mbuf *m;
if ((m = rte_mbuf_raw_alloc(mp)) != NULL)
- rte_pktmbuf_reset(m);
+ rte_mbuf_raw_reset(m);
return m;
}
@@ -1033,19 +1062,19 @@ static inline int rte_pktmbuf_alloc_bulk(struct rte_mempool *pool,
switch (count % 4) {
case 0:
while (idx != count) {
- rte_pktmbuf_reset(mbufs[idx]);
+ rte_mbuf_raw_reset(mbufs[idx]);
idx++;
/* fall-through */
case 3:
- rte_pktmbuf_reset(mbufs[idx]);
+ rte_mbuf_raw_reset(mbufs[idx]);
idx++;
/* fall-through */
case 2:
- rte_pktmbuf_reset(mbufs[idx]);
+ rte_mbuf_raw_reset(mbufs[idx]);
idx++;
/* fall-through */
case 1:
- rte_pktmbuf_reset(mbufs[idx]);
+ rte_mbuf_raw_reset(mbufs[idx]);
idx++;
/* fall-through */
}
--
2.43.0
prev parent reply other threads:[~2025-08-21 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 14:25 [PATCH v4 0/3] mbuf: simplify handling of " Morten Brørup
2025-08-21 14:25 ` [PATCH v4 1/3] mbuf: de-inline sanity checking a reinitialized mbuf Morten Brørup
2025-08-21 14:25 ` [PATCH v4 2/3] promote reinitialized mbuf free and alloc bulk functions as stable Morten Brørup
2025-08-21 14:25 ` Morten Brørup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821142544.16211-4-mb@smartsharesystems.com \
--to=mb@smartsharesystems.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ivan.malov@arknetworks.am \
--cc=konstantin.ananyev@huawei.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).