DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Rosen Xu <rosen.xu@altera.com>
Subject: [PATCH v2 38/43] raw/ifpga: replace with TAILQ_FOREACH_SAFE
Date: Sun, 24 Aug 2025 20:38:51 -0700	[thread overview]
Message-ID: <20250825034126.12046-39-stephen@networkplumber.org> (raw)
In-Reply-To: <20250825034126.12046-1-stephen@networkplumber.org>

There is now a standard macro to safely walk tailq.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/raw/ifpga/base/ifpga_enumerate.c         | 6 +++---
 drivers/raw/ifpga/base/opae_hw_api.h             | 1 -
 drivers/raw/ifpga/base/opae_intel_max10.c        | 8 +-------
 drivers/raw/ifpga/base/osdep_rte/osdep_generic.h | 1 +
 4 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/drivers/raw/ifpga/base/ifpga_enumerate.c b/drivers/raw/ifpga/base/ifpga_enumerate.c
index 61eb6601ea..f8507fdf46 100644
--- a/drivers/raw/ifpga/base/ifpga_enumerate.c
+++ b/drivers/raw/ifpga/base/ifpga_enumerate.c
@@ -6,6 +6,8 @@
 #include <inttypes.h>
 #include <unistd.h>
 
+#include <rte_bsd_queue.h>
+
 #include "opae_hw_api.h"
 #include "ifpga_api.h"
 
@@ -725,9 +727,7 @@ static void dfl_fpga_enum_info_free(struct dfl_fpga_enum_info *info)
 		return;
 
 	/* remove all device feature lists in the list. */
-	for (dfl = TAILQ_FIRST(&info->dfls);
-		dfl && (tmp = TAILQ_NEXT(dfl, node), 1);
-		dfl = tmp) {
+	TAILQ_FOREACH_SAFE(dfl, &info->dfls, node, tmp) {
 		TAILQ_REMOVE(&info->dfls, dfl, node);
 		opae_free(dfl);
 	}
diff --git a/drivers/raw/ifpga/base/opae_hw_api.h b/drivers/raw/ifpga/base/opae_hw_api.h
index 57750022dd..f95bdf35b6 100644
--- a/drivers/raw/ifpga/base/opae_hw_api.h
+++ b/drivers/raw/ifpga/base/opae_hw_api.h
@@ -8,7 +8,6 @@
 #include <stdint.h>
 #include <stdlib.h>
 #include <stdio.h>
-#include <sys/queue.h>
 
 #include "opae_osdep.h"
 #include "opae_intel_max10.h"
diff --git a/drivers/raw/ifpga/base/opae_intel_max10.c b/drivers/raw/ifpga/base/opae_intel_max10.c
index 58c884a8d8..84e0767b3a 100644
--- a/drivers/raw/ifpga/base/opae_intel_max10.c
+++ b/drivers/raw/ifpga/base/opae_intel_max10.c
@@ -4,14 +4,8 @@
 
 #include "opae_intel_max10.h"
 #include <libfdt.h>
-#include "opae_osdep.h"
 
-#ifndef TAILQ_FOREACH_SAFE
-#define TAILQ_FOREACH_SAFE(var, head, field, tvar) \
-	for ((var) = TAILQ_FIRST((head)); \
-		(var) && ((tvar) = TAILQ_NEXT((var), field), 1); \
-	(var) = (tvar))
-#endif
+#include "opae_osdep.h"
 
 int max10_sys_read(struct intel_max10_device *dev,
 	unsigned int offset, unsigned int *val)
diff --git a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h
index d4e634c9d2..0ff2700384 100644
--- a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h
+++ b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h
@@ -8,6 +8,7 @@
 #include <stdlib.h>
 
 #include <rte_common.h>
+#include <rte_bsd_queue.h>
 #include <rte_cycles.h>
 #include <rte_spinlock.h>
 #include <rte_log.h>
-- 
2.47.2


  parent reply	other threads:[~2025-08-25  3:45 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 23:27 [RFC 00/47] resolve issues with sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 01/47] eal: add BSD version of queue.h Stephen Hemminger
2025-08-19  8:00   ` Bruce Richardson
2025-08-19  8:37   ` Thomas Monjalon
2025-08-19 15:24     ` Stephen Hemminger
2025-08-19 15:29       ` Thomas Monjalon
2025-08-19 15:40         ` Bruce Richardson
2025-08-19 16:03           ` Stephen Hemminger
2025-08-19 16:07             ` Bruce Richardson
2025-08-19 17:46               ` Stephen Hemminger
2025-08-19 17:44         ` Stephen Hemminger
2025-08-18 23:27 ` [RFC 02/47] net/nfp: fix use after free Stephen Hemminger
2025-08-18 23:27 ` [RFC 03/47] eal: use bsd_queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 04/47] test: remove unnecessary inclusion of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 05/47] testpmd: use bsd_queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 06/47] dumpcap: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 07/47] proc-info: remove unnecessary sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 08/47] doc: suggest bsd_queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 09/47] test-pipeline: remove unnecessary use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 10/47] test-eventdev: use bsd_queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 11/47] test-bbdev, test-cmdline, test-mldev: don't use sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 12/47] examples: replace use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 13/47] hash: do not include sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 14/47] lpm: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 15/47] log: replace use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 16/47] ethdev: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 17/47] bpf: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 18/47] mempool: do not need sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 19/47] lib: remove use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 20/47] bus/fslmc: use rte_tailq.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 21/47] drivers/bus: replace use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 22/47] net/qede: use bsd_queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 23/47] net/bnxt: remove use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 24/47] net/intel: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 25/47] net/mlx5: remove unnecessary include " Stephen Hemminger
2025-08-18 23:27 ` [RFC 26/47] net/tap: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 27/47] net/axgbe: replace use " Stephen Hemminger
2025-08-18 23:27 ` [RFC 28/47] net/bnx2x: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 29/47] net/bonding: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 30/47] net/cxgbe: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 31/47] net/enic: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 32/47] net/failsafe: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 33/47] net/memif: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 34/47] net/mlx4: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 35/47] net/ngbe: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 36/47] net/ntnic: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 37/47] net/sfc: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 38/47] net/softnic: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 39/47] net/thunderx: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 40/47] net/txgbe: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 41/47] net/vdev_netvsc: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 42/47] net/vmxnet3: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 43/47] net/zxdh: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 44/47] net/dpaa2: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 45/47] eal: remove no longer used windows version of queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 46/47] net/mvpp2: replace local definition of FOREACH_SAFE Stephen Hemminger
2025-08-18 23:27 ` [RFC 47/47] drivers/raw: replace with TAILQ_FOREACH_SAFE Stephen Hemminger
2025-08-19  8:01 ` [RFC 00/47] resolve issues with sys/queue.h Bruce Richardson
2025-08-25  3:38 ` [PATCH v2 00/43] Introduce more complete queue.h macros Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 01/43] net/nfp: fix use after free Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 02/43] eal: add BSD version of queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 03/43] test: remove unnecessary inclusion of sys/queue.h Stephen Hemminger
2025-08-25  6:55     ` Andrew Rybchenko
2025-08-25  3:38   ` [PATCH v2 04/43] test-pipeline: remove unnecessary use " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 05/43] test-eventdev: use rte_bsd_queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 06/43] test-bbdev, test-cmdline, test-mldev: don't use sys/queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 07/43] app/testpmd: use rte_bsd_queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 08/43] apps: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 09/43] examples: replace use of sys/queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 10/43] ethdev: " Stephen Hemminger
2025-08-25  6:48     ` Andrew Rybchenko
2025-08-25  3:38   ` [PATCH v2 11/43] lib: remove " Stephen Hemminger
2025-08-25  7:05     ` Andrew Rybchenko
2025-08-25  3:38   ` [PATCH v2 12/43] drivers/bus: replace " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 13/43] net/nfp: use rte_bsd_queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 14/43] net/qede: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 15/43] net/bnxt: remove use of sys/queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 16/43] net/intel: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 17/43] net/mlx5: remove unnecessary include " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 18/43] net/mlx4: replace use " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 19/43] net/tap: remove unnecessary include " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 20/43] net/axgbe: replace use " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 21/43] net/bnx2x: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 22/43] net/bonding: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 23/43] net/cxgbe: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 24/43] net/enic: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 25/43] net/failsafe: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 26/43] net/memif: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 27/43] net/ngbe: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 28/43] net/ntnic: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 29/43] net/sfc: " Stephen Hemminger
2025-08-25  6:47     ` Andrew Rybchenko
2025-08-25  3:38   ` [PATCH v2 30/43] net/softnic: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 31/43] net/thunderx: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 32/43] net/txgbe: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 33/43] net/vdev_netvsc: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 34/43] net/vmxnet3: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 35/43] net/zxdh: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 36/43] net/dpaa2: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 37/43] net/mvpp2: replace local definition of FOREACH_SAFE Stephen Hemminger
2025-08-25  3:38   ` Stephen Hemminger [this message]
2025-08-25  3:38   ` [PATCH v2 39/43] drivers/vdpa: replace use of sys/queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 40/43] drivers/common: remove " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 41/43] drivers/crypto: remove use of sys_queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 42/43] drivers/event: remove include of sys/queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 43/43] eal: remove no longer used windows version " Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250825034126.12046-39-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=rosen.xu@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).