From: Joshua Washington <joshwash@google.com>
To: Jeroen de Borst <jeroendb@google.com>,
Joshua Washington <joshwash@google.com>
Cc: dev@dpdk.org, Ankit Garg <nktgrg@google.com>
Subject: [PATCH 2/4] net/gve: add datapath-specific logging for gve
Date: Mon, 25 Aug 2025 17:03:35 -0700 [thread overview]
Message-ID: <20250826000337.3922883-3-joshwash@google.com> (raw)
In-Reply-To: <20250826000337.3922883-1-joshwash@google.com>
This would allow for separate control of datapath-related logs vs
non-datapath logs.
Signed-off-by: Joshua Washington <joshwash@google.com>
Reviewed-by: Ankit Garg <nktgrg@google.com>
---
drivers/net/gve/gve_logs.h | 3 +++
drivers/net/gve/gve_rx_dqo.c | 5 +++--
drivers/net/gve/gve_tx_dqo.c | 11 ++++++-----
3 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/net/gve/gve_logs.h b/drivers/net/gve/gve_logs.h
index a3d50fa45c..beada20e02 100644
--- a/drivers/net/gve/gve_logs.h
+++ b/drivers/net/gve/gve_logs.h
@@ -11,4 +11,7 @@ extern int gve_logtype_driver;
#define PMD_DRV_LOG(level, ...) \
RTE_LOG_LINE_PREFIX(level, GVE_DRIVER, "%s(): ", __func__, __VA_ARGS__)
+#define PMD_DRV_DP_LOG(level, ...) \
+ RTE_LOG_DP_LINE_PREFIX(level, GVE_DRIVER, "%s(): ", __func__, __VA_ARGS__)
+
#endif
diff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c
index cd85d90bb6..ccaca1b0ea 100644
--- a/drivers/net/gve/gve_rx_dqo.c
+++ b/drivers/net/gve/gve_rx_dqo.c
@@ -27,8 +27,9 @@ gve_rx_refill_dqo(struct gve_rx_queue *rxq)
rxq->stats.no_mbufs += nb_refill;
dev = &rte_eth_devices[rxq->port_id];
dev->data->rx_mbuf_alloc_failed += nb_refill;
- PMD_DRV_LOG(DEBUG, "RX mbuf alloc failed port_id=%u queue_id=%u",
- rxq->port_id, rxq->queue_id);
+ PMD_DRV_DP_LOG(DEBUG,
+ "RX mbuf alloc failed port_id=%u queue_id=%u",
+ rxq->port_id, rxq->queue_id);
return;
}
diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c
index c36c215b94..10ef645802 100644
--- a/drivers/net/gve/gve_tx_dqo.c
+++ b/drivers/net/gve/gve_tx_dqo.c
@@ -42,7 +42,7 @@ gve_tx_clean_dqo(struct gve_tx_queue *txq)
aim_txq->last_desc_cleaned = compl_tag;
break;
case GVE_COMPL_TYPE_DQO_REINJECTION:
- PMD_DRV_LOG(DEBUG, "GVE_COMPL_TYPE_DQO_REINJECTION !!!");
+ PMD_DRV_DP_LOG(DEBUG, "GVE_COMPL_TYPE_DQO_REINJECTION !!!");
/* FALLTHROUGH */
case GVE_COMPL_TYPE_DQO_PKT:
/* free all segments. */
@@ -58,10 +58,10 @@ gve_tx_clean_dqo(struct gve_tx_queue *txq)
break;
case GVE_COMPL_TYPE_DQO_MISS:
rte_delay_us_sleep(1);
- PMD_DRV_LOG(DEBUG, "GVE_COMPL_TYPE_DQO_MISS ignored !!!");
+ PMD_DRV_DP_LOG(DEBUG, "GVE_COMPL_TYPE_DQO_MISS ignored !!!");
break;
default:
- PMD_DRV_LOG(ERR, "unknown completion type.");
+ PMD_DRV_DP_LOG(ERR, "unknown completion type.");
return;
}
@@ -206,7 +206,7 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
if (rte_mbuf_check(tx_pkt, true, &reason)) {
- PMD_DRV_LOG(DEBUG, "Invalid mbuf: %s", reason);
+ PMD_DRV_DP_LOG(DEBUG, "Invalid mbuf: %s", reason);
break;
}
@@ -243,7 +243,8 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
do {
if (sw_ring[sw_id] != NULL)
- PMD_DRV_LOG(DEBUG, "Overwriting an entry in sw_ring");
+ PMD_DRV_DP_LOG(DEBUG,
+ "Overwriting an entry in sw_ring");
/* Skip writing descriptor if mbuf has no data. */
if (!tx_pkt->data_len)
--
2.51.0.rc1.167.g924127e9c0-goog
next prev parent reply other threads:[~2025-08-26 0:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 0:03 [PATCH 0/4] net/gve: out of order completion processing for DQO Joshua Washington
2025-08-26 0:03 ` [PATCH 1/4] net/gve: free Rx mbufs if allocation fails on ring setup Joshua Washington
2025-08-26 0:03 ` Joshua Washington [this message]
2025-08-26 0:03 ` [PATCH 3/4] net/gve: support for out of order completions on DQ Tx Joshua Washington
2025-08-26 0:03 ` [PATCH 4/4] net/gve: support for out of order completions on DQ Rx Joshua Washington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826000337.3922883-3-joshwash@google.com \
--to=joshwash@google.com \
--cc=dev@dpdk.org \
--cc=jeroendb@google.com \
--cc=nktgrg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).