From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: <dev@dpdk.org>
Subject: Re: Ubuntu 20.04 EOL
Date: Thu, 28 Aug 2025 07:49:10 -0700 [thread overview]
Message-ID: <20250828074910.49eff575@hermes.local> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9FE7E@smartserver.smartshare.dk>
On Thu, 28 Aug 2025 08:50:23 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> >
> > Asking because the recent patch to handle shadow warnings doesn't work on
> > compilers like Gcc 9.4 which don't know what -Wshadow is.
>
> Our current minimum GCC compiler requirement is version 8.0:
> https://git.dpdk.org/dpdk/tree/doc/guides/linux_gsg/sys_reqs.rst#n32
>
> Which GCC version is required to support -Wshadow, and which GCC versions are included in relevant distros?
>
> Maybe the -Wshadow can be added conditionally, depending on compiler version.
> Shadow variables will not be caught locally, if using an old compiler version. But the CI will catch them in the tests running on recent compiler versions.
>
Meson handles that part fine. It is the Pragma logic that seems to confuse.
Working on doing it without pragma
prev parent reply other threads:[~2025-08-28 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 4:34 Stephen Hemminger
2025-08-28 6:44 ` Morten Brørup
2025-08-28 6:50 ` Morten Brørup
2025-08-28 14:49 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250828074910.49eff575@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).